[Bug fortran/41829] New: [OOP] Runtime error with dynamic dispatching

[Bug fortran/41829] New: [OOP] Runtime error with dynamic dispatching

[sfilippone at uniroma2 dot it]

Hello,


-- 
           Summary: [OOP] Runtime error with dynamic dispatching
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: sfilippone at uniroma2 dot it
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[sfilippone at uniroma2 dot it]

------- Comment #1 from sfilippone at uniroma2 dot it  2009-10-26 12:38 -------
(In reply to comment #0)
> Hello,
> 
Sorry, hit the keyboard too soon. 
With trunk at rev. 153550 the attached code compiles cleanly but does not work:
------------------------------------------------------------------------------
[sfilippo@donald bug10]$ gfortran -v
Using built-in specs.
COLLECT_GCC=gfortran
COLLECT_LTO_WRAPPER=/usr/local/gnu45/libexec/gcc/x86_64-unknown-linux-gnu/4.5.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc/configure --prefix=/usr/local/gnu45
--enable-languages=c,c++,fortran
Thread model: posix
gcc version 4.5.0 20091026 (experimental) (GCC) 
[sfilippo@donald bug10]$ gfortran -o td10 test-der10.f03
[sfilippo@donald bug10]$ ./td10 
 FOO%DOIT base version
 Getit value :            1
At line 69 of file test-der10.f03
Fortran runtime error: internal error: bad vindex in dynamic dispatch
------------------------------------------------------------------------

With the NAG compiler I get the expected result:
------------------------------------------------
 FOO%DOIT base version
 Getit value :  1
 FOO2%DOIT derived version
 Getit value :  3
-----------------------------------------------


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[sfilippone at uniroma2 dot it]

------- Comment #2 from sfilippone at uniroma2 dot it  2009-10-26 12:39 -------
Created an attachment (id=18897)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18897&action=view)
test case


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[janus at gcc dot gnu dot org]

------- Comment #3 from janus at gcc dot gnu dot org  2009-10-26 14:44 -------
Created an attachment (id=18898)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=18898&action=view)
another test case

This example nicely illustrates why we need a vtable. Here is a more
compactified version of the test case.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[pault at gcc dot gnu dot org]

------- Comment #4 from pault at gcc dot gnu dot org  2009-12-03 05:33 -------
Subject: Bug 41829

Author: pault
Date: Thu Dec  3 05:32:58 2009
New Revision: 154935

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154935
Log:
2009-12-03  Paul Thomas  <pault@gcc.gnu.org>
            Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42104
        * trans-expr.c (select_class_proc): Remove function.
        (conv_function_val): Delete reference to previous.
        (gfc_conv_derived_to_class): Add second argument to the call to
        gfc_find_derived_vtab.
        (gfc_conv_structure): Exclude proc_pointer components when
        accessing $data field of class objects.
        (gfc_trans_assign_vtab_procs): New function.
        (gfc_trans_class_assign): Add second argument to the call to
        gfc_find_derived_vtab.
        * symbol.c (gfc_build_class_symbol): Add delayed_vtab arg and
        implement holding off searching for the vptr derived type.
        (add_proc_component): New function.
        (add_proc_comps): New function.
        (add_procs_to_declared_vtab1): New function.
        (copy_vtab_proc_comps): New function.
        (add_procs_to_declared_vtab): New function.
        (void add_generic_specifics): New function.
        (add_generics_to_declared_vtab): New function.
        (gfc_find_derived_vtab): Add second argument to the call to
        gfc_find_derived_vtab. Add the calls to
        add_procs_to_declared_vtab and add_generics_to_declared_vtab.
        * decl.c (build_sym, build_struct): Use new arg in calls to
        gfc_build_class_symbol.
        * gfortran.h : Add vtype bitfield to symbol_attr. Remove the
        definition of struct gfc_class_esym_list. Modify prototypes
        of gfc_build_class_symbol and gfc_find_derived_vtab.
        * trans-stmt.c (gfc_trans_allocate): Add second argument to the
        call to gfc_find_derived_vtab.
        * module.c : Add the vtype attribute.
        * trans.h : Add prototype for gfc_trans_assign_vtab_procs.
        * resolve.c (resolve_typebound_generic_call): Add second arg
        to pass along the generic name for class methods.
        (resolve_typebound_call): The same.
        (resolve_compcall): Use the second arg to carry the generic
        name from the above. Remove the reference to class_esym.
        (check_members, check_class_members, resolve_class_esym,
        hash_value_expr): Remove functions.
        (resolve_class_compcall, resolve_class_typebound_call): Modify
        to use vtable rather than member by member calls.
        (gfc_resolve_expr): Modify second arg in call to
        resolve_compcall.
        (resolve_select_type): Add second arg in call to
        gfc_find_derived_vtab.
        (resolve_code): Add second arg in call resolve_typebound_call.
        (resolve_fl_derived): Exclude vtypes from check for late
        procedure definitions. Likewise for checking of explicit
        interface and checking of pass arg.
        * iresolve.c (gfc_resolve_extends_type_of): Add second arg in
        calls to gfc_find_derived_vtab.
        * match.c (select_type_set_tmp): Use new arg in call to
        gfc_build_class_symbol.
        * trans-decl.c (gfc_get_symbol_decl): Complete vtable if
        necessary.
        * parse.c (endType): Finish incomplete classes.


2009-12-03  Paul Thomas  <pault@gcc.gnu.org>
            Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41829
        * gfortran.dg/dynamic_dispatch_5.f03 : Change to "run".
        * gfortran.dg/dynamic_dispatch_6.f03 : New test.
        * gfortran.dg/dynamic_dispatch_7.f03 : New test.


Added:
    branches/fortran-dev/gcc/testsuite/gfortran.dg/dynamic_dispatch_6.f03
    branches/fortran-dev/gcc/testsuite/gfortran.dg/dynamic_dispatch_7.f03
Modified:
    branches/fortran-dev/gcc/fortran/ChangeLog.fortran-dev
    branches/fortran-dev/gcc/fortran/decl.c
    branches/fortran-dev/gcc/fortran/gfortran.h
    branches/fortran-dev/gcc/fortran/iresolve.c
    branches/fortran-dev/gcc/fortran/match.c
    branches/fortran-dev/gcc/fortran/module.c
    branches/fortran-dev/gcc/fortran/parse.c
    branches/fortran-dev/gcc/fortran/resolve.c
    branches/fortran-dev/gcc/fortran/symbol.c
    branches/fortran-dev/gcc/fortran/trans-decl.c
    branches/fortran-dev/gcc/fortran/trans-expr.c
    branches/fortran-dev/gcc/fortran/trans-stmt.c
    branches/fortran-dev/gcc/fortran/trans.h
    branches/fortran-dev/gcc/testsuite/ChangeLog.fortran-dev
    branches/fortran-dev/gcc/testsuite/gfortran.dg/dynamic_dispatch_5.f03


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[dominiq at lps dot ens dot fr]

------- Comment #5 from dominiq at lps dot ens dot fr  2010-04-18 15:42 -------
Confirmed with trunk, fixed with fortran-dev.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2010-04-29 19:11 -------
Subject: Bug 41829

Author: pault
Date: Thu Apr 29 19:10:48 2010
New Revision: 158910

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=158910
Log:
2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/43896
        * symbol.c (add_proc_component,copy_vtab_proc_comps): Remove
        initializers for PPC members of the vtabs.

2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42274
        * symbol.c (add_proc_component,add_proc_comps): Correctly set the 'ppc'
        attribute for all PPC members of the vtypes.
        (copy_vtab_proc_comps): Copy the correct interface.
        * trans.h (gfc_trans_assign_vtab_procs): Modified prototype.
        * trans-expr.c (gfc_trans_assign_vtab_procs): Pass the derived type as
        a dummy argument and make sure all PPC members of the vtab are
        initialized correctly.
        (gfc_conv_derived_to_class,gfc_trans_class_assign): Additional argument
        in call to gfc_trans_assign_vtab_procs.
        * trans-stmt.c (gfc_trans_allocate): Ditto.

2010-04-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/43326
        * resolve.c (resolve_typebound_function): Renamed
        resolve_class_compcall.Do all the detection of class references
        here.
        (resolve_typebound_subroutine): resolve_class_typebound_call
        renamed. Otherwise same as resolve_typebound_function.
        (gfc_resolve_expr): Call resolve_typebound_function.
        (resolve_code): Call resolve_typebound_subroutine.

2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/43492
        * resolve.c (resolve_typebound_generic_call): For CLASS methods
        pass back the specific symtree name, rather than the target
        name.

2010-04-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/42353
        * resolve.c (resolve_structure_cons): Make the initializer of
        the vtab component 'extends' the same type as the component.

2010-04-29  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/42680
        * interface.c (check_interface1): Pass symbol name rather than NULL to
        gfc_compare_interfaces.(gfc_compare_interfaces): Add assert to
        trap MULL. (gfc_compare_derived_types): Revert previous change
        incorporated incorrectly during merge from trunk, r155778.
        * resolve.c (check_generic_tbp_ambiguity): Pass symbol name rather
        than NULL to gfc_compare_interfaces.
        * symbol.c (add_generic_specifics): Likewise.

2010-02-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42353
        * interface.c (gfc_compare_derived_types): Add condition for vtype.
        * symbol.c (gfc_find_derived_vtab): Sey access to private.
        (gfc_find_derived_vtab): Likewise.
        * module.c (ab_attribute): Add enumerator AB_VTAB.
        (mio_symbol_attribute): Use new attribute, AB_VTAB.
        (check_for_ambiguous): Likewise.

2010-04-29  Paul Thomas  <pault@gcc.gnu.org>
            Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41829
        * trans-expr.c (select_class_proc): Remove function.
        (conv_function_val): Delete reference to previous.
        (gfc_conv_derived_to_class): Add second argument to the call to
        gfc_find_derived_vtab.
        (gfc_conv_structure): Exclude proc_pointer components when
        accessing $data field of class objects.
        (gfc_trans_assign_vtab_procs): New function.
        (gfc_trans_class_assign): Add second argument to the call to
        gfc_find_derived_vtab.
        * symbol.c (gfc_build_class_symbol): Add delayed_vtab arg and
        implement holding off searching for the vptr derived type.
        (add_proc_component): New function.
        (add_proc_comps): New function.
        (add_procs_to_declared_vtab1): New function.
        (copy_vtab_proc_comps): New function.
        (add_procs_to_declared_vtab): New function.
        (void add_generic_specifics): New function.
        (add_generics_to_declared_vtab): New function.
        (gfc_find_derived_vtab): Add second argument to the call to
        gfc_find_derived_vtab. Add the calls to
        add_procs_to_declared_vtab and add_generics_to_declared_vtab.
        * decl.c (build_sym, build_struct): Use new arg in calls to
        gfc_build_class_symbol.
        * gfortran.h : Add vtype bitfield to symbol_attr. Remove the
        definition of struct gfc_class_esym_list. Modify prototypes
        of gfc_build_class_symbol and gfc_find_derived_vtab.
        * trans-stmt.c (gfc_trans_allocate): Add second argument to the
        call to gfc_find_derived_vtab.
        * module.c : Add the vtype attribute.
        * trans.h : Add prototype for gfc_trans_assign_vtab_procs.
        * resolve.c (resolve_typebound_generic_call): Add second arg
        to pass along the generic name for class methods.
        (resolve_typebound_call): The same.
        (resolve_compcall): Use the second arg to carry the generic
        name from the above. Remove the reference to class_esym.
        (check_members, check_class_members, resolve_class_esym,
        hash_value_expr): Remove functions.
        (resolve_class_compcall, resolve_class_typebound_call): Modify
        to use vtable rather than member by member calls.
        (gfc_resolve_expr): Modify second arg in call to
        resolve_compcall.
        (resolve_select_type): Add second arg in call to
        gfc_find_derived_vtab.
        (resolve_code): Add second arg in call resolve_typebound_call.
        (resolve_fl_derived): Exclude vtypes from check for late
        procedure definitions. Likewise for checking of explicit
        interface and checking of pass arg.
        * iresolve.c (gfc_resolve_extends_type_of): Add second arg in
        calls to gfc_find_derived_vtab.
        * match.c (select_type_set_tmp): Use new arg in call to
        gfc_build_class_symbol.
        * trans-decl.c (gfc_get_symbol_decl): Complete vtable if
        necessary.
        * parse.c (endType): Finish incomplete classes.


2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42274
        * gfortran.dg/class_16.f03: New test.

2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/42274
        * gfortran.dg/class_15.f03: New.

2010-04-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/43326
        * gfortran.dg/dynamic_dispatch_9.f03: New test.

2010-04-29  Janus Weil  <janus@gcc.gnu.org>

        PR fortran/43492
        * gfortran.dg/generic_22.f03 : New test.

2010-04-29  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/42353
        * gfortran.dg/class_14.f03: New test.

2010-04-29  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR fortran/42680
        * gfortran.dg/interface_32.f90: New test.

2009-04-29  Paul Thomas  <pault@gcc.gnu.org>
            Janus Weil  <janus@gcc.gnu.org>

        PR fortran/41829
        * gfortran.dg/dynamic_dispatch_5.f03 : Change to "run".
        * gfortran.dg/dynamic_dispatch_7.f03 : New test.
        * gfortran.dg/dynamic_dispatch_8.f03 : New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/class_14.f03
    trunk/gcc/testsuite/gfortran.dg/class_15.f03
    trunk/gcc/testsuite/gfortran.dg/class_16.f03
    trunk/gcc/testsuite/gfortran.dg/dynamic_dispatch_8.f03
    trunk/gcc/testsuite/gfortran.dg/dynamic_dispatch_9.f03
    trunk/gcc/testsuite/gfortran.dg/generic_22.f03
    trunk/gcc/testsuite/gfortran.dg/interface_32.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/interface.c
    trunk/gcc/fortran/iresolve.c
    trunk/gcc/fortran/match.c
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/fortran/symbol.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/dynamic_dispatch_5.f03
    trunk/gcc/testsuite/gfortran.dg/dynamic_dispatch_7.f03


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829

[Bug fortran/41829] [OOP] Runtime error with dynamic dispatching

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2010-04-30 06:51 -------
Fixed on trunk.

Thanks for the help, Salvatore - I hope that it will continue.

Paul and Janus


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41829