public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "dfranke at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/32331] Better error message for variable bond of DATA implied do Date: Sat, 01 May 2010 18:30:00 -0000 [thread overview] Message-ID: <20100501183004.29565.qmail@sourceware.org> (raw) In-Reply-To: <bug-32331-13404@http.gcc.gnu.org/bugzilla/> ------- Comment #1 from dfranke at gcc dot gnu dot org 2010-05-01 18:30 ------- How about this? Index: resolve.c =================================================================== --- resolve.c (revision 158958) +++ resolve.c (working copy) @@ -11824,6 +11827,7 @@ traverse_data_list (gfc_data_variable *v gfc_try retval = SUCCESS; mpz_init (frame.value); + mpz_init (trip); start = gfc_copy_expr (var->iter.start); end = gfc_copy_expr (var->iter.end); @@ -11832,26 +11836,29 @@ traverse_data_list (gfc_data_variable *v if (gfc_simplify_expr (start, 1) == FAILURE || start->expr_type != EXPR_CONSTANT) { - gfc_error ("iterator start at %L does not simplify", &start->where); + gfc_error ("start of implied-do loop at %L can not be " + "simplified to a constant value ", &start->where); retval = FAILURE; goto cleanup; } if (gfc_simplify_expr (end, 1) == FAILURE || end->expr_type != EXPR_CONSTANT) { - gfc_error ("iterator end at %L does not simplify", &end->where); + gfc_error ("end of implied-do loop at %L can not be " + "simplified to a constant value ", &start->where); retval = FAILURE; goto cleanup; } if (gfc_simplify_expr (step, 1) == FAILURE || step->expr_type != EXPR_CONSTANT) { - gfc_error ("iterator step at %L does not simplify", &step->where); + gfc_error ("step of implied-do loop at %L can not be " + "simplified to a constant value ", &start->where); retval = FAILURE; goto cleanup; } - mpz_init_set (trip, end->value.integer); + mpz_set (trip, end->value.integer); mpz_sub (trip, trip, start->value.integer); mpz_add (trip, trip, step->value.integer); @@ -11867,7 +11874,6 @@ traverse_data_list (gfc_data_variable *v { if (traverse_data_var (var->list, where) == FAILURE) { - mpz_clear (trip); retval = FAILURE; goto cleanup; } @@ -11876,7 +11882,6 @@ traverse_data_list (gfc_data_variable *v if (gfc_simplify_expr (e, 1) == FAILURE) { gfc_free_expr (e); - mpz_clear (trip); retval = FAILURE; goto cleanup; } @@ -11886,9 +11891,9 @@ traverse_data_list (gfc_data_variable *v mpz_sub_ui (trip, trip, 1); } - mpz_clear (trip); cleanup: mpz_clear (frame.value); + mpz_clear (trip); gfc_free_expr (start); gfc_free_expr (end); -- dfranke at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dfranke at gcc dot gnu dot | |org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32331
next prev parent reply other threads:[~2010-05-01 18:30 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-06-14 6:14 [Bug fortran/32331] New: " burnus at gcc dot gnu dot org 2007-08-12 10:25 ` [Bug fortran/32331] " fxcoudert at gcc dot gnu dot org 2010-05-01 18:30 ` dfranke at gcc dot gnu dot org [this message] 2010-05-05 19:41 ` dfranke at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100501183004.29565.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).