public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/43983] var-tracking needlessly throws away location info for SRAed vars
Date: Wed, 05 May 2010 20:03:00 -0000	[thread overview]
Message-ID: <20100505200243.8639.qmail@sourceware.org> (raw)
In-Reply-To: <bug-43983-87@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from rguenth at gcc dot gnu dot org  2010-05-05 20:02 -------
(In reply to comment #3)
> Two issues discovered with the patch.  One is easy:
> --- gcc/dwarf2out.c 2010-05-05 17:14:56.000000000 +0200
> +++ gcc/dwarf2out.c 2010-05-05 20:51:40.000000000 +0200
> @@ -7916,7 +7916,7 @@
>                 {
>                   rtx piece = *piece_loc;
>                   diff -= decl_piece_bitsize (piece);
> -                 piece_loc = &XEXP (piece, 1);
> +                 *piece_loc = XEXP (piece, 1);
>                   free_EXPR_LIST_node (piece);
>                 }
>               /* Add padding if needed.  */
> 
> The other shows on various libgcc files with -m32 - apparently SRA leaves
> sometimes the original decl in the IL together with SRAed variables, the patch
> assumed that either the SRAed variables, or the original appear, but not both.

It indeed happens on purpose.  We in some cases re-build the aggregate
for aggregate uses.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43983


  parent reply	other threads:[~2010-05-05 20:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 15:11 [Bug debug/43983] New: " jakub at gcc dot gnu dot org
2010-05-04 15:13 ` [Bug debug/43983] " jakub at gcc dot gnu dot org
2010-05-05 15:22 ` jakub at gcc dot gnu dot org
2010-05-05 19:07 ` jakub at gcc dot gnu dot org
2010-05-05 20:03 ` rguenth at gcc dot gnu dot org [this message]
2010-05-06  8:45 ` jakub at gcc dot gnu dot org
2010-05-13 10:41 ` jakub at gcc dot gnu dot org
2010-05-13 10:53 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505200243.8639.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).