public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dje at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/43892] PowerPC suboptimal "add with carry" optimization
Date: Thu, 27 May 2010 01:37:00 -0000	[thread overview]
Message-ID: <20100527013716.31124.qmail@sourceware.org> (raw)
In-Reply-To: <bug-43892-19087@http.gcc.gnu.org/bugzilla/>



------- Comment #16 from dje at gcc dot gnu dot org  2010-05-27 01:37 -------
>> You have no patience, now do you?

> Sure I do. It is just that its been almost a month and from the
> description it sounded like an easy fix:
> "config/rs6000/rs6000.md would need to add a add<mode>cc expander"

No you do not have any patience; in fact, your comments are rather obnoxious,
such as: "its been almost a month".  If you do not know what you are talking
about, stop talking.  No, it is not an easy fix.  The high-level concept and
description is simple, the implementation is extremely complex and tedious.

>> even though it sounded that the
>> initial fix was easy(add<mode>cc expander)
> 
>> The fix will be a few thousand lines of patch.  Literally.

> Oops, just to add a cc expander?

Yes.  Again, if you do not know the complexity of what you are requesting, get
more information instead of acting annoyed that people are not jumping to solve
your problem.

It is not "just adding" a cc expander.  Do you even know what that means or
what it involves?  For the expander to be effective, the PowerPC port of GCC
needs to be taught to track the carry bit, which it currently does not.  *ALL*
patterns that produce instructions affecting the carry bit must be updated. 
One cannot add the pattern in isolation.

If you do not understand the implications of your request, then *ask* why it is
more complicated than you assumed.  There is no "simple" fix.  The only fix is
the ultimate fix: completely propagating the carry bit throughout the PowerPC
port.

You apparently have not read the documentation to understand the -mcpu= option
or the --with-cpu= configure option.  You are making a lot of incorrect
assumption and assertions, apparently without making any effort to gain some
knowledge before you start writing.  That really does not encourage anyone to
help you, especially when it requires a lot of work.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43892


  parent reply	other threads:[~2010-05-27  1:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 13:33 [Bug rtl-optimization/43892] New: " gcc-bugzilla at gcc dot gnu dot org
2010-04-26 13:39 ` [Bug rtl-optimization/43892] " jakub at gcc dot gnu dot org
2010-04-26 13:53 ` dje at gcc dot gnu dot org
2010-04-26 13:54 ` dje at gcc dot gnu dot org
2010-04-26 13:59 ` joakim dot tjernlund at transmode dot se
2010-04-26 14:43 ` rguenth at gcc dot gnu dot org
2010-04-26 15:19 ` joakim dot tjernlund at transmode dot se
2010-05-20 12:14 ` [Bug regression/43892] " joakim dot tjernlund at transmode dot se
2010-05-20 14:25 ` dje at gcc dot gnu dot org
2010-05-20 14:48 ` joakim dot tjernlund at transmode dot se
2010-05-21  0:28 ` dje at gcc dot gnu dot org
2010-05-21  6:23 ` joakim dot tjernlund at transmode dot se
2010-05-21 17:42 ` [Bug target/43892] " segher at gcc dot gnu dot org
2010-05-25 21:42 ` joakim dot tjernlund at transmode dot se
2010-05-26 16:46 ` segher at kernel dot crashing dot org
2010-05-26 20:47 ` joakim dot tjernlund at transmode dot se
2010-05-27  1:37 ` dje at gcc dot gnu dot org [this message]
2010-05-27  7:33 ` joakim dot tjernlund at transmode dot se
     [not found] <bug-43892-4@http.gcc.gnu.org/bugzilla/>
2010-09-29 12:45 ` joakim.tjernlund at transmode dot se
2015-01-18 16:34 ` segher at gcc dot gnu.org
2015-01-18 17:00 ` joakim.tjernlund at transmode dot se
2015-01-18 20:31 ` segher at gcc dot gnu.org
2015-01-18 21:44 ` joakim.tjernlund at transmode dot se
2015-01-18 22:54 ` segher at gcc dot gnu.org
2015-01-19  0:05 ` joakim.tjernlund at transmode dot se
2020-10-20 18:37 ` christophe.leroy at csgroup dot eu
2020-10-20 18:59 ` segher at gcc dot gnu.org
2020-10-20 19:37 ` joakim.tjernlund at infinera dot com
2020-10-21  6:09 ` christophe.leroy at csgroup dot eu
2020-10-21 19:28 ` segher at gcc dot gnu.org
2020-10-21 21:01 ` jakub at gcc dot gnu.org
2020-10-21 21:31 ` segher at gcc dot gnu.org
2021-06-03  1:50 ` pinskia at gcc dot gnu.org
2021-06-03  4:33 ` segher at gcc dot gnu.org
2021-06-03  7:00 ` joakim.tjernlund at infinera dot com
2021-06-03 19:32 ` segher at gcc dot gnu.org
2021-12-03 19:44 ` roger at nextmovesoftware dot com
2023-06-06 20:14 ` jakub at gcc dot gnu.org
2023-08-29 16:41 ` bergner at gcc dot gnu.org
2023-08-29 17:43 ` roger at nextmovesoftware dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100527013716.31124.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).