[Bug libstdc++/44417] New: make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[Bug libstdc++/44417] New: make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at kit dot edu]

make check-target-libstdc++-v3 fails because ptrdiff_t is undefined.
std::ptrdiff_t works.
Maybe this bug is related to the Linux system run on.  I have openSuse 11.1
running.

configure --enable-languages=c,c++ --program-suffix=-rep
--prefix=$HOME/gcc/install_trunk_1


In file included from
/home/singler/gcc/trunk_1/libstdc++-v3/testsuite/util/testsuite_abi.h:27:0,
                 from
/home/singler/gcc/trunk_1/libstdc++-v3/testsuite/util/testsuite_abi.cc:23:
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:371:5: error:
'ptrdiff_t' does not name a type
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:447:23: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:459:18: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:469:26: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:495:18: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:501:26: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:540:18: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:546:26: error:
'ptrdiff_t' has not been declared
/home/singler/gcc/trunk_1/libstdc++-v3/libsupc++/cxxabi.h:566:4: error:
'ptrdiff_t' has not been declared
compiler exited with status 1

Any ideas and/or a workaround?


-- 
           Summary: make check-target-libstdc++-v3 fails due to undefined
                    ptrdiff_t
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: singler at kit dot edu
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #1 from paolo dot carlini at oracle dot com  2010-06-04 13:49 -------
I can't reproduce this. I booted and tested many times on various linux systems
and HJ already reported many succesfull testresults since. Please remove
everything from the build dir, gave everything fresh and retry.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at kit dot edu]

------- Comment #2 from singler at kit dot edu  2010-06-04 14:16 -------
I had cleaned the builddir already.
Adding 

#include <cstddef> 

solves the problem. 
The crucial file seems to be

lib/gcc/x86_64-unknown-linux-gnu/4.6.0/include/stddef.h

Only if it is (indirectly) included, ptrdiff_t is defined in the global scope. 
Maybe on other systems, ptrdiff_t is also declared somewhere else, so the
problem does not appear.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at kit dot edu]

------- Comment #3 from singler at kit dot edu  2010-06-04 14:19 -------
*** Bug 44416 has been marked as a duplicate of this bug. ***


-- 

singler at kit dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl dot tools at gmail dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #4 from paolo dot carlini at oracle dot com  2010-06-04 14:23 -------
To be clear: does a normal 'make check' (either from the root of the build dir
or from inside the library build dir) work? Because it works here and fo
everybody else on the testresult mailing list, also for people using your exact
same linux.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #5 from paolo dot carlini at oracle dot com  2010-06-04 14:28 -------
Hey, 44416 is *not* a duplicate! Please re-open it immediately.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #6 from paolo dot carlini at oracle dot com  2010-06-04 14:52 -------
Note that cxxabi.h already includes <stddef.h> and at that line 371 uses
ptrdiff_t unqualified, thus everything is fine. I suspect you simply forgot to
update your compiler, because the current library does not work without a
recent front end fix applied by Jason.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #7 from paolo dot carlini at oracle dot com  2010-06-04 14:55 -------
Closing.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at gcc dot gnu dot org]

------- Comment #8 from singler at gcc dot gnu dot org  2010-06-04 18:51 -------
I can't help it, "make check" in the libstdc++-v3 directory still does not work
for me, even after reconfiguring and recompiling everything from scratch, using
vanilla rev 160275.
Let's have a look at attached testsuite_abi.ii.
The first typedef for std::ptrdiff_t is in line 49, but the first typedef for
ptrdiff_t in the global scope is only in line 30203.
The first error is in line 24823, however, this is in (sub?) namespace
__cxxabiv1.
Should this work anyway?
I'm quite lost.


-- 

singler at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WORKSFORME                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at gcc dot gnu dot org]

------- Comment #9 from singler at gcc dot gnu dot org  2010-06-04 18:51 -------
Created an attachment (id=20845)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20845&action=view)
Failing test case.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #10 from paolo dot carlini at oracle dot com  2010-06-04 18:55 -------
Something is broken in your system, I also tested on an Open Suse 11.1, to be
sure, and everything works fine. Remove everything, fetch again the entire gcc
mainline and try again.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[singler at kit dot edu]

------- Comment #11 from singler at kit dot edu  2010-06-07 09:35 -------
Obviously, I'm not the only one having this problem, Jason has patched
libstdc++-v3/testsuite/util/testsuite_abi.h in the meantime.

------------------------------------------------------------------------
r160313 | jason | 2010-06-05 15:13:46 +0200 (Sat, 05 Jun 2010) | 1 line

        * testsuite/util/testsuite_abi.h: Work around glibc BZ 9694.

+// Include stddef now to work around glibc BZ 9694
+#include <stddef.h>

related to

<http://sourceware.org/bugzilla/show_bug.cgi?id=9694>

This solves the problem testsuite_abi.h, but then, the next test fails, namely
testsuite_allocator.h.

I have tested all that using a different user ID, with a completely clean
environment and new checkout, but the problem persists.


-- 

singler at kit dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at redhat dot com
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WORKSFORME                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #12 from paolo dot carlini at oracle dot com  2010-06-07 10:09 -------
Yes, it's a glibc bug (I don't have available any machine using that old
glibc), and if you look at the mailing list, I already commented that could be
related to your issue. I think we should use the same workaround for that other
testsuite header and closw this sucker. Any patch along these lines is
pre-approved, in any case I would not be able to test it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #13 from paolo dot carlini at oracle dot com  2010-06-07 10:18 -------
As a matter of fact, in testsuite_allocator.h the problem can be solved much
more cleanly by simply qualifying with std:: the size_t and ptrdiff_t in tge
second half of the file, I can do that later today. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |paolo dot carlini at oracle
                   |dot org                     |dot com
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-07 14:02:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #14 from paolo dot carlini at oracle dot com  2010-06-07 15:17 -------
Created an attachment (id=20855)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20855&action=view)
Tentative patch (only sanity checked on a system not affected by the glibc
issue)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #15 from paolo dot carlini at oracle dot com  2010-06-07 15:23 -------
Johannes, can you try the patch and in case, give me some details about the
remaining issues? The idea is simply that if a glibc header has been included
by <cwctype> before <wctype.h>, then __GLIBC__ is defined and __GLIBC_MINOR__
set to the proper value. If the minor is < 10, thus <wctype.h> is buggy, we
include by hand <stddef.h> *before* <wctype.h>. It should work. Unless the
library is somehow including <wctype.h> somewhere else outside <cwctype>. That
should be also fixed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #16 from paolo dot carlini at oracle dot com  2010-06-07 15:27 -------
Errata: "... by <cwctype> before <wctype.h>..." should read "... before
<cwctype> wants to include <wctype.h>..."


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo at gcc dot gnu dot org]

------- Comment #17 from paolo at gcc dot gnu dot org  2010-06-08 01:46 -------
Subject: Bug 44417

Author: paolo
Date: Tue Jun  8 01:46:10 2010
New Revision: 160417

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=160417
Log:
2010-06-07  Paolo Carlini  <paolo.carlini@oracle.com>

        PR libstdc++/44417
        * include/c_std/cwctype: Provide a workaround for bug glibc
        BZ 9694 affecting glibc 2.9 and older.
        * include/c_global/cwctype: Likewise.
        * testsuite/util/testsuite_abi.h: Remove temporary workaround.
        * testsuite/util/testsuite_allocator.h: Use everywhere std::size_t
        and std::ptrdiff_t, don't include <cstddef>.

        * testsuite/27_io/basic_ostream/inserters_other/wchar_t/
        error_code.cc: Minor tweak, prefer <cwchar> to <wchar.h>.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/c_global/cwctype
    trunk/libstdc++-v3/include/c_std/cwctype
   
trunk/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_other/wchar_t/error_code.cc
    trunk/libstdc++-v3/testsuite/util/testsuite_abi.h
    trunk/libstdc++-v3/testsuite/util/testsuite_allocator.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #18 from paolo dot carlini at oracle dot com  2010-06-08 01:49 -------
Fixed.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417

[Bug libstdc++/44417] make check-target-libstdc++-v3 fails due to undefined ptrdiff_t

[paolo dot carlini at oracle dot com]

------- Comment #19 from paolo dot carlini at oracle dot com  2010-06-08 01:49 -------
Yes.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44417