[Bug c/44435] New: gengtype: don't test undefined value after vasprintf failure

[Bug c/44435] New: gengtype: don't test undefined value after vasprintf failure

[jim at meyering dot net]

Harmless, but distracting...
This is present is the latest sources on trunk.

gengtype: don't test undefined value after vasprintf failure
While libiberty's asprintf function does guarantee that the pointer is
set to NULL upon asprintf failure, POSIX/glibc make no such guarantee.
* gengtype.c (xasprintf): Don't test an undefined value upon
vasprintf failure.
* gengtype.c (oprintf): Likewise.

Patch attached.


-- 
           Summary: gengtype: don't test undefined value after vasprintf
                    failure
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jim at meyering dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435

[Bug c/44435] gengtype: don't test undefined value after vasprintf failure

[jim at meyering dot net]

------- Comment #1 from jim at meyering dot net  2010-06-06 13:41 -------
Created an attachment (id=20851)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20851&action=view)
gengtype: don't test undefined value after vasprintf failure


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435

[Bug other/44435] gengtype: don't test undefined value after vasprintf failure

[jsm28 at gcc dot gnu dot org]

------- Comment #2 from jsm28 at gcc dot gnu dot org  2010-06-06 15:53 -------
If the libiberty maintainers won't review the xvasprintf patch, perhaps
a global reviewer could do so?  That would be better than fiddling with
local checks.

http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01448.html
http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01449.html


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |other


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435

[Bug other/44435] gengtype: don't test undefined value after vasprintf failure

[dj at redhat dot com]

------- Comment #3 from dj at redhat dot com  2010-06-07 18:14 -------
Subject: Re:  gengtype: don't test undefined value after vasprintf failure


> If the libiberty maintainers won't review the xvasprintf patch,

I did: http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00589.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435

[Bug other/44435] gengtype: don't test undefined value after vasprintf failure

[jim at meyering dot net]

------- Comment #4 from jim at meyering dot net  2010-06-07 18:24 -------
Good!  I see that there's already a patch to deal with all of the unchecked
asprintf calls, too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435

[Bug other/44435] gengtype: don't test undefined value after vasprintf failure

[joseph at codesourcery dot com]

------- Comment #5 from joseph at codesourcery dot com  2010-06-07 20:17 -------
Subject: Re:  gengtype: don't test undefined value after
 vasprintf failure

On Mon, 7 Jun 2010, dj at redhat dot com wrote:

> > If the libiberty maintainers won't review the xvasprintf patch,
> 
> I did: http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00589.html

That's a review of an older version.  The URLs I gave were of a version a 
different person updated to take account of your original review comments.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44435