public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "manu at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug preprocessor/7263] __extension__ keyword doesn't suppress warning on LL or ULL constants Date: Wed, 09 Jun 2010 17:57:00 -0000 [thread overview] Message-ID: <20100609175724.839.qmail@sourceware.org> (raw) In-Reply-To: <bug-7263-1664@http.gcc.gnu.org/bugzilla/> ------- Comment #30 from manu at gcc dot gnu dot org 2010-06-09 17:57 ------- (In reply to comment #29) > Created an attachment (id=20878) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20878&action=view) [edit] > Refreshed version. Fully Bootstraps the C FE and passes regression tests. > > This fixes a annoying bug that were making the compiler emit wrong debug info, > leading to binaries that were not really debug-able. > > Next stop is to disable this feature by default, and enable it with a > -ftrack-macro-expansion flag, and update the regressions tests of the C FE. Great but... you should just prune the output in the general case (extending prune.exp) and only bother to handle the extra output in cases where it makes sense to specifically test it. This is what we do for the "inlined from" messages and it makes sense to do the same for this kind of message. I see now the sense in the column numbers, I think it is the order that confused me (and not seeing the code clearly). I would prefer a different output like: test.c:13:3: in expansion of macro MULT2 test.c:5:14: in expansion of macro SHIFTL test.c:8:3: in expansion of macro OPERATE test.c:2:8: error: invalid operands to binary << (have 'double' and 'int') But this is bike-shedding at this stage and it is more important to get the internals working. BTW, do we also keep the information about the macro arguments? If so, after your patch goes in we could even go as far as to print macro arguments: test.c:13:3: in expansion of macro MULT2 [with A=1.0] test.c:5:14: in expansion of macro SHIFTL [with A=1.0, B=1] test.c:8:3: in expansion of macro OPERATE [with OPRD1=1.0, OPTR=<<, OPTRD2=1] test.c:2:8: error: invalid operands to binary << (have 'double' and 'int') Ok, ok. let's get back to reality ;-) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7263
next prev parent reply other threads:[~2010-06-09 17:57 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-7263-1664@http.gcc.gnu.org/bugzilla/> 2008-04-22 15:27 ` tromey at gcc dot gnu dot org 2008-08-10 19:26 ` manu at gcc dot gnu dot org 2008-08-10 22:18 ` tromey at gcc dot gnu dot org 2008-08-10 23:15 ` manu at gcc dot gnu dot org 2008-08-11 2:20 ` tromey at gcc dot gnu dot org 2008-08-18 11:33 ` manu at gcc dot gnu dot org 2008-08-18 13:57 ` manu at gcc dot gnu dot org 2008-08-19 19:29 ` tromey at gcc dot gnu dot org 2008-08-19 19:51 ` manu at gcc dot gnu dot org 2010-03-22 18:21 ` tromey at gcc dot gnu dot org 2010-03-23 13:06 ` manu at gcc dot gnu dot org 2010-03-23 15:19 ` tromey at gcc dot gnu dot org 2010-03-30 14:06 ` dodji at gcc dot gnu dot org 2010-05-28 15:34 ` dodji at gcc dot gnu dot org 2010-05-28 15:42 ` dodji at gcc dot gnu dot org 2010-06-04 19:37 ` dodji at gcc dot gnu dot org 2010-06-04 20:22 ` manu at gcc dot gnu dot org 2010-06-09 14:23 ` Dodji Seketeli 2010-06-09 14:32 ` Dodji Seketeli 2010-06-09 14:23 ` dodji at redhat dot com 2010-06-09 14:32 ` dodji at redhat dot com 2010-06-09 17:09 ` dodji at gcc dot gnu dot org 2010-06-09 17:57 ` manu at gcc dot gnu dot org [this message] 2010-06-14 14:13 ` dodji at redhat dot com 2010-06-14 14:21 ` dodji at gcc dot gnu dot org 2010-07-02 19:00 ` dodji at gcc dot gnu dot org [not found] <bug-7263-4@http.gcc.gnu.org/bugzilla/> 2010-11-26 0:15 ` dodji at gcc dot gnu.org 2010-11-26 0:30 ` dodji at gcc dot gnu.org 2010-11-26 0:52 ` manu at gcc dot gnu.org 2010-11-26 15:20 ` dodji at gcc dot gnu.org 2010-11-26 21:19 ` dodji at gcc dot gnu.org 2011-07-27 18:13 ` dodji at gcc dot gnu.org 2011-10-17 10:03 ` dodji at gcc dot gnu.org 2011-10-17 10:27 ` dodji at gcc dot gnu.org 2012-05-16 11:06 ` dodji at gcc dot gnu.org 2012-05-16 13:08 ` dodji at gcc dot gnu.org 2023-01-24 19:55 ` pinskia at gcc dot gnu.org [not found] <20020710082600.7263.andrew@andypo.net> 2004-07-19 1:38 ` pinskia at gcc dot gnu dot org 2004-10-07 12:16 ` pinskia at gcc dot gnu dot org 2005-02-09 2:51 ` neroden at gcc dot gnu dot org 2005-02-09 6:15 ` joseph at codesourcery dot com 2005-04-06 11:16 ` jsm28 at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100609175724.839.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).