[Bug preprocessor/44652] New: Column numbers in error messages are wrong

[Bug preprocessor/44652] New: Column numbers in error messages are wrong

[hariharans at picochip dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

If i compile the attached args.c, i get the following errror message in
mainline GCC.

In file included from args.c:2:0:
structdef.h:5:3: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before
‘unsigned’

Note that it says args.c:2:0. We used to use GCC 4.3.2, which used to only say
args.c:2. The extra ":0", which is supposed to represent column number, is just
wrong. In the attached test, the actual column number is "3". I am happy for
the compiler to not give any column number, but giving the wrong column number
looks wrong.

I saw this in picochip code, but i am guessing this is not specific to
picochip. Please let me know if you need any more information. Thanks


-- 
           Summary: Column numbers in error messages are wrong
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hariharans at picochip dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: picochip-unknown-none


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

[Bug preprocessor/44652] Column numbers in error messages are wrong

[hariharans at picochip dot com]

------- Comment #1 from hariharans at picochip dot com  2010-06-24 08:30 -------
Created an attachment (id=20991)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20991&action=view)
c file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

[Bug preprocessor/44652] Column numbers in error messages are wrong

[hariharans at picochip dot com]

------- Comment #2 from hariharans at picochip dot com  2010-06-24 08:30 -------
Created an attachment (id=20992)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20992&action=view)
struct definition header file


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

[Bug preprocessor/44652] Column numbers in error messages are wrong

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2010-06-24 08:34 -------
I think column 0 is correct for the start of all preprocessor directives.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

[Bug preprocessor/44652] Column numbers in error messages are wrong

[manu at gcc dot gnu dot org]

------- Comment #4 from manu at gcc dot gnu dot org  2010-06-24 12:03 -------
(In reply to comment #3)
> I think column 0 is correct for the start of all preprocessor directives.

But the #include does not start at column 0, so there is something wrong there.
We know that libcpp column information sucks in many places. Tom and I have
several patches but we never got around to finish them.

To not get column info just use -fno-show-column


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-24 12:03:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

[Bug preprocessor/44652] Column numbers in error messages are wrong

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |7.5.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So we don't display the column any more:
In file included from t.c:2:
structdef.h:5:3: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before
‘unsigned’
    5 |   unsigned int b:5;
      |   ^~~~~~~~


Let me figure out when it happened.

[Bug preprocessor/44652] Column numbers in error messages are wrong

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
We removed the column of 0 by r11-2092.

[Bug preprocessor/44652] Column numbers in error messages are wrong

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
              where = linemap_included_from (map);
              map = linemap_included_from_linemap (line_table, map);
              bool is_module = MAP_MODULE_P (map);
              s.file = LINEMAP_FILE (map);
              s.line = SOURCE_LINE (map, where);
              int col = -1;
              if (first && context->show_column)
                {
                  s.column = SOURCE_COLUMN (map, where);
                  col = diagnostic_converted_column (context, s);
                }

first is true so the column info must be missing from the preprocessor.