public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/44790] Bootstrap fails after MEM-REF merge Date: Sat, 03 Jul 2010 11:17:00 -0000 [thread overview] Message-ID: <20100703111735.26436.qmail@sourceware.org> (raw) In-Reply-To: <bug-44790-3107@http.gcc.gnu.org/bugzilla/> ------- Comment #2 from rguenth at gcc dot gnu dot org 2010-07-03 11:17 ------- The code in question is likely expr.c:8830 ff: address_mode = targetm.addr_space.address_mode (as); op0 = expand_expr (TREE_OPERAND (exp, 0), NULL_RTX, address_mode, EXPAND_NORMAL); if (!integer_zerop (TREE_OPERAND (exp, 1))) { rtx off; off = immed_double_int_const (mem_ref_offset (exp), address_mode); op0 = simplify_gen_binary (PLUS, address_mode, op0, off); } op0 = memory_address_addr_space (mode, op0, as); temp = gen_rtx_MEM (mode, op0); I see that POINTER_PLUS_EXPR would end up doing ;; ap_2 = ap_1 + 8; (insn 10 9 11 t.i:8 (set (reg:SI 345) (plus:SI (subreg/s/v:SI (reg/v/f:DI 339 [ ap+-4 ]) 4) (const_int 8 [0x8]))) -1 (nil)) (insn 11 10 0 t.i:8 (set (reg/v/f:DI 340 [ ap+-4 ]) (unspec:DI [ (reg:SI 345) ] 24)) -1 (nil)) thus appearantly the pointer mode is DI but offsets are 32bit(?!) OTOH doing Index: expr.c =================================================================== --- expr.c (revision 161771) +++ expr.c (working copy) @@ -8817,14 +8817,12 @@ expand_expr_real_1 (tree exp, rtx target } } address_mode = targetm.addr_space.address_mode (as); - op0 = expand_expr (TREE_OPERAND (exp, 0), NULL_RTX, address_mode, - EXPAND_NORMAL); + base = TREE_OPERAND (exp, 0); if (!integer_zerop (TREE_OPERAND (exp, 1))) - { - rtx off; - off = immed_double_int_const (mem_ref_offset (exp), address_mode); - op0 = simplify_gen_binary (PLUS, address_mode, op0, off); - } + base = build2 (POINTER_PLUS_EXPR, TREE_TYPE (base), + base, double_int_to_tree (sizetype, + mem_ref_offset (exp))); + op0 = expand_expr (base, NULL_RTX, address_mode, EXPAND_SUM); op0 = memory_address_addr_space (mode, op0, as); temp = gen_rtx_MEM (mode, op0); set_mem_attributes (temp, exp, 0); generates (insn 13 12 14 t.i:8 (set (reg:DI 346) (reg/v/f:DI 339 [ ap+-4 ])) -1 (nil)) (insn 14 13 15 t.i:8 (set (reg/f:DI 347) (plus:DI (reg/v/f:DI 339 [ ap+-4 ]) (const_int 4 [0x4]))) -1 (nil)) (insn 15 14 16 t.i:9 (set (reg:SI 348) (mem:SI (reg/f:DI 347) [0 MEM[(long int *)ap_1 + 4B]+0 S4 A32])) -1 (nil)) which doesn't use an UNSPEC either. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44790
next prev parent reply other threads:[~2010-07-03 11:17 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-07-02 18:53 [Bug middle-end/44790] New: " sje at cup dot hp dot com 2010-07-02 19:49 ` [Bug middle-end/44790] " sje at cup dot hp dot com 2010-07-03 11:17 ` rguenth at gcc dot gnu dot org [this message] 2010-07-06 14:26 ` [Bug middle-end/44790] [4.6 Regression] " rguenth at gcc dot gnu dot org 2010-07-06 16:44 ` sje at cup dot hp dot com 2010-07-06 22:56 ` sje at cup dot hp dot com 2010-07-07 8:35 ` rguenther at suse dot de 2010-07-07 12:44 ` rguenth at gcc dot gnu dot org 2010-07-07 13:04 ` rguenth at gcc dot gnu dot org 2010-07-28 7:45 ` ebotcazou at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100703111735.26436.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).