[Bug libstdc++/44436] New: Associative containers lack emplace() and emplace_hint() methods.

[Bug libstdc++/44436] New: Associative containers lack emplace() and emplace_hint() methods.

[jack2 at cantab dot net]

C++0x associative containers should have emplace() and emplace_hint() methods,
but those in libstdc++ do not.


-- 
           Summary: Associative containers lack emplace() and emplace_hint()
                    methods.
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jack2 at cantab dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] Associative containers lack emplace() and emplace_hint() methods.

[paolo dot carlini at oracle dot com]

------- Comment #1 from paolo dot carlini at oracle dot com  2010-06-07 14:03 -------
Yes, we lack *tons* of other C++0x things.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo dot carlini at oracle dot com]

------- Comment #2 from paolo dot carlini at oracle dot com  2010-06-21 17:47 -------
Reopening


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |
            Summary|Associative containers lack |[C++0x] Implement insert(&&)
                   |emplace() and emplace_hint()|and emplace* in associative
                   |methods.                    |and unordered containers


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo dot carlini at oracle dot com]

------- Comment #3 from paolo dot carlini at oracle dot com  2010-06-21 17:48 -------
I'm working on these, maybe will be ready in time for 4.6.0.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |paolo dot carlini at oracle
                   |dot org                     |dot com
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-21 17:48:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[redi at gcc dot gnu dot org]

------- Comment #4 from redi at gcc dot gnu dot org  2010-07-08 14:20 -------
*** Bug 44872 has been marked as a duplicate of this bug. ***


-- 

redi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hyounes at google dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo dot carlini at oracle dot com]

------- Comment #5 from paolo dot carlini at oracle dot com  2010-07-08 14:28 -------
Just to clarify a bit: this wasn't an *oversight*. We had the *nasty* problem
in the Draft C++0x Standard with std::pair, which essentially made impossible
adding the emplace_* members to std::map, std::multimap, etc, without breaking
existing user code. Thus we waited on that, until things got clarified in this
whole area. Now it's actually possible to work on those facilities.

Anyway, much more generally: we are *not* claiming any sort of conformance to
non existing (yet) standards, we are still in experimental mode for C++0x.
Please be patient.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #13 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2010-11-10 19:08:54 UTC ---
Author: paolo
Date: Wed Nov 10 19:08:49 2010
New Revision: 166551

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166551
Log:
2010-11-10  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/44436 (partial)
    PR libstdc++/46148
        * include/bits/stl_tree.h (_Rb_tree<>::_M_insert_, _M_insert_lower,
    _M_insert_equal_lower, _M_insert_unique, _M_insert_equal,
    _M_insert_unique_, _M_insert_equal_): Templatize in C++0x mode,
    use _GLIBCXX_FORWARD throughout.
        * include/bits/stl_map.h (map<>::insert(_Pair&&),
    insert(const_iterator, _Pair&&), operator[](key_type&&): Add.
        * include/bits/stl_set.h (set<>::insert(value_type&&),
    insert(const_iterator, value_type&&)): Likewise.
        * include/bits/stl_multimap.h (multimap<>::insert(_Pair&&),
    insert(const_iterator, _Pair&&)): Likewise.
        * include/bits/stl_multiset.h (multiset<>::insert(value_type&&),
    insert(const_iterator, value_type&&)): Likewise.
    * include/debug/set.h: Adjust.
        * include/debug/multiset.h: Likewise.
        * include/debug/map.h: Likewise.
        * include/debug/multimap.h: Likewise.
        * include/profile/set.h: Likewise.
        * include/profile/multiset.h: Likewise.
        * include/profile/map.h: Likewise.
        * include/profile/multimap.h: Likewise.
        * testsuite/23_containers/multimap/modifiers/insert/1.cc: New.
        * testsuite/23_containers/multimap/modifiers/insert/2.cc: Likewise.
        * testsuite/23_containers/multimap/modifiers/insert/3.cc: Likewise.
        * testsuite/23_containers/multimap/modifiers/insert/4.cc: Likewise.
        * testsuite/23_containers/set/modifiers/insert/2.cc: Likewise.
        * testsuite/23_containers/set/modifiers/insert/3.cc: Likewise.
        * testsuite/23_containers/multiset/modifiers/insert/3.cc: Likewise.
        * testsuite/23_containers/multiset/modifiers/insert/4.cc: Likewise.
        * testsuite/23_containers/map/modifiers/insert/2.cc: Likewise.
        * testsuite/23_containers/map/modifiers/insert/3.cc: Likewise.
        * testsuite/23_containers/map/modifiers/insert/4.cc: Likewise.
        * testsuite/23_containers/map/modifiers/insert/5.cc: Likewise.
        * testsuite/23_containers/map/element_access/2.cc: Likewise.
        * testsuite/23_containers/map/element_access/46148.cc: Likewise.

        * include/bits/hashtable.h: Trivial naming changes.

Added:
    trunk/libstdc++-v3/testsuite/23_containers/map/element_access/2.cc
    trunk/libstdc++-v3/testsuite/23_containers/map/element_access/46148.cc
    trunk/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/2.cc
    trunk/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/3.cc
    trunk/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/4.cc
    trunk/libstdc++-v3/testsuite/23_containers/map/modifiers/insert/5.cc
    trunk/libstdc++-v3/testsuite/23_containers/multimap/modifiers/insert/1.cc
    trunk/libstdc++-v3/testsuite/23_containers/multimap/modifiers/insert/2.cc
    trunk/libstdc++-v3/testsuite/23_containers/multimap/modifiers/insert/3.cc
    trunk/libstdc++-v3/testsuite/23_containers/multimap/modifiers/insert/4.cc
    trunk/libstdc++-v3/testsuite/23_containers/multiset/modifiers/insert/3.cc
    trunk/libstdc++-v3/testsuite/23_containers/multiset/modifiers/insert/4.cc
    trunk/libstdc++-v3/testsuite/23_containers/set/modifiers/insert/2.cc
    trunk/libstdc++-v3/testsuite/23_containers/set/modifiers/insert/3.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/hashtable.h
    trunk/libstdc++-v3/include/bits/stl_map.h
    trunk/libstdc++-v3/include/bits/stl_multimap.h
    trunk/libstdc++-v3/include/bits/stl_multiset.h
    trunk/libstdc++-v3/include/bits/stl_set.h
    trunk/libstdc++-v3/include/bits/stl_tree.h
    trunk/libstdc++-v3/include/debug/map.h
    trunk/libstdc++-v3/include/debug/multimap.h
    trunk/libstdc++-v3/include/debug/multiset.h
    trunk/libstdc++-v3/include/debug/set.h
    trunk/libstdc++-v3/include/profile/map.h
    trunk/libstdc++-v3/include/profile/multimap.h
    trunk/libstdc++-v3/include/profile/multiset.h
    trunk/libstdc++-v3/include/profile/set.h

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #12 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2010-10-28 16:01:11 UTC ---
Author: paolo
Date: Thu Oct 28 16:01:05 2010
New Revision: 166030

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166030
Log:
2010-10-28  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/44436 (partial)
    * include/bits/hashtable.h (_Hashtable<>::insert(value_type&&),
    insert(_Pair&&), insert(const_iterator, value_type&&),
    insert(const_iterator, _Pair&&)): Add.
    (_M_allocate_node, _M_insert, _M_insert_bucket): Templatize.
    * include/bits/hashtable_policy.h (__detail::_Select1st): Add; use
    it throughout.
    (_Map_base<>::operator[](_Key&&)): Add.
    * include/bits/unordered_map.h: Use __detail::_Select1st throughout.
    * include/debug/unordered_map: Update.
    * include/debug/unordered_set: Likewise.
    * include/profile/unordered_map: Likewise.
    * include/profile/unordered_set: Likewise.
    * testsuite/util/testsuite_rvalref.h (struct hash<rvalstruct>): Add;
    minor tweaks throughout, use deleted special members.
    * testsuite/23_containers/unordered_map/insert/map_single_move-1.cc:
    New.
    * testsuite/23_containers/unordered_map/insert/map_single_move-2.cc:
    Likewise.
    * testsuite/23_containers/unordered_map/insert/array_syntax_move.cc:
    Likewise.
    * testsuite/23_containers/unordered_multimap/insert/
    multimap_single_move-1.cc: Likewise.
    * testsuite/23_containers/unordered_multimap/insert/
    multimap_single_move-2.cc: Likewise.
    * testsuite/23_containers/unordered_set/insert/set_single_move.cc:
    Likewise.
    * testsuite/23_containers/unordered_multiset/insert/
    multiset_single_move.cc: Likewise.

    * testsuite/23_containers/unordered_map/insert/array_syntax.cc:
    Minor cosmetic changes.

Added:
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/insert/array_syntax_move.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/insert/map_single_move-1.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/insert/map_single_move-2.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_multimap/insert/multimap_single_move-1.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_multimap/insert/multimap_single_move-2.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_multiset/insert/multiset_single_move.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_set/insert/set_single_move.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/hashtable.h
    trunk/libstdc++-v3/include/bits/hashtable_policy.h
    trunk/libstdc++-v3/include/bits/unordered_map.h
    trunk/libstdc++-v3/include/debug/unordered_map
    trunk/libstdc++-v3/include/debug/unordered_set
    trunk/libstdc++-v3/include/profile/unordered_map
    trunk/libstdc++-v3/include/profile/unordered_set
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/insert/array_syntax.cc
    trunk/libstdc++-v3/testsuite/util/testsuite_rvalref.h

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-26 12:39:59 UTC ---
doh, of course, we already use const_iterator in the unordered containers.
sorry!

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> 2010-10-26 12:31:28 UTC ---
I would say const_iterator, consistently with the existing insert and erase
overloads...

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-26 12:27:33 UTC ---
taking 'iterator' params for consistency, or 'const_iterator' because we don't
have to maintain compatibility?

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> 2010-10-26 12:17:06 UTC ---
First, I'm going to add the new insert overloads to the unordered containers.

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2010-10-23 16:01:45 UTC ---
And now we have n3178 too, great ;-/

[Bug libstdc++/44436] [C++0x] Implement insert(&&) and emplace* in associative and unordered containers

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44436

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tom.prince at ualberta dot
                   |                            |net

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-23 15:29:03 UTC ---
*** Bug 46148 has been marked as a duplicate of this bug. ***