[Bug lto/44889] New: Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[Bug lto/44889] New: Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[hubicka at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

jh@evans:/abuild/jh/mozilla-central/build8/layout/build>
/abuild/jh/trunk-install/bin/g++ ~/ns*.ii -O2 -fwhopr -r -nostdlib
In file included from ../../../js/src/xpconnect/src/xpcprivate.h:58:0,
                 from ../../../js/src/xpconnect/src/xpcmodule.h:41,
                 from ../../../layout/build/nsLayoutModule.cpp:43:
../../dist/include/jscntxt.h: In function ‘JSContext*
js_ContextFromLinkField(JSCList*)’:
../../dist/include/jscntxt.h:2704:75: warning: invalid access to non-static
data member ‘JSContext::link’  of NULL object [-Winvalid-offsetof]
../../dist/include/jscntxt.h:2704:75: warning: (perhaps the ‘offsetof’ macro
was used incorrectly) [-Winvalid-offsetof]
../../../toolkit/library/nsStaticXULComponents.cpp:286:1264: warning: type of
‘nsLayoutModule_NSModule’ does not match original declaration [enabled by
default]
../../../layout/build/nsLayoutModule.cpp:1221:37: note: previously declared
here


-- 
           Summary: Bogus "type of ‘nsLayoutModule_NSModule’ does not match
                    original declaration" waning compiling Mozilla
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hubicka at gcc dot gnu dot org
 GCC build triplet: x86_64-linux
  GCC host triplet: x86_64-linux
GCC target triplet: x86_64-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[hubicka at gcc dot gnu dot org]

------- Comment #1 from hubicka at gcc dot gnu dot org  2010-07-09 14:23 -------
Created an attachment (id=21158)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21158&action=view)
first part of testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[hubicka at gcc dot gnu dot org]

------- Comment #2 from hubicka at gcc dot gnu dot org  2010-07-09 14:23 -------
Created an attachment (id=21159)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21159&action=view)
second part of testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2010-07-09 14:42 -------
Pointed-to types mismatching.
Field types not compatible.
Pointed-to types mismatching.
Field types not compatible.
Pointed-to types mismatching.
Not compatible.
 <function_type 0x7ffff5164b28
    type <record_type 0x7ffff5164bd0 already_AddRefed needs-constructing DI
        size <integer_cst 0x7ffff7ed37d0 constant 64>

 <function_type 0x7ffff4aff5e8
    type <record_type 0x7ffff4aff690 already_AddRefed VOID
        align 8 symtab 0 alias set -1 structural equality>

for two different

 <pointer_type 0x7ffff5164a80 GetFactoryProcPtr

at

 <field_decl 0x7ffff5165098 getFactoryProc
 <field_decl 0x7ffff515fe40 mCIDs


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |lto
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-09 14:42:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2010-07-09 14:52 -------
Testcase:

t1.c
----
struct X;
struct Y {
    struct X (*fnptr)(void);
};
struct Y foo;

t2.c
----
struct X { int i; };
struct Y {
    struct X (*fnptr)(void);
};
extern struct Y foo;
int main()
{
  foo.fnptr();
  return 0;
}


I think we can fix that.  Thus, mine.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-07-09 14:42:37         |2010-07-09 14:52:13
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-07-09 15:20 -------
Created an attachment (id=21161)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21161&action=view)
patch

Patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2010-07-09 16:24 -------
Same issue for function args.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[hubicka at ucw dot cz]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 4561 bytes --]



------- Comment #7 from hubicka at ucw dot cz  2010-07-09 17:09 -------
Subject: Re:  =?iso-8859-2?Q?Bogus_?=
        =?iso-8859-2?Q?=22type_of_=91nsLayoutModule=5FNSModule=92_doe?=
        =?iso-8859-2?Q?s?= not match original declaration" waning compiling
        Mozilla

Hi,
with the patch all "does not match original declaration" on Mozilla build are
gone.  We are down to tons of
../../../../content/xbl/src/nsXBLBinding.cpp:1599:1: warning: Use of type
‘struct nsINodeInfo’ with two mismatching declarations at field
‘mOwnerManager’ [enabled by default]
../../../dist/include/nsINodeInfo.h:79:0: note: original type declared here
../../../dist/include/nsINodeInfo.h:329:0: note: field in mismatching type
declared here
../../../../content/xbl/src/nsXBLBinding.cpp:1599:1: warning: Use of type
‘struct nsNodeInfoManager’ with two mismatching declarations at field
‘mDocument’ [enabled by default]
../../../dist/include/nsNodeInfoManager.h:71:3: note: original type declared
here
../../../dist/include/nsNodeInfoManager.h:157:0: note: field in mismatching
type declared here
In function ‘GetBindingURL’:
../../dist/include/nsIDocument.h:444:38: warning: Use of type ‘struct
nsIDocument’ with two mismatching declarations at field ‘mPresShell’
[enabled by default]
../../dist/include/nsIDocument.h:138:0: note: original type declared here
../../dist/include/nsIDocument.h:1569:0: note: field in mismatching type
declared here
../../../dom/base/nsDOMClassInfo.cpp:10745:1: warning: Use of type ‘struct
nsPresContext’ with two mismatching declarations at field ‘mShell’
[enabled by default]
../../../dist/include/nsPresContext.h:175:0: note: original type declared here
../../dist/include/nsPresContext.h:1016:0: note: field in mismatching type
declared here
In member function ‘PreCreate’:
../../../dom/base/nsDOMClassInfo.cpp:10745:1: warning: Use of type ‘struct
nsNodeInfoManager’ with two mismatching declarations at field
‘mBindingManager’ [enabled by default]
../../../dist/include/nsNodeInfoManager.h:71:0: note: original type declared
here
../../dist/include/nsNodeInfoManager.h:165:0: note: field in mismatching type
declared here
In member function ‘Enumerate’:
../../../dom/base/nsDOMClassInfo.cpp:10745:1: warning: Use of type ‘struct
nsNodeInfoManager’ with two mismatching declarations at field
‘mBindingManager’ [enabled by default]
../../../dist/include/nsNodeInfoManager.h:71:0: note: original type declared
here
../../dist/include/nsNodeInfoManager.h:165:0: note: field in mismatching type
declared here
In member function ‘Init’:
../../../dom/base/nsJSTimeoutHandler.cpp:361:1: warning: Use of type ‘struct
nsINodeInfo’ with two mismatching declarations at field ‘mOwnerManager’
[enabled by default]
../../dist/include/nsINodeInfo.h:79:0: note: original type declared here
../../dist/include/nsINodeInfo.h:329:0: note: field in mismatching type
declared here
In member function ‘__base_ctor ’:
../../../content/smil/nsSMILAnimationController.cpp:77:21: warning: Use of type
‘struct nsSMILAnimationController’ with two mismatching declarations at
field ‘mDocument’ [enabled by default]
../../dist/include/nsSMILAnimationController.h:70:0: note: original type
declared here
../../../content/smil/nsSMILAnimationController.h:197:0: note: field in
mismatching type declared here
In member function ‘Init’:
../../../content/smil/nsSMILAnimationController.cpp:112:19: warning: Use of
type ‘struct nsSMILAnimationController’ with two mismatching declarations
at field ‘mDocument’ [enabled by default]
../../dist/include/nsSMILAnimationController.h:70:0: note: original type
declared here
../../../content/smil/nsSMILAnimationController.h:197:0: note: field in
mismatching type declared here
In function ‘GetContextForContent’:
../../../dist/include/nsIDocument.h:444:38: warning: Use of type ‘struct
nsIDocument’ with two mismatching declarations at field ‘mPresShell’
[enabled by default]
../../dist/include/nsIDocument.h:138:0: note: original type declared here
../../../dist/include/nsIDocument.h:1569:17: note: field in mismatching type
declared here
In member function ‘InvalidateSubtreeFor’:
../../../../accessible/src/base/nsAccessibilityService.cpp:1808

(and ICE I filled another PR for)

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2010-07-10 08:40 -------
Subject: Bug 44889

Author: rguenth
Date: Sat Jul 10 08:39:46 2010
New Revision: 162032

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162032
Log:
2010-07-10  Richard Guenther  <rguenther@suse.de>

        PR lto/44889
        * gimple.c (gimple_fixup_complete_and_incomplete_subtype_p): New
        helper function.
        (gimple_types_compatible_p): Similar to pointed-to
        types allow and merge a mix of complete and incomplete aggregate.
        Use gimple_fixup_complete_and_incomplete_subtype_p for that.
        (iterative_hash_gimple_type): Adjust for that.

        * gcc.dg/lto/20100709-1_0.c: New testcase.
        * gcc.dg/lto/20100709-1_1.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/lto/20100709-1_0.c
    trunk/gcc/testsuite/gcc.dg/lto/20100709-1_1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889

[Bug lto/44889] Bogus "type of ‘nsLayoutModule_NSModule’ does not match original declaration" waning compiling Mozilla

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2010-07-10 08:41 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44889