public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amylaar at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/44921] [4.6 Regression] Failed to bootstrap
Date: Mon, 12 Jul 2010 22:54:00 -0000 [thread overview]
Message-ID: <20100712225422.8975.qmail@sourceware.org> (raw)
In-Reply-To: <bug-44921-682@http.gcc.gnu.org/bugzilla/>
------- Comment #2 from amylaar at gcc dot gnu dot org 2010-07-12 22:54 -------
(In reply to comment #1)
> This patch:
>
> Index: postreload.c
> ===================================================================
> --- postreload.c (revision 162085)
> +++ postreload.c (working copy)
> @@ -1281,7 +1281,7 @@ move2add_use_add3_insn (rtx reg, rtx sym
> rtx src = SET_SRC (pat);
> int regno = REGNO (reg);
> int min_cost = INT_MAX;
> - int min_regno;
> + int min_regno = -1;
> bool speed = optimize_bb_for_speed_p (BLOCK_FOR_INSN (insn));
> int i;
>
> @@ -1317,7 +1317,7 @@ move2add_use_add3_insn (rtx reg, rtx sym
> }
> }
>
> - if (min_cost < rtx_cost (src, SET, speed))
> + if (min_regno >= 0 && min_cost < rtx_cost (src, SET, speed))
> {
> rtx tem;
>
> works for me.
The variable can not actually be used uninitalized, since min_cost is
initalized to INT_MAX, and the return type of rtx_cost is int.
So it is enough to shut up the compiler warning, no need to add an
extra test there. I.e. the first hunk should be sufficient.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44921
next prev parent reply other threads:[~2010-07-12 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 18:38 [Bug bootstrap/44921] New: " hjl dot tools at gmail dot com
2010-07-12 18:46 ` [Bug bootstrap/44921] " hjl dot tools at gmail dot com
2010-07-12 18:46 ` hjl dot tools at gmail dot com
2010-07-12 22:44 ` amylaar at gcc dot gnu dot org
2010-07-12 22:54 ` amylaar at gcc dot gnu dot org [this message]
2010-07-12 23:33 ` hjl dot tools at gmail dot com
2010-07-12 23:34 ` hjl dot tools at gmail dot com
2010-07-12 23:45 ` amylaar at gcc dot gnu dot org
2010-07-13 0:52 ` hjl at gcc dot gnu dot org
2010-07-13 9:51 ` jiez at gcc dot gnu dot org
2010-07-13 9:52 ` jiez at gcc dot gnu dot org
2010-07-13 16:20 ` jiez at gcc dot gnu dot org
2010-07-13 16:40 ` jiez at gcc dot gnu dot org
2010-07-23 12:37 ` rguenth at gcc dot gnu dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712225422.8975.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).