[Bug testsuite/42843] New: --enable-build-with-cxx plugin tests fail

[Bug testsuite/42843] New: --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

When configuring with --enable-build-with-cxx, most of the exported symbols
in cc1 / cc1plus etc end up with the c++ mangled name.
As the testsuite still compiles plugins with gcc to link against these
compiler binaries, the dso load fails with unresolved symbols:

[amylaar@laria bld-gcc-cxx19]$ grep FAIL check.out |grep plug
FAIL: g++.dg/plugin/attribute_plugin-test-1.C -fplugin=./attribute_plugin.so 
(test for warnings, line )
FAIL: g++.dg/plugin/attribute_plugin-test-1.C -fplugin=./attribute_plugin.so 
(test for warnings, line 7)
FAIL: g++.dg/plugin/attribute_plugin-test-1.C -fplugin=./attribute_plugin.so 
(test for warnings, line 7)
FAIL: g++.dg/plugin/attribute_plugin-test-1.C -fplugin=./attribute_plugin.so 
(test for warnings, line 16)
FAIL: g++.dg/plugin/attribute_plugin-test-1.C -fplugin=./attribute_plugin.so
(test for excess errors)
FAIL: g++.dg/plugin/pragma_plugin-test-1.C -fplugin=./pragma_plugin.so  (test
for warnings, line )
FAIL: g++.dg/plugin/pragma_plugin-test-1.C -fplugin=./pragma_plugin.so  (test
for warnings, line 5)
FAIL: g++.dg/plugin/pragma_plugin-test-1.C -fplugin=./pragma_plugin.so  (test
for warnings, line 9)
FAIL: g++.dg/plugin/pragma_plugin-test-1.C -fplugin=./pragma_plugin.so  (test
for warnings, line 14)
FAIL: g++.dg/plugin/pragma_plugin-test-1.C -fplugin=./pragma_plugin.so (test
for excess errors)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 10)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 13)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 26)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 27)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 33)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 34)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 40)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 41)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 42)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 43)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 44)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 46)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so  (test for
warnings, line 47)
FAIL: g++.dg/plugin/self-assign-test-1.C -fplugin=./selfassign.so (test for
excess errors)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 10)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 13)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 26)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 27)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 33)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 34)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 40)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 41)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 42)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 46)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so  (test for
warnings, line 47)
FAIL: g++.dg/plugin/self-assign-test-2.C -fplugin=./selfassign.so (test for
excess errors)
FAIL: g++.dg/plugin/self-assign-test-3.C -fplugin=./selfassign.so (test for
excess errors)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 10)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 14)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 18)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 19)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 24)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 50)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 50)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so  (test for
warnings, line 50)
FAIL: g++.dg/plugin/dumb-plugin-test-1.C -fplugin=./dumb_plugin.so (test for
excess errors)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so  (test for
warnings, line 15)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so  (test for
warnings, line 19)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so  (test for
warnings, line 20)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so  (test for
warnings, line 21)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so  (test for
warnings, line 22)
FAIL: gcc.dg/plugin/self-assign-test-1.c -fplugin=./selfassign.so (test for
excess errors)
FAIL: gcc.dg/plugin/self-assign-test-2.c -fplugin=./selfassign.so (test for
excess errors)
FAIL: gcc.dg/plugin/ggcplug-test-1.c -fplugin=./ggcplug.so (test for excess
errors)
FAIL: gcc.dg/plugin/one_time-test-1.c -fplugin=./one_time_plugin.so (test for
excess errors)
FAIL: gcc.dg/plugin/start_unit-test-1.c -fplugin=./start_unit_plugin.so (test
for excess errors)
FAIL: gcc.dg/plugin/finish_unit-test-1.c -fplugin=./finish_unit_plugin.so (test
for excess errors)

When -enable-build-with-cxx is in effect, the testsuite should use g++
to compile GCC plugins.


-- 
           Summary: --enable-build-with-cxx plugin tests fail
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: amylaar at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #1 from amylaar at gcc dot gnu dot org  2010-01-23 00:00 -------
A patch is here:
http://gcc.gnu.org/ml/gcc-patches/2010-01/msg01200.html


-- 

amylaar at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #2 from amylaar at gcc dot gnu dot org  2010-01-30 05:20 -------
Subject: Bug 42843

Author: amylaar
Date: Sat Jan 30 05:20:40 2010
New Revision: 156380

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=156380
Log:
gcc:
        PR testsuite/42843
        * Makefile.in (HOST_PLUGIN_CC): Define.
        (site.exp): Set HOST_PLUGIN_CC.
gcc/testsuite:
        PR testsuite/42843
        * lib/plugin-support.exp: Use $HOST_PLUGIN_CC.
        * gcc.dg/plugin/selfassign.c (pass_warn_self_assign): Use enumerator
        TV_NONE to initialize tv_id field.
        * g++.dg/plugin/selfassign.c (pass_warn_self_assign): Likewise.
        * gcc.dg/plugin/one_time_plugin.c (one_pass): Likewise.
        * g++.dg/plugin/dumb_plugin.c (pass_dumb_plugin_example): Likewise.
        Include toplev.h .
        * gcc.dg/plugin/finish_unit_plugin.c: Include cgraph.h.
        * g++.dg/plugin/attribute_plugin.c: Include toplev.h and plugin.h .
        * g++.dg/plugin/pragma_plugin.c: Include toplev.h .

Modified:
    branches/milepost-20100130-branch/gcc/ChangeLog
    branches/milepost-20100130-branch/gcc/Makefile.in
    branches/milepost-20100130-branch/gcc/testsuite/ChangeLog
   
branches/milepost-20100130-branch/gcc/testsuite/g++.dg/plugin/attribute_plugin.c
    branches/milepost-20100130-branch/gcc/testsuite/g++.dg/plugin/dumb_plugin.c
   
branches/milepost-20100130-branch/gcc/testsuite/g++.dg/plugin/pragma_plugin.c
    branches/milepost-20100130-branch/gcc/testsuite/g++.dg/plugin/selfassign.c
   
branches/milepost-20100130-branch/gcc/testsuite/gcc.dg/plugin/finish_unit_plugin.c
   
branches/milepost-20100130-branch/gcc/testsuite/gcc.dg/plugin/one_time_plugin.c
    branches/milepost-20100130-branch/gcc/testsuite/gcc.dg/plugin/selfassign.c
    branches/milepost-20100130-branch/gcc/testsuite/lib/plugin-support.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #3 from amylaar at gcc dot gnu dot org  2010-06-08 20:52 -------
(In reply to comment #1)
> A patch is here:
> http://gcc.gnu.org/ml/gcc-patches/2010-01/msg01200.html

This is an update of the patch to revision 160389:
http://gcc.gnu.org/ml/gcc-patches/2010-06/msg00822.html


-- 

amylaar at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.5.0 4.6.0
   Last reconfirmed|0000-00-00 00:00:00         |2010-06-08 20:52:24
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #4 from amylaar at gcc dot gnu dot org  2010-06-09 10:40 -------
Subject: Bug 42843

Author: amylaar
Date: Wed Jun  9 10:40:28 2010
New Revision: 160461

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=160461
Log:
gcc:
        PR testsuite/42843
        * gcc-plugin.h (int plugin_is_GPL_compatible): Declare as extern "C".
        * doc/plugins.texi (Plugin license check): Update information
        on type of plugin_is_GPL_compatible.
        * Makefile.in (PLUGINCC): Define as $(COMPILER).
        (PLUGINCFLAGS): Define as $(COMPILER_FLAGS).
gcc/testsuite:
        PR testsuite/42843
        * gcc.dg/plugin/selfassign.c (pass_warn_self_assign): Use enumerator
        TV_NONE to initialize tv_id field.
        * g++.dg/plugin/selfassign.c (pass_warn_self_assign): Likewise.
        * gcc.dg/plugin/one_time_plugin.c (one_pass): Likewise.
        * g++.dg/plugin/dumb_plugin.c (pass_dumb_plugin_example): Likewise.
        Include toplev.h .
        * gcc.dg/plugin/finish_unit_plugin.c: Include cgraph.h.
        * g++.dg/plugin/attribute_plugin.c: Include toplev.h and plugin.h .
        * g++.dg/plugin/pragma_plugin.c: Include toplev.h .

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/doc/plugins.texi
    trunk/gcc/gcc-plugin.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/plugin/attribute_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/dumb_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/pragma_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/selfassign.c
    trunk/gcc/testsuite/gcc.dg/plugin/finish_unit_plugin.c
    trunk/gcc/testsuite/gcc.dg/plugin/one_time_plugin.c
    trunk/gcc/testsuite/gcc.dg/plugin/selfassign.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #5 from amylaar at gcc dot gnu dot org  2010-06-09 10:49 -------
Fixed in trunk by revision 160461.


-- 

amylaar at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to fail|4.5.0 4.6.0                 |4.5.0
      Known to work|                            |4.6.0
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[howarth at nitro dot med dot uc dot edu]

------- Comment #6 from howarth at nitro dot med dot uc dot edu  2010-07-10 21:44 -------
This still looks broken. Under a normal bootstrap, on x86_64-apple-darwin10,
these new testcases are silently executed against the system compiler rather
than the newly built compiler...

Executing on build: gcc -g -O2
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100709/gcc/testsuite/g++.dg/plugin/attribute_plugin.c
-I. -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100709/gcc/testsuite
-I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100709/gcc/testsuite/../../gcc
-I/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/g++/../../../gcc

-I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100709/gcc/testsuite/../../include
-I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100709/gcc/testsuite/../../libcpp/include
 -I/sw/include -I/sw/include   -DIN_GCC -fPIC -shared -undefined dynamic_lookup
-o attribute_plugin.so    (timeout = 300)

When using a --enable-build-with-cxx bootstrap on x86_64-apple-darwin10, this
exposed with actual testcase failures...

Executing on build: g++ -g -O2
/Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c -I.
-I/Users/howarth/gcc/gcc/testsuite -I/Users/howarth/gcc/gcc/testsuite/../../gcc
-I/Users/howarth/work/gcc/testsuite/g++/../../../gcc 
-I/Users/howarth/gcc/gcc/testsuite/../../include
-I/Users/howarth/gcc/gcc/testsuite/../../libcpp/include  -I/sw/include
-I/sw/include   -DIN_GCC -fPIC -shared -undefined dynamic_lookup -o
attribute_plugin.so    (timeout = 300)
/Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c: In function
'void register_attributes(void*, void*)':^M
/Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c:35: error:
'warning' was not declared in this scope^M
/Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c: In function
'void handle_pre_generic(void*, void*)':^M
/Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c:55: error:
'warning' was not declared in this scope^M


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #7 from amylaar at gcc dot gnu dot org  2010-07-11 01:58 -------
(In reply to comment #6)
> This still looks broken. Under a normal bootstrap, on x86_64-apple-darwin10,
> these new testcases are silently executed against the system compiler rather
> than the newly built compiler...

I see.  We really should be using the same BUILD->HOST compiler that was
used to build the last stage of the build.  In the case of a native
bootstrap (assuming stage2/3 comparison succeeded), that should be
interchangeable with the newly built compiler. 

Feel free to re-open the PR; I have no plans to work on it, though.

> /Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c: In function
> 'void register_attributes(void*, void*)':^M
> /Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c:35: error:
> 'warning' was not declared in this scope^M
> /Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c: In function
> 'void handle_pre_generic(void*, void*)':^M
> /Users/howarth/gcc/gcc/testsuite/g++.dg/plugin/attribute_plugin.c:55: error:
> 'warning' was not declared in this scope^M

Looking at the source makes me wonder why it succeeds elsewhere.
It should be including diagnostic.h or disgnostic-core.h to get a
declaration for warning.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[howarth at nitro dot med dot uc dot edu]

------- Comment #8 from howarth at nitro dot med dot uc dot edu  2010-07-11 02:36 -------
Perhaps we just need something like...


Index: gcc/Makefile.in

===================================================================
--- gcc/Makefile.in     (revision 162051)
+++ gcc/Makefile.in     (working copy)
@@ -330,12 +330,15 @@
 LTO_BINARY_READER = @LTO_BINARY_READER@
 LTO_USE_LIBELF = @LTO_USE_LIBELF@

-# Compiler needed for plugin support
-PLUGINCC = $(COMPILER)
+# Compiler and flags needed for plugin support
+ifneq ($(ENABLE_BUILD_WITH_CXX),yes)
+PLUGINCC = $(CC)
+PLUGINCFLAGS = $(CFLAGS)
+else
+PLUGINCC = $(CXX)
+PLUGINCFLAGS = $(CXXFLAGS)
+endif

-# Flags needed for plugin support
-PLUGINCFLAGS = $(COMPILER_FLAGS)
-
 # Libs and linker options needed for plugin support
 PLUGINLIBS = @pluginlibs@



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #9 from amylaar at gcc dot gnu dot org  2010-07-11 04:22 -------
(In reply to comment #8)
> Perhaps we just need something like...

No, COMPILER uses CC, too.
The issue is the the toplevel Makefile check-gcc rule
forces CC in the gcc/Makefile via EXTRA_HOST_FLAGS

In the native boostrap case, you probably want
CC_FOR_TARGET / CFLAGS_FOR_TARGET / CXX_FOR_TARGET / CXXFLAGS_FOR_TARGET,
but you still need COMPILER COMPILER_FLAGS (or its equivalent) in the
case of non-bootstrap builds (native or otherwise).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #10 from iains at gcc dot gnu dot org  2010-07-12 12:54 -------
(In reply to comment #9)
> (In reply to comment #8)
> > Perhaps we just need something like...

> In the native boostrap case, you probably want
> CC_FOR_TARGET / CFLAGS_FOR_TARGET / CXX_FOR_TARGET / CXXFLAGS_FOR_TARGET,
> but you still need COMPILER COMPILER_FLAGS (or its equivalent) in the
> case of non-bootstrap builds (native or otherwise).

since the plugin is to run on the host, looking at the top level makefile
HOST_EXPORTS defines CC - so, as you say, the current settings in gcc/Makefile
are honoring that.  However, it's clear that CC is ending up set to the
bootstrap compiler and not the one built for stage2/3.  I wonder if that means
that HOST_EXPORTS needs to be re-written for each stage.. 

Is there any cross-tool known to support plugins? (I get no response for
cris-elf, s390x, mipsia64 and armel-linux-gnueabi).  No error, just silently
skips all plugin tests.

Or is there a requirement that the host compiler is >= some gcc version in that
case?


-- 

iains at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[howarth at nitro dot med dot uc dot edu]

------- Comment #11 from howarth at nitro dot med dot uc dot edu  2010-07-12 13:05 -------
I wonder if there is any overlap with this bug and PR29404/42308?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #12 from iains at gcc dot gnu dot org  2010-07-12 13:19 -------
(In reply to comment #10)

> Is there any cross-tool known to support plugins? (I get no response for
> cris-elf, s390x, mipsia64 and armel-linux-gnueabi).  No error, just silently
> skips all plugin tests.

hmm this is a configury/make issue (possibly darwin-specific), 
I suspect that the switch changes to deal with linker attributes are being
driven on target keys and not on host ones.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #13 from iains at gcc dot gnu dot org  2010-07-12 13:28 -------
(In reply to comment #12)
> (In reply to comment #10)
> 
> > Is there any cross-tool known to support plugins? (I get no response for
> > cris-elf, s390x, mipsia64 and armel-linux-gnueabi).  No error, just silently
> > skips all plugin tests.
> 
> hmm this is a configury/make issue (possibly darwin-specific), 
> I suspect that the switch changes to deal with linker attributes are being
> driven on target keys and not on host ones.

 nope, not that :

  case "${host}" in
    *-*-darwin*)
      CFLAGS=`echo $CFLAGS | sed s/-mdynamic-no-pic//g` <== a local change I
made for powerpc.
      CFLAGS="$CFLAGS -fPIC"
      LDFLAGS="$LDFLAGS -shared -undefined dynamic_lookup"
    ;;
    *)
      CFLAGS="$CFLAGS -fPIC"
      LDFLAGS="$LDFLAGS -fPIC -shared"
    ;;
  esac

I'll have to check the config.log more carefully.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #14 from iains at gcc dot gnu dot org  2010-07-12 15:00 -------
(In reply to comment #13)

> I'll have to check the config.log more carefully.

OK. possible a can of wiggly things here... 

  case "${host}" in
    *-*-darwin*)
      export_sym_check="$gcc_cv_nm -g"  <=== maybe these need to be $NM ....
    ;;
    *)
      export_sym_check="$gcc_cv_objdump -T"  <==== ... and $OBJDUMP in any
event, the correct host tool
    ;;
  esac

looks fine - until you find that gcc_cv_nm is being set to
 ../binutils/nm   == nm-for-target
when host==build (and we've built the tool).

AS_VAR_SET_IF(gcc_cv_nm,, [
if test -f $gcc_cv_binutils_srcdir/configure.in \
     && test -f ../binutils/Makefile \
     && test x$build = x$host; then
        gcc_cv_nm=../binutils/nm-new$build_exeext
elif test -x nm$build_exeext; then
        gcc_cv_nm=./nm$build_exeext
elif test -x $NM_FOR_TARGET; then
        gcc_cv_nm="$NM_FOR_TARGET"
else
        AC_PATH_PROG(gcc_cv_nm, $NM_FOR_TARGET)
fi])

I'm not sure what the right version of nm/objdump is  - but clearly, one for
the host not the target ...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #15 from amylaar at gcc dot gnu dot org  2010-07-12 22:25 -------
COMPILER is based on $(CC) / $(CXX), which during testing are overridden
to become the host compiler, i.e. stage 0 for a bootstrap, so to speak.
We want to use @CC@ / @CXX@ to use the same compiler that the latest compiler
binaries (cc1 etc.) were built with.


-- 

amylaar at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ro at gcc dot gnu dot org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #16 from amylaar at gcc dot gnu dot org  2010-07-12 22:40 -------
Created an attachment (id=21188)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21188&action=view)
proposed patch

This patch should restore the use of the previous stage compiler for plugins.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[ro at CeBiTec dot Uni-Bielefeld dot DE]

------- Comment #17 from ro at CeBiTec dot Uni-Bielefeld dot DE  2010-07-13 10:16 -------
Subject: Re:  --enable-build-with-cxx plugin tests fail

> This patch should restore the use of the previous stage compiler for plugins.

Indeed: with the exception of the $(ENABLE_BUILD_WITH_CXX) handling,
that's what I've been using already.

Thanks.
        Rainer


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[howarth at nitro dot med dot uc dot edu]

------- Comment #18 from howarth at nitro dot med dot uc dot edu  2010-07-13 13:06 -------
(In reply to comment #17)
> Subject: Re:  --enable-build-with-cxx plugin tests fail
> 
> > This patch should restore the use of the previous stage compiler for plugins.
> 
> Indeed: with the exception of the $(ENABLE_BUILD_WITH_CXX) handling,
> that's what I've been using already.
> 
> Thanks.
>         Rainer
> 

The only remaining oddity is the fact that only PLUGINCC/PLUGINCFLAGS are used
for 
the plugins testsuite in both gcc.dg and g++.dg. This means that for either
value of
ENABLE_BUILD_WITH_CXX at least one of those set of plugin testcases will be
compiled 
with the wrong compiler (ie gcc for g++.dg/plugin or g++ for gcc.dg/plugin)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[amylaar at gcc dot gnu dot org]

------- Comment #20 from amylaar at gcc dot gnu dot org  2010-07-14 20:23 -------
(In reply to comment #11)
> I wonder if there is any overlap with this bug and PR29404/42308?

libiberty doesn't use $(toplevel_builddir)/gcc/site.exp, so there is no
direct connection, but libiberty/Makefile.in also has CC = @CC@, where
$(CC) is not the same as @CC@ if the former is overridden by the toplevel
Makefile.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #21 from iains at gcc dot gnu dot org  2010-07-16 08:39 -------
Subject: Bug 42843

Author: iains
Date: Fri Jul 16 08:39:37 2010
New Revision: 162254

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162254
Log:

2010-07-16  Jack Howarth  <howarth@bromo.med.uc.edu>

        PR testsuite/42843
        * gcc.dg/plugin/selfassign.c: Include diagnostic.h.
        * gcc.dg/plugin/ggcplug.c: Likewise.
        * g++.dg/plugin/selfassign.c: Likewise.
        * g++.dg/plugin/attribute_plugin.c: Likewise.
        * g++.dg/plugin/dumb_plugin.c: Likewise.
        * g++.dg/plugin/pragma_plugin.c: Likewise.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/plugin/attribute_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/dumb_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/pragma_plugin.c
    trunk/gcc/testsuite/g++.dg/plugin/selfassign.c
    trunk/gcc/testsuite/gcc.dg/plugin/ggcplug.c
    trunk/gcc/testsuite/gcc.dg/plugin/selfassign.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[iains at gcc dot gnu dot org]

------- Comment #22 from iains at gcc dot gnu dot org  2010-07-17 07:20 -------
(In reply to comment #16)
> Created an attachment (id=21188)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21188&action=view) [edit]
> proposed patch
> 
> This patch should restore the use of the previous stage compiler for plugins.

This is working fine in respect of putting the bootstrap compiler in and, 
when --enable-build-with-cxx is given, the g++ plugins work on powerpc-darwin9.

When --enable-build-with-cxx is not given, several of them fail
(attribute_plugin-test-1, pragma_plugin-test-1, dumb-plugin-test-1).
This is because the compiler is ${objdir}/xgcc and the plugin names end ".c"
therefore they are built as standard "c".

If it is intended that plugins for g++ should be build-able as straight 'c',
then there is an issue the plugin examples.

otherwise, we need to arrange the the plugins get built by g++ when they are
intended to be used within it.
(this is not as simple as changing their filenames to end .C, since the
includes are defined in lib/plugin-support.exp and they don't include any
consideration of the possibility that c++ headers might be needed).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[ebotcazou at gcc dot gnu dot org]

------- Comment #23 from ebotcazou at gcc dot gnu dot org  2010-09-02 15:10 -------
This part:

        * Makefile.in (PLUGINCC): Define as $(COMPILER).
        (PLUGINCFLAGS): Define as $(COMPILER_FLAGS).

is wrong and broke again plugins testing with the C compiler on non-C99 native
platforms like Solaris 8 and 9.  The purpose of PLUGINCC is to have it
redefined for each compilation stage so that it will eventually be set to the
compiler used to compile the tested compiled; for the stage3 compiler, it
should be the stage2 compiler.  This is necessary because plugins testing uses
the auto-host.h file of the compiler used to compile the tested compiler, not
the auto-host.h file of the base compiler.  Setting it to a fixed value like
$(COMPILER_FLAGS) breaks the scheme because it's stuck to the base compiler.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
      Known to fail|4.5.0                       |4.5.0 4.6.0
      Known to work|4.6.0                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[ro at gcc dot gnu dot org]

------- Comment #24 from ro at gcc dot gnu dot org  2010-09-03 16:03 -------
Subject: Bug 42843

Author: ro
Date: Fri Sep  3 16:02:37 2010
New Revision: 163833

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163833
Log:
        PR testsuite/42843
        * Makefile.in (PLUGINCC): Define in terms of @CC@ / @CXX@
        (PLUGINCFLAGS): Define in terms of @CFLAGS@ / @CXXFLAGS@

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843

[Bug testsuite/42843] --enable-build-with-cxx plugin tests fail

[ebotcazou at gcc dot gnu dot org]

------- Comment #25 from ebotcazou at gcc dot gnu dot org  2010-09-18 08:53 -------
Tentatively.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ebotcazou at gcc dot gnu dot|
                   |org                         |
             Status|REOPENED                    |RESOLVED
      Known to fail|4.5.0 4.6.0                 |4.5.0
      Known to work|                            |4.6.0
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42843