[Bug libstdc++/44902] New: eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[Bug libstdc++/44902] New: eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[John dot Tytgat at aaug dot net]

gcc 4.6.0 20100709 trunk + newlib 1.18 HEAD (as cygnus build) configured as:

  configure --target=arm-unknown-eabi
--prefix=/home/joty/projects/gccsdk/riscos7/cross
--with-gmp=/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/installed-libs-for-cross-gcc
--with-mpfr=/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/installed-libs-for-cross-gcc
--with-mpc=/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/installed-libs-for-cross-gcc
--disable-threads --disable-multilib --disable-shared --with-newlib
--with-pkgversion=GCCSDK GCC 4.6trunk Release 1 Development
--with-bugurl=http://gccsdk.riscos.info/ --enable-maintainer-mode
--enable-interwork --disable-nls --enable-checking=no --enable-languages=c,c++

Compiled with: GNU C version 4.4.3, GMP version 5.0.1, MPFR version 3.0.0, MPC
version 0.8.2

results in:

libtool: compile: 
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/./gcc/xgcc
-shared-libgcc
-B/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/./gcc
-nostdinc++
-L/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3/src
-L/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3/src/.libs
-nostdinc
-B/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/newlib/
-isystem
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/newlib/targ-include
-isystem
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/newlib/libc/include
-B/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libgloss/arm
-L/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libgloss/libnosys
-L/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libgloss/arm
-B/home/joty/projects/gccsdk/riscos7/cross/arm-unknown-eabi/bin/
-B/home/joty/projects/gccsdk/riscos7/cross/arm-unknown-eabi/lib/ -isystem
/home/joty/projects/gccsdk/riscos7/cross/arm-unknown-eabi/include -isystem
/home/joty/projects/gccsdk/riscos7/cross/arm-unknown-eabi/sys-include
-I/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/../gcc
-I/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3/include/arm-unknown-eabi
-I/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3/include
-I/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++
-fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual -Werror
-fdiagnostics-show-location=once -ffunction-sections -fdata-sections -g -O2 -c
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/eh_arm.cc
-o eh_arm.o
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/eh_arm.cc:
In function '__cxxabiv1::__cxa_type_match_result
__cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)':
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/eh_arm.cc:42:23:
error: declaration of '__cxxabiv1::__cxa_type_match_result
__cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)'
with C language linkage [-Werror]
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/unwind-cxx.h:199:17:
error: conflicts with previous declaration 'bool
__cxxabiv1::__cxa_type_match(_Unwind_Control_Block*, const std::type_info*,
bool, void**)' [-Werror]
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/eh_arm.cc:
In function 'bool __cxa_begin_cleanup(_Unwind_Control_Block*)':
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/eh_arm.cc:96:49:
error: declaration of 'bool __cxa_begin_cleanup(_Unwind_Control_Block*)' with C
language linkage [-Werror]
/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/srcdir/gcc/libstdc++-v3/libsupc++/unwind-cxx.h:201:17:
error: conflicts with previous declaration 'void
__cxxabiv1::__cxa_begin_cleanup(_Unwind_Control_Block*)' [-Werror]
cc1plus: all warnings being treated as errors

make[6]: *** [eh_arm.lo] Error 1
make[6]: Leaving directory
`/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3/libsupc++'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory
`/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3'
make[4]: *** [all] Error 2
make[4]: Leaving directory
`/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc/arm-unknown-eabi/libstdc++-v3'
make[3]: *** [all-target-libstdc++-v3] Error 2
make[3]: Leaving directory
`/home/joty/projects/gccsdk/gccsdk_svn7/gcc4/builddir/cross-gcc'
make[2]: *** [all] Error 2


-- 
           Summary: eh_arm.cc:42:23: error: declaration of
                    '__cxxabiv1::__cxa_type_match_result
                    __cxa_type_match(_Unwind_Control_Block*, const
                    std::type_info*, bool, void**)' with C language linkage
                    [-Werror]
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: John dot Tytgat at aaug dot net
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: arm-unknown-eabi


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[paolo dot carlini at oracle dot com]

------- Comment #1 from paolo dot carlini at oracle dot com  2010-07-10 20:20 -------
ARM maintainers, could you please help me triaging this? Thanks.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |richard dot earnshaw at arm
                   |                            |dot com, nickc at redhat dot
                   |                            |com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[rearnsha at gcc dot gnu dot org]

------- Comment #2 from rearnsha at gcc dot gnu dot org  2010-07-12 17:45 -------
Looks to be a valid bug to me.  I suspect it's triggered by the
'--enable-maintainer-mode' flag causing -Werror to be used while building
libstdc++.

Paul, is this just a straight prototype problem in the header file?


-- 

rearnsha at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pbrook at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-12 17:45:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[John dot Tytgat at aaug dot net]

------- Comment #3 from John dot Tytgat at aaug dot net  2010-07-13 20:32 -------
I can confirm that it is because of the use of --enable-maintainer-mode we get
an error instead of a warning.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[mikpe at it dot uu dot se]

------- Comment #4 from mikpe at it dot uu dot se  2010-07-13 23:51 -------
Created an attachment (id=21195)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21195&action=view)
fix __cxa_type_match and __cxa_begin_cleanup prototypes

Looks like long-standing confusion about the return types of __cxa_type_match
and __cxa_begin_cleanup.  I see the warnings with 4.5 and 4.6, but strangely
enough not with 4.4 even though the same mismatch exists there.

Fixed by making the prototypes match the function definitions.  Tested so far
with a 4.6 cross to arm-linux-gnueabi.

There's also a mismatching extern declaration for __cxa_begin_cleanup in
libjava/exception.cc, but it seems harmless so I excluded the patch to correct
it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[John dot Tytgat at aaug dot net]

------- Comment #5 from John dot Tytgat at aaug dot net  2010-07-17 21:24 -------
Patch attachment 21195 fixes reported problem as well (4.6 cross with target
arm-unknown-eabi).  Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[paolo dot carlini at oracle dot com]

------- Comment #6 from paolo dot carlini at oracle dot com  2010-07-19 09:25 -------
Any comment from the ARM maintainers about Mikael' patch? Otherwise, I mean to
apply it and close the PR pretty soon...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[mikpe at it dot uu dot se]

------- Comment #7 from mikpe at it dot uu dot se  2010-07-19 09:48 -------
I had planned to include this patch in my native ARM bootstrap+regtest of the
next 4.6 weekly snapshot (4.6-20100717) and then submit it properly, but with
the bootstrap-breaking r162270 mess it slipped my mind.

If people are Ok with it w/o native testing, I'll gladly submit it right now or
have someone else apply it directly under the obvious rule.

Otherwise I'll do an incremental re-build and libstd++-only test run with it
once my current test cycle completes, and then submit it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[paolo dot carlini at oracle dot com]

------- Comment #8 from paolo dot carlini at oracle dot com  2010-07-19 10:15 -------
If you can svn update to a revision pre-breakage and natively test there it
would be great. But really, I just compared unwind-cxx.h to the actual
definitions in eh_arm.cc and the patch seems pretty straightforward to me, I
think we can safely go ahead for mainline. And well, if something is really
wrong we have plenty of time to correct ourselves.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[mikpe at it dot uu dot se]

------- Comment #9 from mikpe at it dot uu dot se  2010-07-20 08:48 -------
I just finished a native bootstrap and libstdc++-only regtest on
arm-linux-gnueabi with the proposed fix for PR44902.  The build-time warning is
gone, there were no test suite regressions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[rearnsha at gcc dot gnu dot org]

------- Comment #10 from rearnsha at gcc dot gnu dot org  2010-07-20 08:55 -------
The patch looks OK, but should really be posted to gcc-patches for approval.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[mikpe at it dot uu dot se]

------- Comment #11 from mikpe at it dot uu dot se  2010-07-20 09:37 -------
Patch posted:
http://gcc.gnu.org/ml/libstdc++/2010-07/msg00067.html
http://gcc.gnu.org/ml/gcc/2010-07/msg00293.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[paolo at gcc dot gnu dot org]

------- Comment #12 from paolo at gcc dot gnu dot org  2010-07-20 09:44 -------
Subject: Bug 44902

Author: paolo
Date: Tue Jul 20 09:44:01 2010
New Revision: 162328

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162328
Log:
2010-07-20  Paolo Carlini  <paolo.carlini@oracle.com>

        * libsupc++/unwind-cxx.h: Minor formatting / stylistic tweaks.

2010-07-20  Mikael Pettersson  <mikpe@it.uu.se>

        PR libstdc++/44902
        * libsupc++/unwind-cxx.h (__cxa_type_match): Correct prototype.
        (__cxa_begin_cleanup): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/libsupc++/unwind-cxx.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902

[Bug libstdc++/44902] eh_arm.cc:42:23: error: declaration of '__cxxabiv1::__cxa_type_match_result __cxa_type_match(_Unwind_Control_Block*, const std::type_info*, bool, void**)' with C language linkage [-Werror]

[paolo dot carlini at oracle dot com]

------- Comment #13 from paolo dot carlini at oracle dot com  2010-07-20 09:45 -------
Applied. PS: don't post patches to gcc@.


-- 

paolo dot carlini at oracle dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44902