[Bug fortran/44953] New: FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[Bug fortran/44953] New: FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[dominiq at lps dot ens dot fr]

gfortran.dg/char4_iunit_1.f03 fails on powerpc-apple-darwin9 (see

http://gcc.gnu.org/ml/gcc-testresults/2010-07/msg01445.html ). 

It looks like an endianess issue.


-- 
           Summary: FAIL: gfortran.dg/char4_iunit_1.f03  *  execution test
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: powerpc-apple-darwin9
  GCC host triplet: powerpc-apple-darwin9
GCC target triplet: powerpc-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2010-07-15 19:08 -------
You do have to make sure you do a clean build.  I noticed some dependency
issues while developing the patch.  I am not sure it was io.h or
write_float.def.  Regardless, check that first and I will touch base with you
on this in the next day or so.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2010-07-15 19:21 -------
>From http://gcc.gnu.org/regtest/HEAD/native-lastbuild.txt.gzip , I think the
failures on regress come after a clean bootstrap as well as my build for
r162194.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2010-07-15 19:35 -------
If I print the different strings, I get:


     abcdefg                               
 ?      12345                              
  78932       123456  abc                  
 ??????                                    
 ? 1.23450002E-06?  42846000000.000000     
 ?            NaN?      +Infinity          
           NaN   +Infinity                 
 ??  1.2000000    ?  3.4000001    ?        

a hexdump giving


00000000  20 20 20 20 20 61 62 63  64 65 66 67 20 20 20 20  |     abcdefg    |
00000010  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000020  20 20 20 20 20 20 20 20  20 20 20 0a 20 3f 20 20  |           . ?  |
00000030  20 20 20 20 31 32 33 34  35 20 20 20 20 20 20 20  |    12345       |
00000040  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
00000050  20 20 20 20 20 20 20 0a  20 20 37 38 39 33 32 20  |       .  78932 |
00000060  20 20 20 20 20 20 31 32  33 34 35 36 20 20 61 62  |      123456  ab|
00000070  63 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |c               |
00000080  20 20 20 0a 20 3f 3f 3f  3f 3f 3f 20 20 20 20 20  |   . ??????     |
00000090  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
000000a0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 0a  |               .|
000000b0  20 3f 20 31 2e 32 33 34  35 30 30 30 32 45 2d 30  | ? 1.23450002E-0|
000000c0  36 3f 20 20 34 32 38 34  36 30 30 30 30 30 30 2e  |6?  42846000000.|
000000d0  30 30 30 30 30 30 20 20  20 20 20 0a 20 3f 20 20  |000000     . ?  |
000000e0  20 20 20 20 20 20 20 20  20 20 4e 61 4e 3f 20 20  |          NaN?  |
000000f0  20 20 20 20 2b 49 6e 66  69 6e 69 74 79 20 20 20  |    +Infinity   |
00000100  20 20 20 20 20 20 20 0a  20 20 20 20 20 20 20 20  |       .        |
00000110  20 20 20 4e 61 4e 20 20  20 2b 49 6e 66 69 6e 69  |   NaN   +Infini|
00000120  74 79 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |ty              |
00000130  20 20 20 0a 20 3f 3f 20  20 31 2e 32 30 30 30 30  |   . ??  1.20000|
00000140  30 30 20 20 20 20 3f 20  20 33 2e 34 30 30 30 30  |00    ?  3.40000|
00000150  30 31 20 20 20 20 3f 20  20 20 20 20 20 20 20 0a  |01    ?        .|


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[danglin at gcc dot gnu dot org]

------- Comment #4 from danglin at gcc dot gnu dot org  2010-07-16 01:01 -------
Also in hppa64-hp-hpux11.11.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-16 01:01:51
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #5 from jvdelisle at gcc dot gnu dot org  2010-07-16 06:44 -------
I am attempting a build on a PPC machine to see if I can fix this.  I suspect I
am missing a few casts in the right places.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-07-16 01:01:51         |2010-07-16 06:44:07
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2010-07-16 07:31 -------
I am able to reproduce this on the PPC machine I have access to.  I think I see
the problem and will submit a patch in the next few days when I can squeeze in
some time.

Dominique, can you do me a favor and test the READ patch as well that I 
submitted to see if the issue is there as well.  I suspect it is.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[dominiq at lps dot ens dot fr]

------- Comment #7 from dominiq at lps dot ens dot fr  2010-07-16 09:03 -------
> Dominique, can you do me a favor and test the READ patch as well that I 
> submitted to see if the issue is there as well.  I suspect it is.

Yes!-(


FAIL: gfortran.dg/char4_iunit_1.f03  -O0  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O1  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O2  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O3 -fomit-frame-pointer
-funroll-all-loops -finline-functions  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -O3 -g  execution test
FAIL: gfortran.dg/char4_iunit_1.f03  -Os  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O0  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O1  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O2  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O3 -fomit-frame-pointer
-funroll-all-loops -finline-functions  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -O3 -g  execution test
FAIL: gfortran.dg/char4_iunit_2.f03  -Os  execution test

char4_iunit_2.f03 fails at the last test with 

widestring=  ?test?        345?  52.542999    ?0 hijklmnp qwertyuiopasd         


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #8 from jvdelisle at gcc dot gnu dot org  2010-07-18 21:07 -------
Created an attachment (id=21245)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21245&action=view)
Proposed Patch

Please test the attached patch.  This patch cleans up pointer use and adds a
few snippets I missed in the first implementations, namely in write_char and
write_separator.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[dominiq at lps dot ens dot fr]

------- Comment #9 from dominiq at lps dot ens dot fr  2010-07-18 21:59 -------
> Created an attachment (id=21245)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21245&action=view) [edit]
> Proposed Patch
>
> Please test the attached patch. 

make -k check-gfortran RUNTESTFLAGS="dg.exp=char4_iunit_*.f03
--target_board=unix'{-m32,-m64}'"
...
                === gfortran Summary ===

# of expected passes            64

So the patch fixes this PR. I have launched a full gfortran regtest to be sure,
but do not expect any surprise. Thanks for the patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #10 from jvdelisle at gcc dot gnu dot org  2010-07-18 22:19 -------
Full regression test passed on IBM Power 5. I will submit patch for approval
this evening. Thanks for bug report and testing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #11 from jvdelisle at gcc dot gnu dot org  2010-07-19 13:12 -------
Subject: Bug 44953

Author: jvdelisle
Date: Mon Jul 19 13:11:54 2010
New Revision: 162304

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162304
Log:
2010-07-19  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

        PR libfortran/44953
        * io/unix.c (mem_alloc_w4): Return gfc_char4_t instead of char type
        pointer. (mem_write4): Remove cast to gfc_char4_t.
        * io/transfer.c (write_block): Use a gfc_char4_t pointer.
        (memset4): New helper function. (next_record_w): Use new helper
        function rather than sset for internal units.  Don't attempt to pad
        with spaces if it is not needed.
        * io/unix.h: Update prototype for mem_alloc_w4.
        * io/write.c (memset4): Use gfc_char4_t pointer and chracter type.
        Don't use multiply by 4 to compute offset. (memcpy4): Likewise.
        (write_default_char4): Use a gfc_char4_t pointer and update memset4
        and memcpy calls. (write_a): Likewise. (write_l): Likewise.
        (write_boz): Likewise. (write_decimal): Likewise. (write_x): Likewise.
        (write_char): Add support for character(kind=4) internal units that
        was previously missed. (write_integer): Use a gfc_char4_t pointer and
        update memset4 and memcpy calls. (write_character): Likewise.
        (write_separator): Add support for character(kind=4) internal units
        that was previously missed.
        * write_float.def (output_float): Use a gfc_char4_t pointer and
        update memset4 and memcpy calls. (write_infnan): Likewise.
        (output_float_FMT_G_): Likewise.

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/transfer.c
    trunk/libgfortran/io/unix.c
    trunk/libgfortran/io/unix.h
    trunk/libgfortran/io/write.c
    trunk/libgfortran/io/write_float.def


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953

[Bug fortran/44953] FAIL: gfortran.dg/char4_iunit_1.f03 * execution test

[jvdelisle at gcc dot gnu dot org]

------- Comment #12 from jvdelisle at gcc dot gnu dot org  2010-07-20 01:10 -------
Fixed, thanks for report.


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44953