[Bug middle-end/45015] New: ICE in cselib.c caused by fix for PR43051

[Bug middle-end/45015] New: ICE in cselib.c caused by fix for PR43051

[mkuvyrkov at gcc dot gnu dot org]

The fix for PR43051 causes ICE when building GLIBC for ColdFire Linux.

The problem was made latent on trunk by the fix for PR44492 (rev. 161328).  It
doesn't look like this patch fixes the underlying problem, but I may be wrong.

Jacub,

Do you think the fix for PR44492 legitimately fixes the ICE?


To reproduce:

1. Revert rev. 161328 from trunk or revert to rev. 161327

2. Configure the compiler with
$ .../configure --target=m68k-linux-gnu --with-arch=cf --enable-threads
--disable-libmudflap --disable-libssp --disable-libstdcxx-pch --with-gnu-as
--with-gnu-ld --enable-languages=c --enable-shared --enable-lto
--enable-symvers=gnu --enable-__cxa_atexit --disable-nls --enable-libgomp

3.
$ .../cc1 ~/tmp/addmul_1.i -std=gnu99 -fgnu89-inline -O2 -Wall -Winline
-Wwrite-strings -fmerge-all-constants -fno-unwind-tables -g -o ~/tmp/addmul_1.s
...
addmul_1.c: In function '__mpn_addmul_1':
addmul_1.c:65:1: internal compiler error: in cselib_record_set, at
cselib.c:2000
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: ICE in cselib.c caused by fix for PR43051
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mkuvyrkov at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: m68k-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug middle-end/45015] ICE in cselib.c caused by fix for PR43051

[mkuvyrkov at gcc dot gnu dot org]

------- Comment #1 from mkuvyrkov at gcc dot gnu dot org  2010-07-21 07:20 -------
Created an attachment (id=21276)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21276&action=view)
Testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
          Component|middle-end                  |debug
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-21 12:29:16
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2010-07-21 12:40 -------
Created an attachment (id=21278)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21278&action=view)
gcc46-pr45015.patch

Untested fix (together with testcase that fails even with current trunk without
the patch).  Will bootstrap/regtest on x86_64-linux and i686-linux, can you
please do the same on m68k?  Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[mkuvyrkov at gcc dot gnu dot org]

------- Comment #3 from mkuvyrkov at gcc dot gnu dot org  2010-07-21 17:58 -------
Created an attachment (id=21280)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21280&action=view)
Testcase for patch

Thanks for looking into this problem!

The patch fixes the original testcase but causes a segmentation fault when
compiling libgcc.

.../cc1 -fpreprocessed libgcc2.i -quiet -dumpbase libgcc2.c -mcpu=54455
-auxbase-strip _muldi3.o -g -g -g -O2 -W -Wall -Wwrite-strings -Wcast-qual
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -version -fPIC
-fvisibility=hidden -fremove-local-statics -o libgcc2.s


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2010-07-21 18:05 -------
Can't reproduce that.  Were you testing the patch attached here, or the one
posted to gcc-patches?  The one attached here won't work when not
ENABLE_CHECKING...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[maxim at codesourcery dot com]

------- Comment #5 from mkuvyrkov at gcc dot gnu dot org  2010-07-21 18:20 -------
Subject: Re:  ICE in cselib.c caused by fix for PR43051

On 7/21/10 10:05 PM, jakub at gcc dot gnu dot org wrote:
> ------- Comment #4 from jakub at gcc dot gnu dot org  2010-07-21 18:05 -------
> Can't reproduce that.  Were you testing the patch attached here, or the one
> posted to gcc-patches?  The one attached here won't work when not
> ENABLE_CHECKING...

That fixes the SIGSEGV.  Regtesting on m68k didn't show any regressions.

Thanks for fixing this.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2010-07-21 19:12 -------
Subject: Bug 45015

Author: jakub
Date: Wed Jul 21 19:11:55 2010
New Revision: 162385

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162385
Log:
        PR debug/45015
        * var-tracking.c (adjust_mems): Ignore ASM_OPERANDS with non-zero
        ASM_OPERANDS_OUTPUT_IDX.
        (adjust_insn): For inline asm with multiple sets ensure first
        ASM_OPERANDS vectors are used by all following ASM_OPERANDS in
        the insn.

        * gcc.target/m68k/pr45015.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/m68k/pr45015.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/var-tracking.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2010-07-22 06:38 -------
Subject: Bug 45015

Author: jakub
Date: Thu Jul 22 06:38:25 2010
New Revision: 162397

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=162397
Log:
        PR debug/45015
        * var-tracking.c (adjust_mems): Ignore ASM_OPERANDS with non-zero
        ASM_OPERANDS_OUTPUT_IDX.
        (adjust_insn): For inline asm with multiple sets ensure first
        ASM_OPERANDS vectors are used by all following ASM_OPERANDS in
        the insn.

        * gcc.target/m68k/pr45015.c: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.target/m68k/pr45015.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/var-tracking.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015

[Bug debug/45015] ICE in cselib.c caused by fix for PR43051

[jakub at gcc dot gnu dot org]

------- Comment #8 from jakub at gcc dot gnu dot org  2010-07-22 06:46 -------
Should be fixed now.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45015