[Bug fortran/45081] New: ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[Bug fortran/45081] New: ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[ohl at physik dot uni-wuerzburg dot de]

The following code, with default options,

  module m
    implicit none
    type t
      integer :: i
    end type t
    type(t), dimension(1), parameter :: a1  = (/ t(1) /)
    type(t), dimension(1), parameter :: a = reshape ( (/ a1 /), (/ 1 /) )
  end module m

triggers:

  f951: internal compiler error: in gfc_conv_array_initializer, at
fortran/trans-array.c:4208

in

  GNU Fortran (GCC) 4.6.0 20100726 (experimental)

The code compiles with the NAG compiler, as it should.  gfortran also compiles
the equivalent code for INTEGERS instead of the derived type.

Maybe there is a relation to bug #44742.


-- 
           Summary: ICE in gfc_conv_array_initializer, at fortran/trans-
                    array.c:4208
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ohl at physik dot uni-wuerzburg dot de
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2010-07-26 15:22 -------
Confirmed as a regression: it compiles with 4.2.4 (ppc-darwin), gives an ICE
with 4.3.4, 4.4.2, 4.5.0 and trunk.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu dot org]

-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
            Summary|ICE in                      |[4.3/4.4/4.5/4.6 Regression]
                   |gfc_conv_array_initializer, |ICE in
                   |at fortran/trans-           |gfc_conv_array_initializer,
                   |array.c:4208                |at fortran/trans-
                   |                            |array.c:4208
   Target Milestone|---                         |4.5.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu dot org]

------- Comment #2 from burnus at gcc dot gnu dot org  2010-07-26 20:19 -------
Untested patch.

Index: expr.c
===================================================================
--- expr.c      (Revision 162542)
+++ expr.c
@@ -913,7 +913,7 @@ gfc_is_constant_expr (gfc_expr *e)
                  || gfc_is_constant_expr (e->value.op.op2)));

     case EXPR_VARIABLE:
-      return 0;
+      return (e->symtree->n.sym->attr.flavour == FL_PARAMETER);

     case EXPR_FUNCTION:
     case EXPR_PPC:


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2010-07-27 06:04 -------
(In reply to comment #2)
> Untested patch.
> +      return (e->symtree->n.sym->attr.flavour == FL_PARAMETER);

s/flavour/flavor/
It also regresses (diagnostics) in gfortran.dg/transfer_simplify_2.f90 /
gfortran.dg/transfer_simplify_7.f90.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2010-07-27 06:56 -------
> It also regresses (diagnostics) in gfortran.dg/transfer_simplify_2.f90 /
> gfortran.dg/transfer_simplify_7.f90.

I also see a regression for gfortran.dg/parameter_array_section_1.f90

[macbook] f90/bug% gfc
/opt/gcc/work/gcc/testsuite/gfortran.dg/parameter_array_section_1.f90
/opt/gcc/work/gcc/testsuite/gfortran.dg/parameter_array_section_1.f90: In
function 'foo':
/opt/gcc/work/gcc/testsuite/gfortran.dg/parameter_array_section_1.f90:17:0:
internal compiler error: in gfc_typenode_for_spec, at fortran/trans-types.c:996

In addition the patch does not seems to fix this pr.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2010-07-31 09:30 -------
GCC 4.5.1 is being released, adjusting target milestone.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.1                       |4.5.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2010-08-17 12:07 -------
(In reply to comment #1)
> Confirmed as a regression: it compiles with 4.2.4 (ppc-darwin), gives an ICE
> with 4.3.4, 4.4.2, 4.5.0 and trunk.
> 

You did not mark the PR as confirmed  :-)

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-17 12:07:05
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu dot org]

------- Comment #7 from pault at gcc dot gnu dot org  2010-09-16 05:11 -------
Created an attachment (id=21808)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21808&action=view)
A fix for this PR

Bootstraps and regtests on FC9/x86_64.

It is clear that many other array intrinsics fail with derived type sources.  I
have verified this for (un)pack and applied it to the attached patch.  I
believe that there are related PRs that I have to find.

I am away until Monday. I will complete the job then and submit thereafter.

Cheers

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[dominiq at lps dot ens dot fr]

------- Comment #8 from dominiq at lps dot ens dot fr  2010-09-16 07:06 -------
> I believe that there are related PRs that I have to find.

pr40472 comment #21 for SPREAD:

REAL, DIMENSION(720,360), PARAMETER :: ZLON_MASK = SPREAD( (/ (JLON ,
JLON=1,720) /) , DIM=2, NCOPIES=360 )
print *, size(ZLON_MASK), ZLON_MASK(720,360)
end

The tests in pr42359 also give ICE at fortran/trans-array.c, but at different
locations.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[paul dot richard dot thomas at gmail dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]



------- Comment #9 from paul dot richard dot thomas at gmail dot com  2010-09-16 09:43 -------
Subject: Re:  [4.3/4.4/4.5/4.6 Regression] ICE in
 gfc_conv_array_initializer, at fortran/trans-array.c:4208

Thanks! Paul

On Thu, Sep 16, 2010 at 9:06 AM, dominiq at lps dot ens dot fr
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #8 from dominiq at lps dot ens dot fr  2010-09-16 07:06 -------
>> I believe that there are related PRs that I have to find.
>
> pr40472 comment #21 for SPREAD:
>
> REAL, DIMENSION(720,360), PARAMETER :: ZLON_MASK = SPREAD( (/ (JLON ,
> JLON=1,720) /) , DIM=2, NCOPIES=360 )
> print *, size(ZLON_MASK), ZLON_MASK(720,360)
> end
>
> The tests in pr42359 also give ICE at fortran/trans-array.c, but at different
> locations.
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081
>
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[dominiq at lps dot ens dot fr]

------- Comment #10 from dominiq at lps dot ens dot fr  2010-09-16 13:14 -------
(1) The patch in comment #7 fixes this pr without regression.

(2) If I replace 

    type(t), dimension(1), parameter :: a1  = (/ t(1) /)
    type(t), dimension(1), parameter :: a = reshape ( (/ a1 /), (/ 1 /) )

with

    type(t), dimension(2), parameter :: a1  = (/ t(1), t(2) /)
    type(t), dimension(2), parameter :: c = spread ( a1(1), 1, 1 )

I still get the same ICE.

(3) I have opened pr45689 for transformational intrinsics I think are missing
for initializations.

(4) The only common point between this pr and those given in comment #8 is that
the ICEs come from the same source file.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2010-09-20 18:55 -------
Subject: Bug 45081

Author: pault
Date: Mon Sep 20 18:55:12 2010
New Revision: 164448

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164448
Log:
2010-09-20  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * simplify.c (is_constant_array_expr): Allow structure array
        elements as well as constants.
        (gfc_simplify_pack, gfc_simplify_reshape, gfc_simplify_spread,
        gfc_simplify_transpose, gfc_simplify_unpack): Copy the derived
        type of source to the result.

2010-09-20  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * gfortran.dg/derived_array_intrinsics_1.f90 : New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/derived_array_intrinisics_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/simplify.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081

[Bug fortran/45081] [4.3/4.4/4.5/4.6 Regression] ICE in gfc_conv_array_initializer, at fortran/trans-array.c:4208

[pault at gcc dot gnu dot org]

------- Comment #12 from pault at gcc dot gnu dot org  2010-09-20 21:23 -------
Subject: Bug 45081

Author: pault
Date: Mon Sep 20 21:23:38 2010
New Revision: 164457

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164457
Log:
2010-09-20  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * simplify.c (is_constant_array_expr): Allow structure array
        elements as well as constants.
        (gfc_simplify_pack, gfc_simplify_reshape, gfc_simplify_spread,
        gfc_simplify_transpose, gfc_simplify_unpack): Copy the derived
        type of source to the result.

2010-09-20  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/45081
        * gfortran.dg/derived_array_intrinsics_1.f90 : New test.


Added:
   
branches/gcc-4_5-branch/gcc/testsuite/gfortran.dg/derived_array_intrinisics_1.f90
Modified:
    branches/gcc-4_5-branch/gcc/fortran/ChangeLog
    branches/gcc-4_5-branch/gcc/fortran/simplify.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45081