* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
@ 2009-08-25 15:52 ` jsm28 at gcc dot gnu dot org
2009-08-25 15:57 ` rwild at gcc dot gnu dot org
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2009-08-25 15:52 UTC (permalink / raw)
To: gcc-bugs
--
jsm28 at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
2009-08-25 15:52 ` [Bug testsuite/41166] " jsm28 at gcc dot gnu dot org
@ 2009-08-25 15:57 ` rwild at gcc dot gnu dot org
2009-08-25 16:23 ` joseph at codesourcery dot com
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: rwild at gcc dot gnu dot org @ 2009-08-25 15:57 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from rwild at gcc dot gnu dot org 2009-08-25 15:57 -------
AFACIS, the bug is in the test_summary script, it tries to "parse" the
internals of a config.status file. To extract values from config.status
portably (across both systems and Autoconf versions), use either an
AC_CONFIG_FILES instance, or just invoke it ad-hoc, for example:
value_of_substed=`echo @substed@ | ./config.status --file=-`
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
2009-08-25 15:52 ` [Bug testsuite/41166] " jsm28 at gcc dot gnu dot org
2009-08-25 15:57 ` rwild at gcc dot gnu dot org
@ 2009-08-25 16:23 ` joseph at codesourcery dot com
2009-08-25 16:32 ` rwild at gcc dot gnu dot org
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: joseph at codesourcery dot com @ 2009-08-25 16:23 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from joseph at codesourcery dot com 2009-08-25 16:23 -------
Subject: Re: [4.5 Regression] Syntax error: Unterminated
quoted string
On Tue, 25 Aug 2009, rwild at gcc dot gnu dot org wrote:
> AFACIS, the bug is in the test_summary script, it tries to "parse" the
> internals of a config.status file. To extract values from config.status
> portably (across both systems and Autoconf versions), use either an
> AC_CONFIG_FILES instance, or just invoke it ad-hoc, for example:
>
> value_of_substed=`echo @substed@ | ./config.status --file=-`
It's a bad idea for the script to depend at all on either config.status or
a build tree - right now it's necessary to fake a config.status file when
doing installed-compiler testing.
The gcc testsuite should arrange to put the "Configured with:" line from
gcc -v output in the .sum file (it's already in some .log files, and in
acats.sum), and the script should use that line to extract configure
options.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (2 preceding siblings ...)
2009-08-25 16:23 ` joseph at codesourcery dot com
@ 2009-08-25 16:32 ` rwild at gcc dot gnu dot org
2009-08-25 16:58 ` joseph at codesourcery dot com
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: rwild at gcc dot gnu dot org @ 2009-08-25 16:32 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from rwild at gcc dot gnu dot org 2009-08-25 16:32 -------
(In reply to comment #2)
> > value_of_substed=`echo @substed@ | ./config.status --file=-`
>
> It's a bad idea for the script to depend at all on either config.status or
> a build tree
I don't understand this remark. If the script shouldn't depend on
config.status, well, then why does it read it? There should be no
additional limitation between reading the script and running it,
at least how I understand it.
> - right now it's necessary to fake a config.status file when
> doing installed-compiler testing.
Well, it would certainly be easier to fake
echo @TOPLEVEL_CONFIGURE_ARGUMENTS@ | ./config.status --file=-
with a two-line script of the form:
#! /bin/sh
echo args...
than it is to fake internal details and remove the complex quoting
done inside config.status.
> The gcc testsuite should arrange to put the "Configured with:" line from
> gcc -v output in the .sum file (it's already in some .log files, and in
> acats.sum), and the script should use that line to extract configure
> options.
Fine with me, but not my area of expertise.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (3 preceding siblings ...)
2009-08-25 16:32 ` rwild at gcc dot gnu dot org
@ 2009-08-25 16:58 ` joseph at codesourcery dot com
2009-08-26 21:40 ` rwild at gcc dot gnu dot org
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: joseph at codesourcery dot com @ 2009-08-25 16:58 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from joseph at codesourcery dot com 2009-08-25 16:58 -------
Subject: Re: [4.5 Regression] Syntax error: Unterminated
quoted string
On Tue, 25 Aug 2009, rwild at gcc dot gnu dot org wrote:
> ------- Comment #3 from rwild at gcc dot gnu dot org 2009-08-25 16:32 -------
> (In reply to comment #2)
> > > value_of_substed=`echo @substed@ | ./config.status --file=-`
> >
> > It's a bad idea for the script to depend at all on either config.status or
> > a build tree
>
> I don't understand this remark. If the script shouldn't depend on
> config.status, well, then why does it read it? There should be no
It reads it because at present the required information is not present in
the .sum files, and installed testing separate from a build tree was not
considered when the script was written.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (4 preceding siblings ...)
2009-08-25 16:58 ` joseph at codesourcery dot com
@ 2009-08-26 21:40 ` rwild at gcc dot gnu dot org
2009-08-27 18:59 ` rwild at gcc dot gnu dot org
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: rwild at gcc dot gnu dot org @ 2009-08-26 21:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from rwild at gcc dot gnu dot org 2009-08-26 21:39 -------
patch at <http://gcc.gnu.org/ml/gcc-patches/2009-08/msg01371.html>
avoiding the regression but not fixing issues in remark #2
--
rwild at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2009-08-26 21:39:54
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] [4.5 Regression] Syntax error: Unterminated quoted string
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (5 preceding siblings ...)
2009-08-26 21:40 ` rwild at gcc dot gnu dot org
@ 2009-08-27 18:59 ` rwild at gcc dot gnu dot org
2009-08-27 19:04 ` [Bug testsuite/41166] contrib/test_summary should not depend upon config.status rwild at gcc dot gnu dot org
` (2 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: rwild at gcc dot gnu dot org @ 2009-08-27 18:59 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from rwild at gcc dot gnu dot org 2009-08-27 18:59 -------
Subject: Bug 41166
Author: rwild
Date: Thu Aug 27 18:59:32 2009
New Revision: 151145
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=151145
Log:
Let test_summary invoke, not parse config.status contents.
contrib/*
PR testsuite/41166
* test_summary: Invoke config.status, rather than trying to
parse it. Adjust awk script.
Modified:
trunk/contrib/ChangeLog
trunk/contrib/test_summary
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] contrib/test_summary should not depend upon config.status
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (6 preceding siblings ...)
2009-08-27 18:59 ` rwild at gcc dot gnu dot org
@ 2009-08-27 19:04 ` rwild at gcc dot gnu dot org
2010-04-06 11:38 ` rguenth at gcc dot gnu dot org
2010-07-31 9:35 ` rguenth at gcc dot gnu dot org
9 siblings, 0 replies; 14+ messages in thread
From: rwild at gcc dot gnu dot org @ 2009-08-27 19:04 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from rwild at gcc dot gnu dot org 2009-08-27 19:04 -------
Changing bug title to reflect the remaining issues; not a regression any more.
--
rwild at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.5 Regression] Syntax |contrib/test_summary should
|error: Unterminated quoted |not depend upon
|string |config.status
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] contrib/test_summary should not depend upon config.status
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (7 preceding siblings ...)
2009-08-27 19:04 ` [Bug testsuite/41166] contrib/test_summary should not depend upon config.status rwild at gcc dot gnu dot org
@ 2010-04-06 11:38 ` rguenth at gcc dot gnu dot org
2010-07-31 9:35 ` rguenth at gcc dot gnu dot org
9 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-04-06 11:38 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from rguenth at gcc dot gnu dot org 2010-04-06 11:20 -------
GCC 4.5.0 is being released. Deferring to 4.5.1.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.0 |4.5.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug testsuite/41166] contrib/test_summary should not depend upon config.status
2009-08-25 15:20 [Bug testsuite/41166] New: [4.5 Regression] Syntax error: Unterminated quoted string hjl dot tools at gmail dot com
` (8 preceding siblings ...)
2010-04-06 11:38 ` rguenth at gcc dot gnu dot org
@ 2010-07-31 9:35 ` rguenth at gcc dot gnu dot org
9 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-07-31 9:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from rguenth at gcc dot gnu dot org 2010-07-31 09:29 -------
GCC 4.5.1 is being released, adjusting target milestone.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.1 |4.5.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41166
^ permalink raw reply [flat|nested] 14+ messages in thread