public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/45221] missed optimization with multiple bases and casting Date: Sat, 07 Aug 2010 10:37:00 -0000 [thread overview] Message-ID: <20100807103729.23811.qmail@sourceware.org> (raw) In-Reply-To: <bug-45221-17658@http.gcc.gnu.org/bugzilla/> ------- Comment #4 from rguenth at gcc dot gnu dot org 2010-08-07 10:37 ------- I don't see what the bug is here - this is a feature of the C++ standard, we can't really "optimize" anything here. 5.2.9/8 ... The null pointer value is converted to the null pointer value of the destination type. In the case of foo3 'y' is not a pointer so that special case does not apply. The only thing we can do is excercise knowledge of undefined behavior as you dereference the resulting pointer in foo1 and foo2 and thus the behavior is undefined if that would be a null pointer. The FE hands us ;; Function int foo2(Base2*) (null) ;; enabled by -tree-original return <retval> = (x != 0B ? (struct Derived *) x + -4 : 0B)->data; and we arrive with <bb 2>: if (x_2(D) != 0B) goto <bb 3>; else goto <bb 4>; <bb 3>: iftmp.1_3 = x_2(D) + -4; goto <bb 5>; <bb 4>: iftmp.1_4 = 0; <bb 5>: # iftmp.1_1 = PHI <iftmp.1_3(3), 0(4)> D.1726_5 = iftmp.1_1->data; which we could for example (with -fdelete-null-pointer-checks, where no objects at address zero can exist), optimize during phiprop if we insert undefined values as loads from NULL. We could also value-number loads based on NULL to VN_TOP which would optimize the case during PRE. Much less fragile is when the code gets inlined into a context where we know that x isn't a NULL pointer. -- rguenth at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rguenth at gcc dot gnu dot | |org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45221
next prev parent reply other threads:[~2010-08-07 10:37 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-07 1:28 [Bug c++/45221] New: missed optimization on casting pointers even under -O3 navin dot kumar at gmail dot com 2010-08-07 1:29 ` [Bug c++/45221] " navin dot kumar at gmail dot com 2010-08-07 1:33 ` [Bug c++/45221] missed optimization with multiple bases and up casting and dereferencing pinskia at gcc dot gnu dot org 2010-08-07 2:27 ` navin dot kumar at gmail dot com 2010-08-07 10:37 ` rguenth at gcc dot gnu dot org [this message] 2010-08-07 15:26 ` [Bug c++/45221] missed optimization with multiple bases and casting navin dot kumar at gmail dot com 2010-08-07 16:19 ` rguenth at gcc dot gnu dot org 2010-08-07 16:23 ` navin dot kumar at gmail dot com 2010-08-07 16:25 ` rguenth at gcc dot gnu dot org 2010-08-07 16:27 ` rguenth at gcc dot gnu dot org 2010-08-07 17:28 ` navin dot kumar at gmail dot com [not found] <bug-45221-4@http.gcc.gnu.org/bugzilla/> 2011-05-17 15:49 ` navin.kumar at gmail dot com 2023-05-06 18:14 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100807103729.23811.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).