public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/45235] const volatile read moved out of order
Date: Mon, 09 Aug 2010 13:56:00 -0000	[thread overview]
Message-ID: <20100809135606.22339.qmail@sourceware.org> (raw)
In-Reply-To: <bug-45235-6848@http.gcc.gnu.org/bugzilla/>



------- Comment #2 from rguenth at gcc dot gnu dot org  2010-08-09 13:56 -------
Probably easier to not set TREE_READONLY or MEM_READONY_P here.

Index: gcc/emit-rtl.c
===================================================================
--- gcc/emit-rtl.c      (revision 163030)
+++ gcc/emit-rtl.c      (working copy)
@@ -1669,7 +1670,8 @@ set_mem_attributes_minus_bitpos (rtx ref
       base = get_base_address (base);
       if (base && DECL_P (base)
          && TREE_READONLY (base)
-         && (TREE_STATIC (base) || DECL_EXTERNAL (base)))
+         && (TREE_STATIC (base) || DECL_EXTERNAL (base))
+         && !TREE_THIS_VOLATILE (base))
        MEM_READONLY_P (ref) = 1;

       /* If this expression uses it's parent's alias set, mark it such


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |wrong-code
   Last reconfirmed|0000-00-00 00:00:00         |2010-08-09 13:56:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45235


  parent reply	other threads:[~2010-08-09 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 11:56 [Bug rtl-optimization/45235] New: " bigotp at acm dot org
2010-08-09 11:57 ` [Bug rtl-optimization/45235] " bigotp at acm dot org
2010-08-09 13:56 ` rguenth at gcc dot gnu dot org [this message]
2010-08-11 21:41 ` pinskia at gcc dot gnu dot org
2010-08-11 22:55 ` bigotp at acm dot org
2010-08-11 23:11 ` rguenth at gcc dot gnu dot org
     [not found] <bug-45235-4@http.gcc.gnu.org/bugzilla/>
2010-12-31 17:57 ` bigotp at acm dot org
2011-01-11 15:42 ` rguenth at gcc dot gnu.org
2011-01-11 15:44 ` rguenth at gcc dot gnu.org
2011-12-15  0:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100809135606.22339.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).