[Bug fortran/45576] New: [4.6 Regression] ICE on character stuff

[Bug fortran/45576] New: [4.6 Regression] ICE on character stuff

[jv244 at cam dot ac dot uk]

this started failing with today's trunk

  SUBROUTINE get_r_val()
    INTEGER, PARAMETER :: default_string_length=128
    CHARACTER(len=default_string_length) :: c_val
    LOGICAL                              :: check 
    check = c_val(LEN_TRIM(c_val):LEN_TRIM(c_val))=="]"
  END SUBROUTINE get_r_val


-- 
           Summary: [4.6 Regression] ICE on character stuff
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jv244 at cam dot ac dot uk


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[jv244 at cam dot ac dot uk]

-- 

jv244 at cam dot ac dot uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkoenig at netcologne dot de
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[dominiq at lps dot ens dot fr]

------- Comment #1 from dominiq at lps dot ens dot fr  2010-09-07 07:56 -------
Confirmed: 163913 works, 163940 gives an ICE. The backtrace is

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x0000000000000000
gfc_dep_compare_expr (e1=0x0, e2=0x0) at
../../work/gcc/fortran/dependency.c:353
353           return -2;
(gdb) bt
#0  gfc_dep_compare_expr (e1=0x0, e2=0x0) at
../../work/gcc/fortran/dependency.c:353
#1  0x000000010009e662 in gfc_dep_compare_expr (e1=<value temporarily
unavailable, due to optimizations>, e2=<value temporarily unavailable, due to
optimizations>) at ../../work/gcc/fortran/dependency.c:371

likely due to revision 163932.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[mikael at gcc dot gnu dot org]

------- Comment #2 from mikael at gcc dot gnu dot org  2010-09-07 12:56 -------
Index: dependency.c
===================================================================
--- dependency.c        (r��vision 163944)
+++ dependency.c        (copie de travail)
@@ -182,6 +182,12 @@ gfc_dep_compare_expr (gfc_expr *e1, gfc_expr *e2)
   int i;
   gfc_expr *n1, *n2;

+  if (e1 == e2)
+    return 0;
+
+  if (e1 == NULL || e2 == NULL)
+    return -2;
+
   n1 = NULL;
   n2 = NULL;



-- 

mikael at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |mikael at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-09-07 12:56:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[tkoenig at gcc dot gnu dot org]

------- Comment #3 from tkoenig at gcc dot gnu dot org  2010-09-07 16:48 -------
(In reply to comment #2)
> Index: dependency.c
> ===================================================================
> --- dependency.c        (r��vision 163944)
> +++ dependency.c        (copie de travail)
> @@ -182,6 +182,12 @@ gfc_dep_compare_expr (gfc_expr *e1, gfc_expr *e2)
>    int i;
>    gfc_expr *n1, *n2;
> 
> +  if (e1 == e2)
> +    return 0;
> +
> +  if (e1 == NULL || e2 == NULL)
> +    return -2;
> +
>    n1 = NULL;
>    n2 = NULL;

Hi Mikael,

I'd rather fix this somewhere else.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[mikael at gcc dot gnu dot org]

------- Comment #4 from mikael at gcc dot gnu dot org  2010-09-07 17:14 -------
(In reply to comment #3)
> Hi Mikael,
> 
> I'd rather fix this somewhere else.
> 
If you want.
Re-assigning to you then.


-- 

mikael at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mikael at gcc dot gnu dot   |tkoenig at gcc dot gnu dot
                   |org                         |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[tkoenig at gcc dot gnu dot org]

------- Comment #5 from tkoenig at gcc dot gnu dot org  2010-09-07 22:51 -------
Subject: Bug 45576

Author: tkoenig
Date: Tue Sep  7 22:50:54 2010
New Revision: 163978

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=163978
Log:
2010-09-07  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/45576
        * dependency.c (gfc_deb_compare_expr):  Take missing optional
        arguments into account.

2010-09-07  Thomas Koenig  <tkoenig@gcc.gnu.org>

        PR fortran/45576
        * gfortran.dg/char_length_18.f90:  New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/char_length_18.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/dependency.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576

[Bug fortran/45576] [4.6 Regression] ICE on character stuff

[tkoenig at gcc dot gnu dot org]

------- Comment #6 from tkoenig at gcc dot gnu dot org  2010-09-07 22:53 -------
Fixed, closing.


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45576