* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
@ 2009-08-17 4:56 ` hp at gcc dot gnu dot org
2009-08-25 15:50 ` jsm28 at gcc dot gnu dot org
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2009-08-17 4:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from hp at gcc dot gnu dot org 2009-08-17 04:56 -------
I'll have to re-build r150587 to get a diff of the assembly. Without that, the
only things I can say are:
- it's the abort call in the test that is triggered
- the preceding line, "print *, pack (mm, mask)" can be safely commented out
without affecting the bug.
- it's the first iteration
- j==1 and size (pack (mm, mask)) == 2 or vice versa.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
2009-08-17 4:56 ` [Bug tree-optimization/41087] " hp at gcc dot gnu dot org
@ 2009-08-25 15:50 ` jsm28 at gcc dot gnu dot org
2009-09-18 9:02 ` rguenth at gcc dot gnu dot org
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2009-08-25 15:50 UTC (permalink / raw)
To: gcc-bugs
--
jsm28 at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.5.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
2009-08-17 4:56 ` [Bug tree-optimization/41087] " hp at gcc dot gnu dot org
2009-08-25 15:50 ` jsm28 at gcc dot gnu dot org
@ 2009-09-18 9:02 ` rguenth at gcc dot gnu dot org
2009-12-03 4:08 ` hp at gcc dot gnu dot org
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2009-09-18 9:02 UTC (permalink / raw)
To: gcc-bugs
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (2 preceding siblings ...)
2009-09-18 9:02 ` rguenth at gcc dot gnu dot org
@ 2009-12-03 4:08 ` hp at gcc dot gnu dot org
2009-12-03 4:09 ` hp at gcc dot gnu dot org
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2009-12-03 4:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from hp at gcc dot gnu dot org 2009-12-03 04:08 -------
Reappeared as described in (154917:154920] (which are non-specific changes)
Just keeping track, at the moment.
--
hp at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2009-12-03 04:08:06
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (3 preceding siblings ...)
2009-12-03 4:08 ` hp at gcc dot gnu dot org
@ 2009-12-03 4:09 ` hp at gcc dot gnu dot org
2010-04-06 11:25 ` rguenth at gcc dot gnu dot org
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2009-12-03 4:09 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from hp at gcc dot gnu dot org 2009-12-03 04:09 -------
Forgot to mention that it had previously been hidden with a change in
(151359..151366].
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (4 preceding siblings ...)
2009-12-03 4:09 ` hp at gcc dot gnu dot org
@ 2010-04-06 11:25 ` rguenth at gcc dot gnu dot org
2010-07-31 9:35 ` [Bug tree-optimization/41087] [4.5/4.6 " rguenth at gcc dot gnu dot org
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-04-06 11:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from rguenth at gcc dot gnu dot org 2010-04-06 11:20 -------
GCC 4.5.0 is being released. Deferring to 4.5.1.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.0 |4.5.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (5 preceding siblings ...)
2010-04-06 11:25 ` rguenth at gcc dot gnu dot org
@ 2010-07-31 9:35 ` rguenth at gcc dot gnu dot org
2010-09-08 2:14 ` hp at gcc dot gnu dot org
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: rguenth at gcc dot gnu dot org @ 2010-07-31 9:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from rguenth at gcc dot gnu dot org 2010-07-31 09:29 -------
GCC 4.5.1 is being released, adjusting target milestone.
--
rguenth at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.1 |4.5.2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (6 preceding siblings ...)
2010-07-31 9:35 ` [Bug tree-optimization/41087] [4.5/4.6 " rguenth at gcc dot gnu dot org
@ 2010-09-08 2:14 ` hp at gcc dot gnu dot org
2010-09-09 4:08 ` hp at gcc dot gnu dot org
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-08 2:14 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from hp at gcc dot gnu dot org 2010-09-08 02:13 -------
Created an attachment (id=21731)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21731&action=view)
Somewhat simplified test-case
I'm having a look at this.
I simplified the test-case somewhat, eliminating some loops and a print-call.
First appearing in the .ce2 dump of r150588 at -O3 -funroll-loops, we see:
...
IF-THEN-ELSE-JOIN block found, pass 1, test 15, then 37, else 36, join 38
scanning new insn with uid = 1223.
scanning new insn with uid = 1224.
scanning new insn with uid = 1225.
deleting insn with uid = 344.
deleting insn with uid = 332.
deleting insn with uid = 331.
deleting block 36
Removing jump 328.
deleting insn with uid = 328.
deleting insn with uid = 335.
deleting insn with uid = 334.
deleting block 37
merging block 38 into block 15
verify found no changes in insn with uid = 337.
verify found no changes in insn with uid = 338.
verify found no changes in insn with uid = 339.
verify found no changes in insn with uid = 340.
deleting insn with uid = 341.
Merged blocks 15 and 38.
Conversion succeeded on pass 1.
...
with a part of the simplified blocks having the somewhat suspicious instruction
sequence:
...
(note 324 1220 327 15 NOTE_INSN_DELETED)
(insn 327 324 1223 15 /n/slask/hp_tmp/zs3a.f90:14 (set (cc0)
(compare (mem/s:SI (post_inc:SI (reg:SI 241 [ ivtmp.23 ])) [3 S4 A8])
(const_int 0 [0x0]))) 0 {*tstsi} (expr_list:REG_INC (reg:SI 241 [
ivtmp.23 ])
(nil)))
(insn 1223 327 1224 15 /n/slask/hp_tmp/zs3a.f90:14 (set (cc0)
(compare (mem/s:SI (post_inc:SI (reg:SI 241 [ ivtmp.23 ])) [3 S4 A8])
(const_int 0 [0x0]))) 0 {*tstsi} (nil))
(insn 1224 1223 1225 15 /n/slask/hp_tmp/zs3a.f90:14 (set (reg:SI 324)
(ne:SI (cc0)
(const_int 0 [0x0]))) 210 {sne} (nil))
(insn 1225 1224 337 15 /n/slask/hp_tmp/zs3a.f90:14 (set (reg:SI 252 [ j ])
(reg:SI 324)) 36 {*movsi_internal} (nil))
...
In the .combine dump, it's not apparent why this should be correct; note the
first cc0 setter not having a user; with the only effect of the insn being the
memory access (not volatile, so it doesn't count) and the post-increment.
This smells like a bug.
Whether in the post-combine ifcvt pass or in the input is unknown at this time.
--
hp at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |hp at gcc dot gnu dot org
|dot org |
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (7 preceding siblings ...)
2010-09-08 2:14 ` hp at gcc dot gnu dot org
@ 2010-09-09 4:08 ` hp at gcc dot gnu dot org
2010-09-09 4:11 ` hp at gcc dot gnu dot org
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-09 4:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from hp at gcc dot gnu dot org 2010-09-09 04:08 -------
Bother, I should have spotted the general area of this bug faster. It's a
matter of ifcvt.c calling
emit_insn_before_setloc (seq, if_info->jump,
INSN_LOCATOR (if_info->insn_a));
when it should do
emit_insn_before_setloc (seq, if_info->cond_earliest,
INSN_LOCATOR (if_info->insn_a));
(looks like most calls may be wrong)
*and* to handle the case where if_info->cond_earliest (insn 327 above) has
side-effects, since try_redirect_by_replacing_jump (a callee of
redirect_edge_and_branch_force) doesn't remove cc0 setters with side-effects
(while without the if_info->cond_earliest change, it'd see the last of the
emit_store_flag insns instead of the expected cc0 setter). And last but not
least, decorate the new insn(s) with REG_INC notes as appropriate, as regmove
(the next pass) seems to expect them: note that insn 1223 doesn't have one.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (8 preceding siblings ...)
2010-09-09 4:08 ` hp at gcc dot gnu dot org
@ 2010-09-09 4:11 ` hp at gcc dot gnu dot org
2010-09-09 8:11 ` hp at gcc dot gnu dot org
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-09 4:11 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from hp at gcc dot gnu dot org 2010-09-09 04:11 -------
(In reply to comment #7)
> And last but not
> least, decorate the new insn(s) with REG_INC notes as appropriate, as regmove
> (the next pass) seems to expect them: note that insn 1223 doesn't have one.
See-also PR11052, which got in trouble when the cstore *target* (not the test
insn) had a post_inc.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (9 preceding siblings ...)
2010-09-09 4:11 ` hp at gcc dot gnu dot org
@ 2010-09-09 8:11 ` hp at gcc dot gnu dot org
2010-09-10 3:25 ` hp at gcc dot gnu dot org
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-09 8:11 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from hp at gcc dot gnu dot org 2010-09-09 08:11 -------
Created an attachment (id=21748)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21748&action=view)
patch
The simplest solution is to correct noce_get_condition to not follow its
documentation and not allow conditions that aren't "valid at JUMP" rather than
"valid at EARLIEST", simply because we can't allow an additional side-effect.
Maybe too simple for some, but simple and safe enough for a release-branch.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug tree-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (10 preceding siblings ...)
2010-09-09 8:11 ` hp at gcc dot gnu dot org
@ 2010-09-10 3:25 ` hp at gcc dot gnu dot org
2010-09-11 4:56 ` [Bug rtl-optimization/41087] " hp at gcc dot gnu dot org
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-10 3:25 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from hp at gcc dot gnu dot org 2010-09-10 03:25 -------
Created an attachment (id=21760)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21760&action=view)
Patch, take 2.
Need to gate the side_effects_p call: tmp != NULL_RTX && side_effects_p (tmp).
--
hp at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21748|0 |1
is obsolete| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug rtl-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (11 preceding siblings ...)
2010-09-10 3:25 ` hp at gcc dot gnu dot org
@ 2010-09-11 4:56 ` hp at gcc dot gnu dot org
2010-09-13 0:49 ` hp at gcc dot gnu dot org
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-11 4:56 UTC (permalink / raw)
To: gcc-bugs
------- Comment #11 from hp at gcc dot gnu dot org 2010-09-11 04:56 -------
Corrected component re: analysis.
--
hp at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|tree-optimization |rtl-optimization
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug rtl-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (12 preceding siblings ...)
2010-09-11 4:56 ` [Bug rtl-optimization/41087] " hp at gcc dot gnu dot org
@ 2010-09-13 0:49 ` hp at gcc dot gnu dot org
2010-09-13 0:53 ` hp at gcc dot gnu dot org
2010-09-13 1:08 ` hp at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-13 0:49 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from hp at gcc dot gnu dot org 2010-09-13 00:49 -------
Subject: Bug 41087
Author: hp
Date: Mon Sep 13 00:49:27 2010
New Revision: 164240
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164240
Log:
PR rtl-optimization/41087
* ifcvt.c (noce_get_condition): Don't allow conditions with
side-effects.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ifcvt.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug rtl-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (13 preceding siblings ...)
2010-09-13 0:49 ` hp at gcc dot gnu dot org
@ 2010-09-13 0:53 ` hp at gcc dot gnu dot org
2010-09-13 1:08 ` hp at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-13 0:53 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from hp at gcc dot gnu dot org 2010-09-13 00:53 -------
Subject: Bug 41087
Author: hp
Date: Mon Sep 13 00:52:48 2010
New Revision: 164241
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164241
Log:
PR rtl-optimization/41087
* ifcvt.c (noce_get_condition): Don't allow conditions with
side-effects.
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
branches/gcc-4_5-branch/gcc/ifcvt.c
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread* [Bug rtl-optimization/41087] [4.5/4.6 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution
2009-08-17 4:17 [Bug tree-optimization/41087] New: [4.5 Regression]: cris-elf gfortran.dg/zero_sized_3.f90 -O3 -funroll-loops execution hp at gcc dot gnu dot org
` (14 preceding siblings ...)
2010-09-13 0:53 ` hp at gcc dot gnu dot org
@ 2010-09-13 1:08 ` hp at gcc dot gnu dot org
15 siblings, 0 replies; 17+ messages in thread
From: hp at gcc dot gnu dot org @ 2010-09-13 1:08 UTC (permalink / raw)
To: gcc-bugs
------- Comment #14 from hp at gcc dot gnu dot org 2010-09-13 01:07 -------
committed <http://gcc.gnu.org/ml/gcc-patches/2010-09/msg00932.html>
--
hp at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41087
^ permalink raw reply [flat|nested] 17+ messages in thread