[Bug lto/44246] New: ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[Bug lto/44246] New: ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[zsojka at seznam dot cz]

testcase.c:
-----------------------------
int main(int argc, char *argv[])
{
  strcat(argv[0], "X");
  return strlen(argv[0]);
}
----------------------------

Command line:
$ gcc -flto testcase.c
or
$ gcc -fwhopr testcase.c

Compiler output (-flto):
$ /mnt/svn/gcc-trunk/binary-159696-lto-fortran/bin/gcc -flto testcase.c
testcase.c: In function 'main':
testcase.c:3:3: warning: incompatible implicit declaration of built-in function
'strcat' [enabled by default]
testcase.c:4:10: warning: incompatible implicit declaration of built-in
function 'strlen' [enabled by default]
lto1: error: inlined_to pointer set for noninline callers
lto1: error: inlined_to pointer set for noninline callers
lto1: error: non-DECL_ONE_ONLY node in a same_comdat_group list
lto1: error: same_comdat_group is not a circular list
__builtin_strlen/1(-1) @0x7f2ce1a75690 (asm: strlen) (inline copy in main/0)
availability:not_available
  called by: main/0 (1.00 per call) main/0 (1.00 per call)
  calls:
  References:
  Refering this function:
lto1: internal compiler error: verify_cgraph_node failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
lto-wrapper: /mnt/svn/gcc-trunk/binary-159696-lto-fortran/bin/gcc returned 1
exit status
collect2: lto-wrapper returned 1 exit status

Compiler output (-fwhopr):
$ /mnt/svn/gcc-trunk/binary-159696-lto-fortran/bin/gcc -fwhopr testcase.c
testcase.c: In function 'main':
testcase.c:3:3: warning: incompatible implicit declaration of built-in function
'strcat' [enabled by default]
testcase.c:4:10: warning: incompatible implicit declaration of built-in
function 'strlen' [enabled by default]
lto1: internal compiler error: in function_and_variable_visibility, at
ipa.c:642
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
lto-wrapper: /mnt/svn/gcc-trunk/binary-159696-lto-fortran/bin/gcc returned 1
exit status
collect2: lto-wrapper returned 1 exit status

Tested revisions:
r159696 - crash
r158969 - crash
r158095 - OK -fwhopr, crash -flto
4.5 r158978 - OK -fwhopr, crash -flto (with checking)


-- 
           Summary: ICE with -fwhopr/-flto when using strlen and strcat
                    without previous declaration
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: zsojka at seznam dot cz
  GCC host triplet: x86_64-pc-linux-gnu
GCC target triplet: x86_64-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2010-07-22 14:34 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2010-07-22 14:34:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at gcc dot gnu dot org]

------- Comment #2 from hubicka at gcc dot gnu dot org  2010-09-17 12:19 -------
seems like streamer bug. We should not ever see any comdat groups here.


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |hubicka at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2010-07-22 14:34:30         |2010-09-17 12:19:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at ucw dot cz]

------- Comment #3 from hubicka at ucw dot cz  2010-09-17 12:48 -------
Subject: Re:  ICE with -fwhopr/-flto when using strlen and
        strcat without previous declaration

> seems like streamer bug. We should not ever see any comdat groups here.
We stream the node twice for some reason (I can see this happening for multiple
units since
we do share builtin decls but not for single unit) and double translation of 
comdat_group breaks.
Have patch to avoid this, but wonder from what the double streaming comes in
this unit..

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at gcc dot gnu dot org]

------- Comment #4 from hubicka at gcc dot gnu dot org  2010-09-17 13:13 -------
OK, the problem is that we stream two cgraph nodes.  One for strlen function
and other for __bulitin_strlen.  Decl of __bulitin_strlen have same asm name as
strlen:
(gdb) p debug_tree (node->decl)
 <function_decl 0x7ffff7f40000 strlen
    type <function_type 0x7ffff7f3db28
        type <integer_type 0x7ffff7ed0690 long unsigned int public unsigned DI
            size <integer_cst 0x7ffff7ebc7d0 constant 64>
            unit size <integer_cst 0x7ffff7ebc7f8 constant 8>
            align 64 symtab 0 alias set 4 canonical type 0x7ffff7ed0690
precision 64 min <integer_cst 0x7ffff7ebc820 0> max <integer_cst 0x7ffff7ebc7a8
18446744073709551615>>
        QI
        size <integer_cst 0x7ffff7ebc4d8 constant 8>
        unit size <integer_cst 0x7ffff7ebc500 constant 1>
        align 8 symtab 0 alias set -1 canonical type 0x7ffff7ee8888
        attributes <tree_list 0x7ffff7f3ac58
            purpose <identifier_node 0x7ffff7ecfc30 nonnull>>
        arg-types <tree_list 0x7ffff7ee6640 value <pointer_type 0x7ffff7ee3dc8>
            chain <tree_list 0x7ffff7ebceb0 value <void_type 0x7ffff7ed0e70
void>>>
        pointer_to_this <pointer_type 0x7ffff5aebb28>>
    addressable used nothrow public external built-in decl_2 decl_5 decl_6 QI
file <built-in> line 0 col 0
    align 8 built-in BUILT_IN_NORMAL:BUILT_IN_STRLEN attributes <tree_list
0x7ffff7f3acf8> chain <function_decl 0x7ffff7f40100 __builtin_strncasecmp>>
$6 = void
(gdb) c
Continuing.

Breakpoint 1, lto_output_node (set=0x7ffff7f98c00, vset=0x7ffff7f98c20) at
../../gcc/lto-cgraph.c:416
416       boundary_p = !cgraph_node_in_set_p (node, set);
(gdb) c
Continuing.

Breakpoint 1, lto_output_node (set=0x7ffff7f98c00, vset=0x7ffff7f98c20) at
../../gcc/lto-cgraph.c:416
416       boundary_p = !cgraph_node_in_set_p (node, set);
(gdb) p debug_tree (node->decl)
 <function_decl 0x7ffff7f3ef00 __builtin_strlen
    type <function_type 0x7ffff7f3db28
        type <integer_type 0x7ffff7ed0690 long unsigned int public unsigned DI
            size <integer_cst 0x7ffff7ebc7d0 constant 64>
            unit size <integer_cst 0x7ffff7ebc7f8 constant 8>
            align 64 symtab 0 alias set 4 canonical type 0x7ffff7ed0690
precision 64 min <integer_cst 0x7ffff7ebc820 0> max <integer_cst 0x7ffff7ebc7a8
18446744073709551615>>
        QI
        size <integer_cst 0x7ffff7ebc4d8 constant 8>
        unit size <integer_cst 0x7ffff7ebc500 constant 1>
        align 8 symtab 0 alias set -1 canonical type 0x7ffff7ee8888
        attributes <tree_list 0x7ffff7f3ac58
            purpose <identifier_node 0x7ffff7ecfc30 nonnull>>
        arg-types <tree_list 0x7ffff7ee6640 value <pointer_type 0x7ffff7ee3dc8>
            chain <tree_list 0x7ffff7ebceb0 value <void_type 0x7ffff7ed0e70
void>>>
        pointer_to_this <pointer_type 0x7ffff5aebb28>>
    nothrow public external built-in decl_6 QI file <built-in> line 0 col 0
    align 8 built-in BUILT_IN_NORMAL:BUILT_IN_STRLEN attributes <tree_list
0x7ffff7f3ac80> chain <function_decl 0x7ffff7f40000 strlen>>

and when reading back those two decls identify into single and thus also the
cgraph nodes.

Richi: is that intended behaviour?


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[rguenther at suse dot de]

------- Comment #5 from rguenther at suse dot de  2010-09-17 13:26 -------
Subject: Re:  ICE with -fwhopr/-flto when using strlen and
 strcat without previous declaration

On Fri, 17 Sep 2010, hubicka at gcc dot gnu dot org wrote:

> 
> 
> ------- Comment #4 from hubicka at gcc dot gnu dot org  2010-09-17 13:13 -------
> OK, the problem is that we stream two cgraph nodes.  One for strlen function
> and other for __bulitin_strlen.  Decl of __bulitin_strlen have same asm name as
> strlen:
> (gdb) p debug_tree (node->decl)
>  <function_decl 0x7ffff7f40000 strlen
>     type <function_type 0x7ffff7f3db28
>         type <integer_type 0x7ffff7ed0690 long unsigned int public unsigned DI
>             size <integer_cst 0x7ffff7ebc7d0 constant 64>
>             unit size <integer_cst 0x7ffff7ebc7f8 constant 8>
>             align 64 symtab 0 alias set 4 canonical type 0x7ffff7ed0690
> precision 64 min <integer_cst 0x7ffff7ebc820 0> max <integer_cst 0x7ffff7ebc7a8
> 18446744073709551615>>
>         QI
>         size <integer_cst 0x7ffff7ebc4d8 constant 8>
>         unit size <integer_cst 0x7ffff7ebc500 constant 1>
>         align 8 symtab 0 alias set -1 canonical type 0x7ffff7ee8888
>         attributes <tree_list 0x7ffff7f3ac58
>             purpose <identifier_node 0x7ffff7ecfc30 nonnull>>
>         arg-types <tree_list 0x7ffff7ee6640 value <pointer_type 0x7ffff7ee3dc8>
>             chain <tree_list 0x7ffff7ebceb0 value <void_type 0x7ffff7ed0e70
> void>>>
>         pointer_to_this <pointer_type 0x7ffff5aebb28>>
>     addressable used nothrow public external built-in decl_2 decl_5 decl_6 QI
> file <built-in> line 0 col 0
>     align 8 built-in BUILT_IN_NORMAL:BUILT_IN_STRLEN attributes <tree_list
> 0x7ffff7f3acf8> chain <function_decl 0x7ffff7f40100 __builtin_strncasecmp>>
> $6 = void
> (gdb) c
> Continuing.
> 
> Breakpoint 1, lto_output_node (set=0x7ffff7f98c00, vset=0x7ffff7f98c20) at
> ../../gcc/lto-cgraph.c:416
> 416       boundary_p = !cgraph_node_in_set_p (node, set);
> (gdb) c
> Continuing.
> 
> Breakpoint 1, lto_output_node (set=0x7ffff7f98c00, vset=0x7ffff7f98c20) at
> ../../gcc/lto-cgraph.c:416
> 416       boundary_p = !cgraph_node_in_set_p (node, set);
> (gdb) p debug_tree (node->decl)
>  <function_decl 0x7ffff7f3ef00 __builtin_strlen
>     type <function_type 0x7ffff7f3db28
>         type <integer_type 0x7ffff7ed0690 long unsigned int public unsigned DI
>             size <integer_cst 0x7ffff7ebc7d0 constant 64>
>             unit size <integer_cst 0x7ffff7ebc7f8 constant 8>
>             align 64 symtab 0 alias set 4 canonical type 0x7ffff7ed0690
> precision 64 min <integer_cst 0x7ffff7ebc820 0> max <integer_cst 0x7ffff7ebc7a8
> 18446744073709551615>>
>         QI
>         size <integer_cst 0x7ffff7ebc4d8 constant 8>
>         unit size <integer_cst 0x7ffff7ebc500 constant 1>
>         align 8 symtab 0 alias set -1 canonical type 0x7ffff7ee8888
>         attributes <tree_list 0x7ffff7f3ac58
>             purpose <identifier_node 0x7ffff7ecfc30 nonnull>>
>         arg-types <tree_list 0x7ffff7ee6640 value <pointer_type 0x7ffff7ee3dc8>
>             chain <tree_list 0x7ffff7ebceb0 value <void_type 0x7ffff7ed0e70
> void>>>
>         pointer_to_this <pointer_type 0x7ffff5aebb28>>
>     nothrow public external built-in decl_6 QI file <built-in> line 0 col 0
>     align 8 built-in BUILT_IN_NORMAL:BUILT_IN_STRLEN attributes <tree_list
> 0x7ffff7f3ac80> chain <function_decl 0x7ffff7f40000 strlen>>
> 
> and when reading back those two decls identify into single and thus also the
> cgraph nodes.
> 
> Richi: is that intended behaviour?

No, we shouldn't stream them at all.  Why do we even bother?  And yes,
same cgraph node is intended (one is an alias for the other).  Maybe
that's what we get "wrong" even in non-LTO mode?  Do we have two
different cgraph nodes for strlen vs. __builtin_strlen?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at ucw dot cz]

------- Comment #6 from hubicka at ucw dot cz  2010-09-17 13:30 -------
Subject: Re:  ICE with -fwhopr/-flto when using strlen and
        strcat without previous declaration

> > Richi: is that intended behaviour?
> 
> No, we shouldn't stream them at all.  Why do we even bother?  And yes,

Because we need to get stuff in sync to be able to read them correctly :)

> same cgraph node is intended (one is an alias for the other).  Maybe
> that's what we get "wrong" even in non-LTO mode?  Do we have two
> different cgraph nodes for strlen vs. __builtin_strlen?

Yes, we do.  It is violation of one decl rule I would say.
Probably could be declared frontend bug, why it produces two decls at first
place?

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[rguenther at suse dot de]

------- Comment #7 from rguenther at suse dot de  2010-09-17 13:43 -------
Subject: Re:  ICE with -fwhopr/-flto when using strlen and
 strcat without previous declaration

On Fri, 17 Sep 2010, hubicka at ucw dot cz wrote:

> 
> 
> ------- Comment #6 from hubicka at ucw dot cz  2010-09-17 13:30 -------
> Subject: Re:  ICE with -fwhopr/-flto when using strlen and
>         strcat without previous declaration
> 
> > > Richi: is that intended behaviour?
> > 
> > No, we shouldn't stream them at all.  Why do we even bother?  And yes,
> 
> Because we need to get stuff in sync to be able to read them correctly :)

Hm?  We explicitly don't stream built-in decls, did you remove that?

You simply get the available builtins from function-code from
input-node.

> > same cgraph node is intended (one is an alias for the other).  Maybe
> > that's what we get "wrong" even in non-LTO mode?  Do we have two
> > different cgraph nodes for strlen vs. __builtin_strlen?
> 
> Yes, we do.  It is violation of one decl rule I would say.
> Probably could be declared frontend bug, why it produces two decls at first
> place?

Well, one is an alias for the other and we do have decls for aliases.

I'd say what probably happens is that at output time the decls
look different (after all they miss a prototype) and we fail to
carry over that state properly.

> 
> Honza
> 
> 
> 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at gcc dot gnu dot org]

------- Comment #8 from hubicka at gcc dot gnu dot org  2010-09-19 21:49 -------
Subject: Bug 44246

Author: hubicka
Date: Sun Sep 19 21:49:28 2010
New Revision: 164425

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164425
Log:

        PR lto/44246
        * lto-cgraph.c (input_cgraph_1, input_varpool_1): Avoid
        processing same node twice.
        * gcc.c-torture/compile/pr44246.c:New file.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr44246.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lto-cgraph.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246

[Bug lto/44246] ICE with -fwhopr/-flto when using strlen and strcat without previous declaration

[hubicka at gcc dot gnu dot org]

------- Comment #9 from hubicka at gcc dot gnu dot org  2010-09-19 21:57 -------
Fixed.


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44246