public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jvdelisle at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/45793] [4.6 Regressions]  Numerous test-suite failures
Date: Sun, 26 Sep 2010 10:42:00 -0000	[thread overview]
Message-ID: <20100926104200.UdtvLE2qGtfwBFKkA0SFPnONhdjXVD5dSX0agG37daM@z> (raw)
In-Reply-To: <bug-45793-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45793

--- Comment #5 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2010-09-26 03:39:17 UTC ---
This patch untested gets rid of the valgrind error I was seeing.

Index: module.c
===================================================================
--- module.c    (revision 164621)
+++ module.c    (working copy)
@@ -5313,7 +5313,6 @@ create_int_parameter_array (const char *name, int
 {
   gfc_symtree *tmp_symtree;
   gfc_symbol *sym;
-  gfc_expr *e;

   tmp_symtree = gfc_find_symtree (gfc_current_ns->sym_root, name);
   if (tmp_symtree != NULL)
@@ -5342,8 +5341,8 @@ create_int_parameter_array (const char *name, int
   sym->as->upper[0] = gfc_get_int_expr (gfc_default_integer_kind, NULL, size); 

   sym->value = value;
-  e->shape = gfc_get_shape (1);
-  mpz_init_set_ui (e->shape[0], size);
+  sym->value->shape = gfc_get_shape (1);
+  mpz_init_set_ui (sym->value->shape[0], size);
 }

Can someone familiar with module.c see if this makes sense for the intended
purpose.  I will start regression testing.


  parent reply	other threads:[~2010-09-26  3:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-25 19:57 [Bug fortran/45793] New: " jvdelisle at gcc dot gnu.org
2010-09-25 22:43 ` [Bug fortran/45793] " jvdelisle at gcc dot gnu.org
2010-09-26  2:11 ` jvdelisle at gcc dot gnu.org
2010-09-26  7:43 ` kkojima at gcc dot gnu.org
2010-09-26 10:27 ` jvdelisle at gcc dot gnu.org
2010-09-26 10:42 ` jvdelisle at gcc dot gnu.org [this message]
2010-09-26 12:31 ` jvdelisle at gcc dot gnu.org
2010-09-26 13:22 ` kkojima at gcc dot gnu.org
2010-09-26 13:44 ` burnus at gcc dot gnu.org
2010-09-26 15:17 ` jvdelisle at gcc dot gnu.org
2010-09-26 16:43 ` jvdelisle at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100926104200.UdtvLE2qGtfwBFKkA0SFPnONhdjXVD5dSX0agG37daM@z \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).