From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-332101-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4872 invoked by alias); 26 Sep 2010 07:49:41 -0000
Received: (qmail 4863 invoked by uid 22791); 26 Sep 2010 07:49:41 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,MISSING_MID
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Sep 2010 07:49:35 +0000
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/45793] [4.6 Regressions]  Numerous test-suite failures
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: burnus at gcc dot gnu.org
X-Bugzilla-Status: REOPENED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: CC
In-Reply-To: <bug-45793-4@http.gcc.gnu.org/bugzilla/>
References: <bug-45793-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Sun, 26 Sep 2010 13:44:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-09/txt/msg02825.txt.bz2
Message-ID: <20100926134400.-1yRtJVr28CWW5PJYjvd3w-uAVOK3sHTzOp7ME4nRxg@z>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45793

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-09-26 07:49:34 UTC ---
(In reply to comment #3)
> When building f951, there was a warning
> 
> ../trunk/gcc/fortran/module.c: In function 'create_int_parameter_array':
> ../trunk/gcc/fortran/module.c:5346: warning: 'e' may be used uninitialized in
> this function

I have never quite understood when -Werror is effective and when not!


(In reply to comment #5)
> This patch untested gets rid of the valgrind error I was seeing.

> @@ -5342,8 +5341,8 @@ create_int_parameter_array (const char *name, int
>    sym->as->upper[0] = gfc_get_int_expr (gfc_default_integer_kind, NULL, size); 
> 
>    sym->value = value;
> -  e->shape = gfc_get_shape (1);
> -  mpz_init_set_ui (e->shape[0], size);
> +  sym->value->shape = gfc_get_shape (1);
> +  mpz_init_set_ui (sym->value->shape[0], size);
>  }

The patch is obvious and OK for committal. Thanks for fixing this stupid
copy-and-paste bug of mine!