public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "abel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584 Date: Tue, 28 Sep 2010 16:20:00 -0000 [thread overview] Message-ID: <20100928162000.jOko1UMbYusUMbQrEPQXxOtIgpAAlEbqGPQv_fE1k6w@z> (raw) In-Reply-To: <bug-45570-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570 Andrey Belevantsev <abel at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2010.09.28 13:23:13 date| | Ever Confirmed|0 |1 --- Comment #3 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-09-28 13:23:13 UTC --- Confirmed. It is hidden now by 163998. The problem is simple, yet again when inserting a bookkeeping code together with pipelining outer loops, we can see the situation when we need to devise a positive seqno for a bookkeeping insn, yet we can't do that by examining its neighbours. Fixed by relaxing the failing assert so that the first patch for PR40101 would provide an arbitrary positive value. diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c index 853205d..8a88c55 100644 --- a/gcc/sel-sched-ir.c +++ b/gcc/sel-sched-ir.c @@ -4580,8 +4580,12 @@ cfg_preds_1 (basic_block bb, insn_t **preds, int *n, int *size) basic_block pred_bb = e->src; insn_t bb_end = BB_END (pred_bb); - /* ??? This code is not supposed to walk out of a region. */ - gcc_assert (in_current_region_p (pred_bb)); + if (!in_current_region_p (pred_bb)) + { + gcc_assert (flag_sel_sched_pipelining_outer_loops + && current_loop_nest); + continue; + } if (sel_bb_empty_p (pred_bb)) cfg_preds_1 (pred_bb, preds, n, size); @@ -4594,7 +4598,9 @@ cfg_preds_1 (basic_block bb, insn_t **preds, int *n, int *size) } } - gcc_assert (*n != 0); + gcc_assert (*n != 0 + || (flag_sel_sched_pipelining_outer_loops + && current_loop_nest)); } /* Find all predecessors of BB and record them in PREDS and their number
next parent reply other threads:[~2010-09-28 13:23 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-45570-4@http.gcc.gnu.org/bugzilla/> 2010-09-28 16:20 ` abel at gcc dot gnu.org [this message] 2010-09-30 14:14 ` rguenth at gcc dot gnu.org 2010-10-14 7:57 ` abel at gcc dot gnu.org 2010-10-14 14:42 ` abel at gcc dot gnu.org 2011-04-07 6:50 ` abel at gcc dot gnu.org 2010-09-06 23:53 [Bug rtl-optimization/45570] New: " zsojka at seznam dot cz 2010-09-06 23:55 ` [Bug rtl-optimization/45570] " zsojka at seznam dot cz 2010-09-07 8:42 ` rguenth at gcc dot gnu dot org 2010-09-22 15:57 ` abel at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100928162000.jOko1UMbYusUMbQrEPQXxOtIgpAAlEbqGPQv_fE1k6w@z \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).