public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/44554] Stack space after sigsetjmp is reused
       [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
@ 2010-09-28 14:57 ` christian.eggers at kathrein dot de
  2010-09-28 16:26 ` bernds at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 13+ messages in thread
From: christian.eggers at kathrein dot de @ 2010-09-28 14:57 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554

--- Comment #15 from Christian Eggers <christian.eggers at kathrein dot de> 2010-09-28 11:01:05 UTC ---
(In reply to comment #14)
> Created attachment 21901 [details]
> A patch that should fix it
> 
> Please verify whether this fixes it.

Hasn't it already been fixed in comment #11? My plan was to wait until release
of gcc-4.4.5 and test then. Are additional changes required to fix this bug?


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
       [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
  2010-09-28 14:57 ` [Bug middle-end/44554] Stack space after sigsetjmp is reused christian.eggers at kathrein dot de
@ 2010-09-28 16:26 ` bernds at gcc dot gnu.org
  2011-01-28 10:36 ` ibolton at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 13+ messages in thread
From: bernds at gcc dot gnu.org @ 2010-09-28 16:26 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554

Bernd Schmidt <bernds at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bernds at gcc dot gnu.org

--- Comment #16 from Bernd Schmidt <bernds at gcc dot gnu.org> 2010-09-28 14:00:30 UTC ---
Argh, wrong PR.  I wanted 45445.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
       [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
  2010-09-28 14:57 ` [Bug middle-end/44554] Stack space after sigsetjmp is reused christian.eggers at kathrein dot de
  2010-09-28 16:26 ` bernds at gcc dot gnu.org
@ 2011-01-28 10:36 ` ibolton at gcc dot gnu.org
  2011-01-28 10:57 ` christian.eggers at kathrein dot de
  2011-01-28 12:28 ` ibolton at gcc dot gnu.org
  4 siblings, 0 replies; 13+ messages in thread
From: ibolton at gcc dot gnu.org @ 2011-01-28 10:36 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554

Ian Bolton <ibolton at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2011.01.28 10:03:46
     Ever Confirmed|0                           |1

--- Comment #17 from Ian Bolton <ibolton at gcc dot gnu.org> 2011-01-28 10:03:46 UTC ---
(In reply to comment #15)
> (In reply to comment #14)
> > Created attachment 21901 [details]
> > A patch that should fix it
> > 
> > Please verify whether this fixes it.
> 
> Hasn't it already been fixed in comment #11? My plan was to wait until release
> of gcc-4.4.5 and test then. Are additional changes required to fix this bug?

gcc 4.4.5 was released in October.  Please can you confirm if this is now
fixed.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
       [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2011-01-28 10:36 ` ibolton at gcc dot gnu.org
@ 2011-01-28 10:57 ` christian.eggers at kathrein dot de
  2011-01-28 12:28 ` ibolton at gcc dot gnu.org
  4 siblings, 0 replies; 13+ messages in thread
From: christian.eggers at kathrein dot de @ 2011-01-28 10:57 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554

Christian Eggers <christian.eggers at kathrein dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Christian Eggers <christian.eggers at kathrein dot de> 2011-01-28 10:29:12 UTC ---
(In reply to comment #17)
> gcc 4.4.5 was released in October.  Please can you confirm if this is now
> fixed.

I think THIS bug is fixed in 4.4.5. Unfortunately I've still problems with
wrong computations as already mentioned in comment #8. But this would either be
related to PR40386 or it's another bug.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
       [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2011-01-28 10:57 ` christian.eggers at kathrein dot de
@ 2011-01-28 12:28 ` ibolton at gcc dot gnu.org
  4 siblings, 0 replies; 13+ messages in thread
From: ibolton at gcc dot gnu.org @ 2011-01-28 12:28 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554

--- Comment #19 from Ian Bolton <ibolton at gcc dot gnu.org> 2011-01-28 11:30:50 UTC ---
(In reply to comment #18)
> (In reply to comment #17)
> > gcc 4.4.5 was released in October.  Please can you confirm if this is now
> > fixed.
> 
> I think THIS bug is fixed in 4.4.5. Unfortunately I've still problems with
> wrong computations as already mentioned in comment #8. But this would either be
> related to PR40386 or it's another bug.

I think it's best to raise a new bug, and CC Vladimir Makarov and Jeff Law.  It
will help to hear about the specific issues you are still seeing within that
bug report.


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
                   ` (6 preceding siblings ...)
  2010-09-09 13:56 ` vmakarov at gcc dot gnu dot org
@ 2010-09-09 13:59 ` vmakarov at gcc dot gnu dot org
  7 siblings, 0 replies; 13+ messages in thread
From: vmakarov at gcc dot gnu dot org @ 2010-09-09 13:59 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #13 from vmakarov at gcc dot gnu dot org  2010-09-09 13:58 -------
Subject: Bug 44554

Author: vmakarov
Date: Thu Sep  9 13:58:24 2010
New Revision: 164107

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164107
Log:
2010-09-09  Vladimir Makarov  <vmakarov@redhat.com>

        PR middle-end/44554
        * ira.c (ira): Switch off sharing spill slots if setjmp is called.


Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/ira.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
                   ` (5 preceding siblings ...)
  2010-09-09 13:54 ` vmakarov at gcc dot gnu dot org
@ 2010-09-09 13:56 ` vmakarov at gcc dot gnu dot org
  2010-09-09 13:59 ` vmakarov at gcc dot gnu dot org
  7 siblings, 0 replies; 13+ messages in thread
From: vmakarov at gcc dot gnu dot org @ 2010-09-09 13:56 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #12 from vmakarov at gcc dot gnu dot org  2010-09-09 13:56 -------
Subject: Bug 44554

Author: vmakarov
Date: Thu Sep  9 13:55:35 2010
New Revision: 164105

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164105
Log:
2010-09-09  Vladimir Makarov  <vmakarov@redhat.com>

        PR middle-end/44554
        * ira.c (ira): Switch off sharing spill slots if setjmp is called.


Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/ira.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
                   ` (4 preceding siblings ...)
  2010-09-09  6:18 ` christian dot eggers at kathrein dot de
@ 2010-09-09 13:54 ` vmakarov at gcc dot gnu dot org
  2010-09-09 13:56 ` vmakarov at gcc dot gnu dot org
  2010-09-09 13:59 ` vmakarov at gcc dot gnu dot org
  7 siblings, 0 replies; 13+ messages in thread
From: vmakarov at gcc dot gnu dot org @ 2010-09-09 13:54 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #11 from vmakarov at gcc dot gnu dot org  2010-09-09 13:54 -------
Subject: Bug 44554

Author: vmakarov
Date: Thu Sep  9 13:53:32 2010
New Revision: 164102

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=164102
Log:
2010-09-09  Vladimir Makarov  <vmakarov@redhat.com>

        PR middle-end/44554
        * ira.c (ira): Switch off sharing spill slots if setjmp is called.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ira.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
                   ` (3 preceding siblings ...)
  2010-09-08 20:06 ` vmakarov at redhat dot com
@ 2010-09-09  6:18 ` christian dot eggers at kathrein dot de
  2010-09-09 13:54 ` vmakarov at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: christian dot eggers at kathrein dot de @ 2010-09-09  6:18 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from christian dot eggers at kathrein dot de  2010-09-09 06:17 -------
(In reply to comment #9)
> I've submitted a patch solving PR40386.  So now we can solve this problem by
> preventing slot sharing when setjmp is used.
> 
> I'll send a patch soon.

Could you please send me both patches? I would like to test whether both
problems are solved (at least for me).

regards
Christian


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
                   ` (2 preceding siblings ...)
  2010-09-08 11:12 ` christian dot eggers at kathrein dot de
@ 2010-09-08 20:06 ` vmakarov at redhat dot com
  2010-09-09  6:18 ` christian dot eggers at kathrein dot de
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: vmakarov at redhat dot com @ 2010-09-08 20:06 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from vmakarov at redhat dot com  2010-09-08 20:06 -------
(In reply to comment #8)
> (In reply to comment #7)
> > Is this still a bug then?  Should ira-share-spill-slots be automatically
> > disabled for the caller function when a callee function can return twice?
> > 
> I've never tested with gcc-4.5.x, but in 4.4.x the problem is still present. 
> 
> Unfortunately -fno-ira-share-spill-slots seems to introduce another bug which
> leads to wrong computations (nearly at the same code position where I had the
> problems mentioned is this report). 
> 
> At this moment I can not provide a detailed report for this problem, but
> perhaps it's the same as http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40386.
> 

I've submitted a patch solving PR40386.  So now we can solve this problem by
preventing slot sharing when setjmp is used.

I'll send a patch soon.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
  2010-06-17 18:56 ` [Bug middle-end/44554] " ceggers at gmx dot de
  2010-09-08  8:49 ` ibolton at gcc dot gnu dot org
@ 2010-09-08 11:12 ` christian dot eggers at kathrein dot de
  2010-09-08 20:06 ` vmakarov at redhat dot com
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: christian dot eggers at kathrein dot de @ 2010-09-08 11:12 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from christian dot eggers at kathrein dot de  2010-09-08 11:12 -------
(In reply to comment #7)
> Is this still a bug then?  Should ira-share-spill-slots be automatically
> disabled for the caller function when a callee function can return twice?
> 
I've never tested with gcc-4.5.x, but in 4.4.x the problem is still present. 

Unfortunately -fno-ira-share-spill-slots seems to introduce another bug which
leads to wrong computations (nearly at the same code position where I had the
problems mentioned is this report). 

At this moment I can not provide a detailed report for this problem, but
perhaps it's the same as http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40386.


-- 

christian dot eggers at kathrein dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |UNCONFIRMED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
  2010-06-17 18:56 ` [Bug middle-end/44554] " ceggers at gmx dot de
@ 2010-09-08  8:49 ` ibolton at gcc dot gnu dot org
  2010-09-08 11:12 ` christian dot eggers at kathrein dot de
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: ibolton at gcc dot gnu dot org @ 2010-09-08  8:49 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from ibolton at gcc dot gnu dot org  2010-09-08 08:49 -------
(In reply to comment #6)
> (In reply to comment #5)
> > Do we need to act as if
> > -fno-ira-share-spill-slots
> > is set in cfun->calls_setjmp functions?
> 
> At least in my case "-Os -fno-ira-share-spill-slots" seems to solve the
> problem. This applies also to the original (not stripped down) version of the
> code.
> 

Is this still a bug then?  Should ira-share-spill-slots be automatically
disabled for the caller function when a callee function can return twice?


-- 

ibolton at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Bug middle-end/44554] Stack space after sigsetjmp is reused
  2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
@ 2010-06-17 18:56 ` ceggers at gmx dot de
  2010-09-08  8:49 ` ibolton at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 13+ messages in thread
From: ceggers at gmx dot de @ 2010-06-17 18:56 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from ceggers at gmx dot de  2010-06-17 18:56 -------
(In reply to comment #5)
> Do we need to act as if
> -fno-ira-share-spill-slots
> is set in cfun->calls_setjmp functions?

At least in my case "-Os -fno-ira-share-spill-slots" seems to solve the
problem. This applies also to the original (not stripped down) version of the
code.


-- 

ceggers at gmx dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ceggers at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44554


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2011-01-28 11:31 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-44554-4@http.gcc.gnu.org/bugzilla/>
2010-09-28 14:57 ` [Bug middle-end/44554] Stack space after sigsetjmp is reused christian.eggers at kathrein dot de
2010-09-28 16:26 ` bernds at gcc dot gnu.org
2011-01-28 10:36 ` ibolton at gcc dot gnu.org
2011-01-28 10:57 ` christian.eggers at kathrein dot de
2011-01-28 12:28 ` ibolton at gcc dot gnu.org
2010-06-16  7:02 [Bug c/44554] New: " christian dot eggers at kathrein dot de
2010-06-17 18:56 ` [Bug middle-end/44554] " ceggers at gmx dot de
2010-09-08  8:49 ` ibolton at gcc dot gnu dot org
2010-09-08 11:12 ` christian dot eggers at kathrein dot de
2010-09-08 20:06 ` vmakarov at redhat dot com
2010-09-09  6:18 ` christian dot eggers at kathrein dot de
2010-09-09 13:54 ` vmakarov at gcc dot gnu dot org
2010-09-09 13:56 ` vmakarov at gcc dot gnu dot org
2010-09-09 13:59 ` vmakarov at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).