public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/45781] [4.6 Regression] GCC incorrectly puts function in .text.unlikely Date: Thu, 30 Sep 2010 19:24:00 -0000 [thread overview] Message-ID: <20100930192400.6xH42Cgw81OvcCZcloMN5_Yh3yFpJ4Np1YAvvKECFuU@z> (raw) In-Reply-To: <bug-45781-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45781 --- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> 2010-09-30 16:44:17 UTC --- IA-64 seems to be fine with unlikely section at least at our periodic tester setup, otherwise SPEC2000 FDO testing would break. So it might be specific for ia64 HP-UX and in that case indeed correct fix is to simply define cold and hot sections to be .text sections (or fix it at binutils side) for HP-UX IA-64 (and possibly PA target too). What I am confused about is how partial inlining affect placement of init_target_chars. If it was because function got partially inlined, the wrong call would be named init_target_chars.part.XXX and it is not. It is possible that partial inlining affect profile in some of the callers and then it might be some bug in profile updating, so I would like to see a testcase. x.c in the PR is truncated and when i compile builtins.c from my GCC tree (x86-64) I do not get init_target_chars in unlikely function. For some funny reason I however get gimple_rewrite_call_expr. All uses of it are preceeded by very many exists from the function that makes them appear cold. Funny but probably not harmful. Honza
next prev parent reply other threads:[~2010-09-30 16:44 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-24 18:42 [Bug tree-optimization/45781] New: " sje at cup dot hp.com 2010-09-24 19:13 ` [Bug tree-optimization/45781] [4.6 Regression] " rguenth at gcc dot gnu.org 2010-09-30 11:12 ` rguenth at gcc dot gnu.org 2010-09-30 19:24 ` hubicka at gcc dot gnu.org [this message] 2010-09-30 20:06 ` sje at cup dot hp.com [not found] ` <20100930174146.0DA51F0350@atrey.karlin.mff.cuni.cz> 2010-09-30 20:25 ` Jan Hubicka 2010-09-30 20:38 ` hubicka at ucw dot cz 2010-09-30 21:01 ` hubicka at gcc dot gnu.org 2010-10-14 21:28 ` hubicka at gcc dot gnu.org 2010-11-04 11:49 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100930192400.6xH42Cgw81OvcCZcloMN5_Yh3yFpJ4Np1YAvvKECFuU@z \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).