public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "nicola at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug objc/45925] New objc test failures
Date: Thu, 07 Oct 2010 09:09:00 -0000	[thread overview]
Message-ID: <20101007090900.xmmPPRxAtd77zvqHLWTHotAR-D_DGtaxScopFsIx8I4@z> (raw)
In-Reply-To: <bug-45925-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45925

Nicola Pero <nicola at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.10.07 09:08:42
         AssignedTo|unassigned at gcc dot       |nicola at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #4 from Nicola Pero <nicola at gcc dot gnu.org> 2010-10-07 09:08:42 UTC ---
Actually, at a closer look it's a bug in the new code.  This fixes it --

Index: objc-act.c
===================================================================
--- objc-act.c  (revision 165067)
+++ objc-act.c  (working copy)
@@ -10325,7 +10325,7 @@ objc_finish_foreach_loop (location_t location, tre
                                    (NULL_TREE, build_int_cst (NULL_TREE, 16),
NULL_TREE))));
   }
 #endif
-  t = build2 (MODIFY_EXPR, void_type_node, objc_foreach_batchsize_decl, t);
+  t = build2 (MODIFY_EXPR, void_type_node, objc_foreach_batchsize_decl,
convert (long_unsigned_type_node, t));
   SET_EXPR_LOCATION (t, location);
   append_to_statement_list (t, &BIND_EXPR_BODY (bind));

@@ -10498,7 +10498,7 @@ objc_finish_foreach_loop (location_t location, tre
                                    (NULL_TREE, build_int_cst (NULL_TREE, 16),
NULL_TREE))));
   }
 #endif
-  t = build2 (MODIFY_EXPR, void_type_node, objc_foreach_batchsize_decl, t);
+  t = build2 (MODIFY_EXPR, void_type_node, objc_foreach_batchsize_decl,
convert (long_unsigned_type_node, t));
   SET_EXPR_LOCATION (t, location);
   append_to_statement_list (t, &BIND_EXPR_BODY (next_batch_bind));

We'll apply once approved.

Thanks


  parent reply	other threads:[~2010-10-07  9:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  0:09 [Bug objc/45925] New: " hjl.tools at gmail dot com
2010-10-07  8:18 ` [Bug objc/45925] " nicola at gcc dot gnu.org
2010-10-07  8:36 ` jakub at gcc dot gnu.org
2010-10-07  8:38 ` nicola at gcc dot gnu.org
2010-10-07  9:09 ` nicola at gcc dot gnu.org [this message]
2010-10-07 18:38 ` nicola at gcc dot gnu.org
2010-10-07 18:40 ` nicola at gcc dot gnu.org
2010-10-17  9:59 ` nicola at gcc dot gnu.org
2010-10-17 17:05 ` hjl.tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101007090900.xmmPPRxAtd77zvqHLWTHotAR-D_DGtaxScopFsIx8I4@z \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).