[Bug libstdc++/45990] New: 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[Bug libstdc++/45990] New: 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

           Summary: 28_regex/07_traits/char/isctype.cc XPASSes on Solaris
                    2/IRIX 6
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: stephen.webb@cybersafe.com
              Host: i386-pc-solaris2.*, sparc-sun-solaris2.*,
                    mips-sgi-irix6.5
            Target: i386-pc-solaris2.*, sparc-sun-solaris2.*,
                    mips-sgi-irix6.5
             Build: i386-pc-solaris2.*, sparc-sun-solaris2.*,
                    mips-sgi-irix6.5


The new 28_regex/07_traits/char/isctype.cc test XPASSes on at least Solaris
2/x86
and SPARC and IRIX 6.5 (as well as on cygwin, it seems from the mailing list
archives):

XPASS: 28_regex/07_traits/char/isctype.cc execution test

This is just unnecessary testsuite noise and should be avoided.

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-12 19:53:18 UTC ---
Interesting ... lookup_classname isn't implemented and just returns 0

I'll look into it or ask Stephen to check

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.10.12 19:55:39
     Ever Confirmed|0                           |1

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-12 19:55:39 UTC ---
think I see the problem

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-12 20:12:54 UTC ---
This is DR 1337
http://open-std.org/JTC1/SC22/WG21/docs/lwg-active.html#1337

Rainer, could you test this 1337 hax0r patch?

Index: include/bits/regex.h
===================================================================
--- include/bits/regex.h        (revision 165394)
+++ include/bits/regex.h        (working copy)
@@ -287,7 +287,7 @@ namespace std
       const ctype<_Ch_type>& __ctype(use_facet<
                                     ctype<_Ch_type> >(_M_locale));

-      if (__ctype.is(__c, __f))
+      if (__ctype.is(__f, __c))
        return true;

       // special case of underscore in [[:w:]]

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2010-10-13 17:20:59 UTC ---
Sure: with this patch, the test aborts:

Assertion failed: t.isctype('e', t.lookup_classname(name,
name+sizeof(name)-1)), file
/vol/gcc/src/hg/trunk/local/libstdc++-v3/testsuite/28_regex/07_traits/char/isctype.cc,
line 41, function test01
Abort

    Rainer

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-13 22:52:28 UTC ---
Author: redi
Date: Wed Oct 13 22:52:25 2010
New Revision: 165438

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=165438
Log:
    PR libstdc++/45990
    * include/bits/regex.h (regex_traits::isctype): DR 1337.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/regex.h

[Bug libstdc++/45990] 28_regex/07_traits/char/isctype.cc XPASSes on Solaris 2/IRIX 6

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45990

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-10-14 08:23:39 UTC ---
Thanks, Rainer.
This should xfail now, please reopen if not.