[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.09.28 13:23:13
               date|                            |
     Ever Confirmed|0                           |1

--- Comment #3 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-09-28 13:23:13 UTC ---
Confirmed.  It is hidden now by 163998.
The problem is simple, yet again when inserting a bookkeeping code together
with pipelining outer loops, we can see the situation when we need to devise a
positive seqno for a bookkeeping insn, yet we can't do that by examining its
neighbours.  Fixed by relaxing the failing assert so that the first patch for
PR40101 would provide an arbitrary positive value.

diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c
index 853205d..8a88c55 100644
--- a/gcc/sel-sched-ir.c
+++ b/gcc/sel-sched-ir.c
@@ -4580,8 +4580,12 @@ cfg_preds_1 (basic_block bb, insn_t **preds, int *n, int
*size)
       basic_block pred_bb = e->src;
       insn_t bb_end = BB_END (pred_bb);

-      /* ??? This code is not supposed to walk out of a region.  */
-      gcc_assert (in_current_region_p (pred_bb));
+      if (!in_current_region_p (pred_bb))
+    {
+      gcc_assert (flag_sel_sched_pipelining_outer_loops
+              && current_loop_nest);
+      continue;
+    }

       if (sel_bb_empty_p (pred_bb))
     cfg_preds_1 (pred_bb, preds, n, size);
@@ -4594,7 +4598,9 @@ cfg_preds_1 (basic_block bb, insn_t **preds, int *n, int
*size)
     }
     }

-  gcc_assert (*n != 0);
+  gcc_assert (*n != 0
+          || (flag_sel_sched_pipelining_outer_loops
+          && current_loop_nest));
 }

 /* Find all predecessors of BB and record them in PREDS and their number

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

--- Comment #4 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-10-14 07:56:50 UTC ---
Author: abel
Date: Thu Oct 14 07:56:47 2010
New Revision: 165454

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=165454
Log:
    PR rtl-optimization/45570
    * sel-sched-ir.c (cfg_preds_1): When walking out of the region, assert
    that we are pipelining outer loops.  Allow returning zero predecessors.
    * gcc.dg/pr45570.c: New test. 

Added:
    trunk/gcc/testsuite/gcc.dg/pr45570.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/sel-sched-ir.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

Andrey Belevantsev <abel at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-10-14 14:42:12 UTC ---
Fixed.

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

--- Comment #6 from Andrey Belevantsev <abel at gcc dot gnu.org> 2011-04-07 06:50:12 UTC ---
Author: abel
Date: Thu Apr  7 06:50:08 2011
New Revision: 172077

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=172077
Log:
        Backport from mainline
        2010-10-14  Andrey Belevantsev  <abel@ispras.ru>

        PR rtl-optimization/45570
        * sel-sched-ir.c (cfg_preds_1): When walking out of the region,
        assert that we are pipelining outer loops.  Allow returning
        zero predecessors.


Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr45570.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/sel-sched-ir.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[abel at gcc dot gnu dot org]

------- Comment #2 from abel at gcc dot gnu dot org  2010-09-22 15:57 -------
Neither of these option combinations fail for me on x86-64 with a recent trunk
(164506).  We will investigate further with the given trunk revisions.


-- 

abel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abel at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570

[Bug rtl-optimization/45570] [4.6 Regression] ICE: in cfg_preds_1, at sel-sched-ir.c:4584

[zsojka at seznam dot cz]

------- Comment #1 from zsojka at seznam dot cz  2010-09-06 23:54 -------
Created an attachment (id=21721)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=21721&action=view)
reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45570