[Bug fortran/46079] New: ABI for empty stop statement broken

[Bug fortran/46079] New: ABI for empty stop statement broken

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

           Summary: ABI for empty stop statement broken
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jvdelisle@gcc.gnu.org


Prior to 4.6 a an empty STOP is translated into:

_gfortran_stop_numeric (-1);

The runtime looks for -1 as a signal for an empty STOP and just exist quietly.

However, this statement, if run inadvertently with the 4.6 library will not
exit quietly and will emit "STOP -1" with a -1 exit code. A -1 is a valid STOP
code with later Fortran standards.  I will post a proposed patch.

[Bug fortran/46079] ABI for empty stop statement broken

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

--- Comment #1 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2010-10-19 02:46:16 UTC ---
Patch submitted:

http://gcc.gnu.org/ml/fortran/2010-10/msg00193.html

[Bug fortran/46079] [4.6 Regression] ABI for empty stop statement broken

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
   Target Milestone|---                         |4.6.0
            Summary|ABI for empty stop          |[4.6 Regression] ABI for
                   |statement broken            |empty stop statement broken

[Bug fortran/46079] [4.6 Regression] ABI for empty stop statement broken

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.10.19 13:06:42
         AssignedTo|unassigned at gcc dot       |jvdelisle at gcc dot
                   |gnu.org                     |gnu.org
     Ever Confirmed|0                           |1

[Bug fortran/46079] [4.6 Regression] ABI for empty stop statement broken

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |jakub at gcc dot gnu.org

[Bug fortran/46079] [4.6 Regression] ABI for empty stop statement broken

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

--- Comment #2 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2010-10-21 00:45:19 UTC ---
Author: jvdelisle
Date: Thu Oct 21 00:45:15 2010
New Revision: 165746

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=165746
Log:
2010-10-20  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

    PR libgfortran/46079
    * runtime/stop.c (stop_numeric_f08): New function.
    (stop_numeric): Restore    to previous behavior.
    * gfortran.map: Add symbol _gfortran_stop_numeric_f08.

2010-10-20  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

    PR fortran/46079
    * trans_stmt.c (gfc_trans_stop): Fix whitespace.  Build a call to new
    F08 numeric stop function.
    * trans.h: Add declaration for gfor_fndecl_stop_numeric_f08.
    * trans-decl.c (gfc_build_builtin_function_decls): Build declaration
    for stop_numeric_f08.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-stmt.c
    trunk/gcc/fortran/trans.h
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/gfortran.map
    trunk/libgfortran/runtime/stop.c

[Bug fortran/46079] [4.6 Regression] ABI for empty stop statement broken

[jvdelisle at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46079

Jerry DeLisle <jvdelisle at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> 2010-10-21 00:48:25 UTC ---
Fixed on trunk.