[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[nicola at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

Nicola Pero <nicola at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |nicola at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #8 from Nicola Pero <nicola at gcc dot gnu.org> 2010-10-24 02:56:01 UTC ---
I just committed to trunk (will be 4.6.0) the last part of the implementation.

Testcases are included.

Thanks

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[dominiq at lps dot ens dot fr]

------- Comment #7 from dominiq at lps dot ens dot fr  2008-09-19 18:32 -------
Although I know this is not the right way to fix pr34310 I have done the
following change to /usr/include/objc/Protocol.h:

--- /usr/include/objc/Protocol.h-orig   2008-09-19 17:16:42.000000000 +0200
+++ /usr/include/objc/Protocol.h        2008-09-19 17:19:36.000000000 +0200
@@ -43,16 +43,16 @@

 /* Obtaining attributes intrinsic to the protocol */

-- (const char *)name OBJC2_UNAVAILABLE;
+- (const char *)name; /* OBJC2_UNAVAILABLE; */

 /* Testing protocol conformance */

-- (BOOL) conformsTo: (Protocol *)aProtocolObject OBJC2_UNAVAILABLE;
+- (BOOL) conformsTo: (Protocol *)aProtocolObject; /* OBJC2_UNAVAILABLE; */

 /* Looking up information specific to a protocol */

-- (struct objc_method_description *) descriptionForInstanceMethod:(SEL)aSel
DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER;
-- (struct objc_method_description *) descriptionForClassMethod:(SEL)aSel
DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER;
+- (struct objc_method_description *) descriptionForInstanceMethod:(SEL)aSel;
/*  DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER; */
+- (struct objc_method_description *) descriptionForClassMethod:(SEL)aSel; /*
DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER; */

 @end

and the number of failures has gone fom:

=== objc Summary for unix ===

# of expected passes            2896
# of unexpected failures        85
# of expected failures          7
# of unresolved testcases       74
# of unsupported tests          2

to

=== objc Summary ===

# of expected passes            3047
# of unexpected failures        9
# of expected failures          7
# of unresolved testcases       2
# of unsupported tests          2

Now the failures are

FAIL: objc.dg/headers.m (test for excess errors)
...
/System/Library/Frameworks/Foundation.framework/Headers/NSString.h:345: error:
expected ';' before '__attribute__'
...
FAIL: objc.dg/no-extra-load.m (test for excess errors)
...
/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:122: error:
expected ';' before '__attribute__'
...
/System/Library/Frameworks/Foundation.framework/Headers/NSPointerFunctions.h:59:
error: stray '@' in program
...
FAIL: objc.dg/stret-2.m scan-assembler objc_msgSend_stret
FAIL: objc.dg/stret-2.m scan-assembler-not objc_msgSend[^_S]
FAIL: objc.dg/stret-2.m scan-assembler-not objc_msgSendSuper[^_]
...
FAIL: objc.dg/stubify-1.m (test for excess errors)    -|
...                                                                            
              |--> see pr37589
FAIL: objc.dg/stubify-2.m (test for excess errors)    -|
...
FAIL: objc.dg/stubify-2.m scan-rtl-dump-not jump "symbol_ref.*"objc_msgSend"":
dump file does not exist
...
FAIL: objc.dg/symtab-1.m scan-assembler
L_OBJC_SYMBOLS.*:\n\t.long\t0\n\t.long\t0\n\t.short\t2\n\t.short\t0\n\t.long\tL_OBJC_CLASS_Derived.*\n\t.long\tL_OBJC_CLASS_Base.*\n
...

I have also done similar changes to

/System/Library/Frameworks/Foundation.framework/Headers/NSArray.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSCoder.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSDictionary.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSObject.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSRunLoop.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSSet.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSString.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h-mine
/System/Library/Frameworks/Foundation.framework/Headers/NSURLHandle.h-mine

but all of them only fix objc.dg/headers.m because I have been unable to find
what to change in

/System/Library/Frameworks/Foundation.framework/Headers/NSPointerFunctions.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[pinskia at gcc dot gnu dot org]

------- Comment #6 from pinskia at gcc dot gnu dot org  2008-09-16 22:31 -------
Grrr, looks like Apple's Runtime headers in Mac OS X 10.5 have attributes on
the methods :(.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-09-16 22:30 -------
*** Bug 34310 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth at nitro dot med dot
                   |                            |uc dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[ghazi at gcc dot gnu dot org]

------- Comment #4 from ghazi at gcc dot gnu dot org  2005-11-28 03:16 -------
Andrew, any progress on this one?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-03 00:43 -------
This might be easier with the new parser, I will try to get something to submit soon.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |rejects-valid
   Last reconfirmed|2003-11-09 22:55:39         |2004-02-08 06:11:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[pinskia@physics.uc.edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098


pinskia@physics.uc.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-05-27 13:22:31
               date|                            |


------- Additional Comments From pinskia@physics.uc.edu  2003-05-27 13:22 -------
The testcase in comment one is incomplete.
Here is a complete one:
@interface SaturnDoc
- read: (void*)aStream;
@end

@implementation SaturnDoc
- read: (void*)aStream __attribute__ ((__unused__))
{ return self; }
@end

gcc still does not accept this though:
test1.m: In function `-[SaturnDoc read:]':
test1.m:6: error: parse error before "__attribute__"
test1.m:6: warning: unused parameter `aStream'



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug objc/7098] ObjC front end doesn't understand attributes on method parameters

[dhazeghi@yahoo.com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7098



------- Additional Comments From dhazeghi@yahoo.com  2003-05-26 23:20 -------
Hello,

I can confirm that this problem still appears on gcc 3.3 branch and mainline (20030524). I get:
junk.m:1: fatal error: method definition not in class context.

Dara



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.