public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mkuvyrkov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/46179] Codegen/TLS: invalid assembler syntax
Date: Tue, 26 Oct 2010 22:14:00 -0000	[thread overview]
Message-ID: <20101026221400.cuTA7Q8MDDgChiwTEijYFV-ebFRi_QCtEoCAwkWX2To@z> (raw)
In-Reply-To: <bug-46179-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46179

--- Comment #2 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> 2010-10-26 22:14:02 UTC ---
Just to check that this is not a lingering issue from backporting, do you have
the following comment in gcc/config/m68k/m68k.c ?  I fixed a very similar issue
before checking the final GCC TLS patch.

  /* Combine and, possibly, other optimizations may do good job
     converting
       (const (unspec [(symbol)]))
     into
       (const (plus (unspec [(symbol)])
                    (const_int N))).
     The problem with this is emitting @TLS or @GOT decorations.
     The decoration is emitted when processing (unspec), so the
     result would be "#symbol@TLSLE+N" instead of "#symbol+N@TLSLE".

     It seems that the easiest solution to this is to convert such
     operands to
       (const (unspec [(plus (symbol)
                             (const_int N))])).
     Note, that the top level of operand remains intact, so we don't have
     to patch up anything outside of the operand.  */


  parent reply	other threads:[~2010-10-26 22:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26  3:33 [Bug target/46179] New: " fthain at telegraphics dot com.au
2010-10-26 21:04 ` [Bug target/46179] " schwab@linux-m68k.org
2010-10-26 22:14 ` mkuvyrkov at gcc dot gnu.org [this message]
2010-10-27  0:47 ` fthain at telegraphics dot com.au
2010-10-27  8:41 ` schwab@linux-m68k.org
2010-10-27 13:28 ` fthain at telegraphics dot com.au
2010-10-28 15:21 ` fthain at telegraphics dot com.au
2010-10-28 15:34 ` fthain at telegraphics dot com.au
2010-11-01 16:08 ` tg at mirbsd dot org
2010-11-04 13:12 ` mkuvyrkov at gcc dot gnu.org
2010-11-04 16:27 ` tg at mirbsd dot org
2010-12-12 14:04 ` schwab at gcc dot gnu.org
2010-12-12 14:09 ` schwab@linux-m68k.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101026221400.cuTA7Q8MDDgChiwTEijYFV-ebFRi_QCtEoCAwkWX2To@z \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).