public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/46196] [OOP] gfortran compiles invalid generic TBP: dummy arguments are type compatible
Date: Wed, 27 Oct 2010 20:32:00 -0000 [thread overview]
Message-ID: <20101027203200.Q6uaTJ3JzEqwW_blbg5Jjb0Tlf1Ab1DLm9eyK0jUMIc@z> (raw)
In-Reply-To: <bug-46196-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46196
janus at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2010.10.27 20:32:13
AssignedTo|unassigned at gcc dot |janus at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
--- Comment #2 from janus at gcc dot gnu.org 2010-10-27 20:32:13 UTC ---
Draft patch. It seems to fix this PR as well as all of PR44917 and PR44926. Not
tested for regressions yet.
Index: gcc/fortran/interface.c
===================================================================
--- gcc/fortran/interface.c (revision 165975)
+++ gcc/fortran/interface.c (working copy)
@@ -872,7 +872,8 @@ count_types_test (gfc_formal_arglist *f1, gfc_form
/* Find other nonoptional arguments of the same type/rank. */
for (j = i + 1; j < n1; j++)
if ((arg[j].sym == NULL || !arg[j].sym->attr.optional)
- && compare_type_rank_if (arg[i].sym, arg[j].sym))
+ && (compare_type_rank_if (arg[i].sym, arg[j].sym)
+ || compare_type_rank_if (arg[j].sym, arg[i].sym)))
arg[j].flag = k;
k++;
@@ -897,7 +898,8 @@ count_types_test (gfc_formal_arglist *f1, gfc_form
ac2 = 0;
for (f = f2; f; f = f->next)
- if (compare_type_rank_if (arg[i].sym, f->sym))
+ if (compare_type_rank_if (arg[i].sym, f->sym)
+ || compare_type_rank_if (f->sym, arg[i].sym))
ac2++;
if (ac1 > ac2)
@@ -948,7 +950,8 @@ generic_correspondence (gfc_formal_arglist *f1, gf
if (f1->sym->attr.optional)
goto next;
- if (f2 != NULL && compare_type_rank (f1->sym, f2->sym))
+ if (f2 != NULL && (compare_type_rank (f1->sym, f2->sym)
+ || compare_type_rank (f2->sym, f1->sym)))
goto next;
/* Now search for a disambiguating keyword argument starting at
next prev parent reply other threads:[~2010-10-27 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 9:34 [Bug fortran/46196] New: " boschmann at tp1 dot physik.uni-siegen.de
2010-10-27 11:58 ` [Bug fortran/46196] " janus at gcc dot gnu.org
2010-10-27 20:32 ` janus at gcc dot gnu.org [this message]
2010-10-27 21:51 ` dominiq at lps dot ens.fr
2010-10-28 15:33 ` janus at gcc dot gnu.org
2010-10-28 21:06 ` dominiq at lps dot ens.fr
2010-10-28 21:58 ` mikael at gcc dot gnu.org
2010-10-29 8:31 ` janus at gcc dot gnu.org
2010-10-29 16:01 ` dominiq at lps dot ens.fr
2010-10-30 9:33 ` janus at gcc dot gnu.org
2010-10-30 11:52 ` dominiq at lps dot ens.fr
2010-10-30 12:52 ` mikael at gcc dot gnu.org
2010-10-30 13:53 ` janus at gcc dot gnu.org
2010-10-30 14:31 ` janus at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027203200.Q6uaTJ3JzEqwW_blbg5Jjb0Tlf1Ab1DLm9eyK0jUMIc@z \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).