public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid
@ 2010-10-29 15:55 rth at gcc dot gnu.org
2010-10-29 15:58 ` [Bug rtl-optimization/46226] " rth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 15:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
Summary: asm goto may leave stack pointer invalid
Product: gcc
Version: 4.5.1
Status: UNCONFIRMED
Severity: major
Priority: P3
Component: rtl-optimization
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: rth@gcc.gnu.org
Created attachment 22199
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22199
Failing test case
The following test case shows how do_pending_stack_adjust is
not properly called before the new kind of control flow insn
is emitted.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
@ 2010-10-29 15:58 ` rth at gcc dot gnu.org
2010-10-29 16:56 ` rth at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 15:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2010.10.29 15:58:07
AssignedTo|unassigned at gcc dot |rth at gcc dot gnu.org
|gnu.org |
Target Milestone|--- |4.5.2
Ever Confirmed|0 |1
Severity|major |normal
--- Comment #1 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 15:58:07 UTC ---
Forgot to mention the compilation flags:
gcc -m32 --save-temps -Os -march=i486 -fomit-frame-pointer z.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
2010-10-29 15:58 ` [Bug rtl-optimization/46226] " rth at gcc dot gnu.org
@ 2010-10-29 16:56 ` rth at gcc dot gnu.org
2010-10-29 16:58 ` rth at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 16:56 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
--- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 16:56:26 UTC ---
Author: rth
Date: Fri Oct 29 16:56:18 2010
New Revision: 166067
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166067
Log:
PR rtl-opt/46226
* stmt.c (expand_asm_operands): Call do_pending_stack_adjust
for asm goto.
Added:
trunk/gcc/testsuite/gcc.dg/pr46226.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/stmt.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
2010-10-29 15:58 ` [Bug rtl-optimization/46226] " rth at gcc dot gnu.org
2010-10-29 16:56 ` rth at gcc dot gnu.org
@ 2010-10-29 16:58 ` rth at gcc dot gnu.org
2010-10-29 17:05 ` rth at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 16:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
--- Comment #3 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 16:58:43 UTC ---
Author: rth
Date: Fri Oct 29 16:58:36 2010
New Revision: 166068
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166068
Log:
PR rtl-opt/46226
* stmt.c (expand_asm_operands): Call do_pending_stack_adjust
for asm goto.
Added:
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
branches/gcc-4_5-branch/gcc/stmt.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
` (2 preceding siblings ...)
2010-10-29 16:58 ` rth at gcc dot gnu.org
@ 2010-10-29 17:05 ` rth at gcc dot gnu.org
2010-10-29 17:13 ` rth at gcc dot gnu.org
2010-10-29 17:16 ` rth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 17:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
CC| |jakub at gcc dot gnu.org
Resolution| |FIXED
--- Comment #4 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:04:51 UTC ---
Fixed.
Jakub, I know that you've back-ported asm-goto to several
redhat branches, but I don't recall which ones. Obviously
the patch will need inclusion there too.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
` (3 preceding siblings ...)
2010-10-29 17:05 ` rth at gcc dot gnu.org
@ 2010-10-29 17:13 ` rth at gcc dot gnu.org
2010-10-29 17:16 ` rth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 17:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
--- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:12:51 UTC ---
Author: rth
Date: Fri Oct 29 17:12:46 2010
New Revision: 166069
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166069
Log:
PR rtl-opt/46226
Move test case to x86 test directory.
Added:
trunk/gcc/testsuite/gcc.target/i386/pr46226.c
- copied, changed from r166067, trunk/gcc/testsuite/gcc.dg/pr46226.c
Removed:
trunk/gcc/testsuite/gcc.dg/pr46226.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/46226] asm goto may leave stack pointer invalid
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
` (4 preceding siblings ...)
2010-10-29 17:13 ` rth at gcc dot gnu.org
@ 2010-10-29 17:16 ` rth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2010-10-29 17:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
--- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:16:16 UTC ---
Author: rth
Date: Fri Oct 29 17:16:11 2010
New Revision: 166070
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166070
Log:
PR rtl-opt/46226
Move test case to x86 test directory.
Added:
branches/gcc-4_5-branch/gcc/testsuite/gcc.target/i386/pr46226.c
- copied, changed from r166068,
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c
Removed:
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-10-29 17:16 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-29 15:55 [Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid rth at gcc dot gnu.org
2010-10-29 15:58 ` [Bug rtl-optimization/46226] " rth at gcc dot gnu.org
2010-10-29 16:56 ` rth at gcc dot gnu.org
2010-10-29 16:58 ` rth at gcc dot gnu.org
2010-10-29 17:05 ` rth at gcc dot gnu.org
2010-10-29 17:13 ` rth at gcc dot gnu.org
2010-10-29 17:16 ` rth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).