[Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid

[Bug rtl-optimization/46226] New: asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

           Summary: asm goto may leave stack pointer invalid
           Product: gcc
           Version: 4.5.1
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rth@gcc.gnu.org


Created attachment 22199
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22199
Failing test case

The following test case shows how do_pending_stack_adjust is
not properly called before the new kind of control flow insn
is emitted.

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.10.29 15:58:07
         AssignedTo|unassigned at gcc dot       |rth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.5.2
     Ever Confirmed|0                           |1
           Severity|major                       |normal

--- Comment #1 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 15:58:07 UTC ---
Forgot to mention the compilation flags:

gcc -m32 --save-temps -Os -march=i486 -fomit-frame-pointer z.c

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

--- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 16:56:26 UTC ---
Author: rth
Date: Fri Oct 29 16:56:18 2010
New Revision: 166067

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166067
Log:
PR rtl-opt/46226
* stmt.c (expand_asm_operands): Call do_pending_stack_adjust
for asm goto.

Added:
    trunk/gcc/testsuite/gcc.dg/pr46226.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/stmt.c

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

--- Comment #3 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 16:58:43 UTC ---
Author: rth
Date: Fri Oct 29 16:58:36 2010
New Revision: 166068

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166068
Log:
PR rtl-opt/46226
* stmt.c (expand_asm_operands): Call do_pending_stack_adjust
for asm goto.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/stmt.c

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #4 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:04:51 UTC ---
Fixed.

Jakub, I know that you've back-ported asm-goto to several
redhat branches, but I don't recall which ones.  Obviously
the patch will need inclusion there too.

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

--- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:12:51 UTC ---
Author: rth
Date: Fri Oct 29 17:12:46 2010
New Revision: 166069

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166069
Log:
PR rtl-opt/46226
Move test case to x86 test directory.

Added:
    trunk/gcc/testsuite/gcc.target/i386/pr46226.c
      - copied, changed from r166067, trunk/gcc/testsuite/gcc.dg/pr46226.c
Removed:
    trunk/gcc/testsuite/gcc.dg/pr46226.c

[Bug rtl-optimization/46226] asm goto may leave stack pointer invalid

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

--- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> 2010-10-29 17:16:16 UTC ---
Author: rth
Date: Fri Oct 29 17:16:11 2010
New Revision: 166070

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166070
Log:
PR rtl-opt/46226
Move test case to x86 test directory.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.target/i386/pr46226.c
      - copied, changed from r166068,
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c
Removed:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr46226.c