public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/46196] [OOP] gfortran compiles invalid generic TBP: dummy arguments are type compatible
Date: Sat, 30 Oct 2010 09:33:00 -0000 [thread overview]
Message-ID: <20101030093300.aRAe8W_Qa_bJpnmfMQAqN6HoxcPyFXSIYWrjOIkrge4@z> (raw)
In-Reply-To: <bug-46196-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46196
--- Comment #9 from janus at gcc dot gnu.org 2010-10-30 09:33:12 UTC ---
(In reply to comment #8)
> I have successfully regtested the following patch
Thanks.
> I also noticed that the
> fix for pr46067 use the asymmetry of gfc_compare_interfaces!-)
Right.
> --- ../_clean/gcc/fortran/interface.c 2010-10-27 23:47:20.000000000 +0200
> +++ gcc/fortran/interface.c 2010-10-29 10:55:07.000000000 +0200
> @@ -445,16 +445,16 @@ gfc_compare_derived_types (gfc_symbol *d
> /* Make sure that link lists do not put this function into an
> endless recursive loop! */
> if (!(dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived)
> - && !(dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived)
> + && !(dt2->ts.type == BT_DERIVED && derived2 == dt2->ts.u.derived)
> && gfc_compare_types (&dt1->ts, &dt2->ts) == 0)
> return 0;
>
> else if ((dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived)
> - && !(dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived))
> + && !(dt2->ts.type == BT_DERIVED && derived2 == dt2->ts.u.derived))
> return 0;
>
> else if (!(dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived)
> - && (dt1->ts.type == BT_DERIVED && derived1 == dt1->ts.u.derived))
> + && (dt2->ts.type == BT_DERIVED && derived2 == dt2->ts.u.derived))
> return 0;
Can we find any test case which is sensitive to this change?
> This has disturbed my bug collection for the following tests:
AFAICS all of the error messages are correct. Thanks for checking.
next prev parent reply other threads:[~2010-10-30 9:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 9:34 [Bug fortran/46196] New: " boschmann at tp1 dot physik.uni-siegen.de
2010-10-27 11:58 ` [Bug fortran/46196] " janus at gcc dot gnu.org
2010-10-27 20:32 ` janus at gcc dot gnu.org
2010-10-27 21:51 ` dominiq at lps dot ens.fr
2010-10-28 15:33 ` janus at gcc dot gnu.org
2010-10-28 21:06 ` dominiq at lps dot ens.fr
2010-10-28 21:58 ` mikael at gcc dot gnu.org
2010-10-29 8:31 ` janus at gcc dot gnu.org
2010-10-29 16:01 ` dominiq at lps dot ens.fr
2010-10-30 9:33 ` janus at gcc dot gnu.org [this message]
2010-10-30 11:52 ` dominiq at lps dot ens.fr
2010-10-30 12:52 ` mikael at gcc dot gnu.org
2010-10-30 13:53 ` janus at gcc dot gnu.org
2010-10-30 14:31 ` janus at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101030093300.aRAe8W_Qa_bJpnmfMQAqN6HoxcPyFXSIYWrjOIkrge4@z \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).