public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/46204] g++.dg/torture/stackalign/throw-1.C fails to compile on IA64
Date: Tue, 02 Nov 2010 17:31:00 -0000	[thread overview]
Message-ID: <20101102173100.V5IRXJYOQZs5rtCDPtSIw8Dgp6W9f9teQVN9zz-Wpsg@z> (raw)
In-Reply-To: <bug-46204-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46204

Alexander Monakov <amonakov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |amonakov at gcc dot gnu.org

--- Comment #2 from Alexander Monakov <amonakov at gcc dot gnu.org> 2010-11-02 17:30:54 UTC ---
The scheduler is confused by a conditional jump to the next instruction (and
the fact that the containing BB has only one outgoing edge, which is also
marked fallthru).  When we delete the successor block, we don't notice that we
are also deleting the label used in that fallthru condjump.

I'm testing the following patch:

diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c
index 141c935..9d6635b 100644
--- a/gcc/sel-sched-ir.c
+++ b/gcc/sel-sched-ir.c
@@ -3616,6 +3616,19 @@ maybe_tidy_empty_bb (basic_block bb, bool
recompute_toporder_p)
               rescan_p = true;
               break;
             }
+      else if (single_succ_p (pred_bb) && any_condjump_p (BB_END (pred_bb)))
+        {
+          if (INSN_SCHED_TIMES (BB_END (pred_bb)) == 0
+          && !IN_CURRENT_FENCE_P (BB_END (pred_bb)))
+        {
+          if (!sel_remove_insn (BB_END (pred_bb), false, false))
+            tidy_fallthru_edge (e);
+        }
+          else
+        sel_redirect_edge_and_branch (e, succ_bb);
+          rescan_p = true;
+          break;
+        }
         }
     }


  parent reply	other threads:[~2010-11-02 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 23:22 [Bug middle-end/46204] New: " sje at cup dot hp.com
2010-10-29 21:38 ` [Bug rtl-optimization/46204] " sje at cup dot hp.com
2010-11-02 17:31 ` amonakov at gcc dot gnu.org [this message]
2010-11-13  9:33 ` amonakov at gcc dot gnu.org
2010-11-13 10:02 ` amonakov at gcc dot gnu.org
2011-04-07  6:52 ` abel at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101102173100.V5IRXJYOQZs5rtCDPtSIw8Dgp6W9f9teQVN9zz-Wpsg@z \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).