[Bug lto/46273] New: [4.6 Regression] Failed to bootstrap

[Bug lto/46273] New: [4.6 Regression] Failed to bootstrap

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

           Summary: [4.6 Regression] Failed to bootstrap
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


On Linux/x86, revision 166200 gave

configure:10754: result: yes 
configure:10794: error: LTO plugin is not supported on this target.
...
make[2]: *** [configure-lto-plugin] Error 1

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iant at google dot com
   Target Milestone|---                         |4.6.0

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-02 17:28:04 UTC ---
It is caused by revision 166189:

http://gcc.gnu.org/ml/gcc-cvs/2010-11/msg00075.html

lto-plugin/configure.ac has

. ${srcdir}/../gcc/config.gcc
case ${lto_binary_reader} in
  *coff*) LTO_FORMAT=coff ;;
  *elf*)  LTO_FORMAT=elf ;;
  *) AC_MSG_ERROR([LTO plugin is not supported on this target.]) ;;
esac

But revision 166189 has:

* config.gcc: Don't set lto_binary_reader.

I don't think this patch has been tested on Linux/x86.

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian at airs dot com

--- Comment #2 from Ian Lance Taylor <ian at airs dot com> 2010-11-02 17:55:39 UTC ---
I tested it on linux/x86, of course, but not with the LTO plugin enabled.  I
will revert that part of the patch.

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[ian at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

--- Comment #3 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> 2010-11-02 17:58:52 UTC ---
Author: ian
Date: Tue Nov  2 17:58:45 2010
New Revision: 166207

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166207
Log:
    PR lto/46273
    * config.gcc: Revert last patch: set lto_binary_reader.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.gcc

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.11.02 22:49:51
                 CC|                            |davek at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |davek at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #4 from Dave Korn <davek at gcc dot gnu.org> 2010-11-02 22:49:51 UTC ---
I have a full fix for this.  I'll un-revert the removal as part of it since it
then will truly no longer be needed.

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build, patch
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2010-11/msg00229.htm
                   |                            |l

--- Comment #5 from Dave Korn <davek at gcc dot gnu.org> 2010-11-03 00:08:13 UTC ---
Patch posted at http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00229.html, tests
running.

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://gcc.gnu.org/ml/gcc-p |http://gcc.gnu.org/ml/gcc-p
                   |atches/2010-11/msg00229.htm |atches/2010-11/msg00233.htm
                   |l                           |l

--- Comment #6 from Dave Korn <davek at gcc dot gnu.org> 2010-11-03 01:02:20 UTC ---
respun patch.

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

--- Comment #7 from Dave Korn <davek at gcc dot gnu.org> 2010-11-03 09:14:36 UTC ---
Author: davek
Date: Wed Nov  3 09:14:32 2010
New Revision: 166233

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166233
Log:
ChangeLog:

2010-11-03  Ian Lance Taylor  <iant@google.com>
        Dave Korn  <dave.korn.cygwin@gmail.com>

    PR lto/46273
    * configure.ac: Remove libelf tests.  Build lto-plugin on ELF always
    and on other supported platforms whenever LTO is enabled.
    * configure: Rebuild.

gcc/ChangeLog:

2010-11-03  Ian Lance Taylor  <iant@google.com>

    PR lto/46273
    * gcc/config.gcc: Don't set lto_binary_reader.
    * doc/install.texi (Prerequisites): Remove libelf paragraphs.
    (Configuration): Mention --disable-lto.  Remove --with-libelf
    paragraph.

lto-plugin/ChangeLog:

2010-11-03  Dave Korn  <dave.korn.cygwin@gmail.com>

    PR lto/46273
    * lto-plugin.h: Delete.
    * lto-plugin-elf.c: Likewise.
    * lto-plugin-coff.c: Likewise.
    * configure.ac: Don't use libelf, don't source config.gcc.
    (LIBELFLIBS): Delete.
    (LIBELFINC): Delete.
    (LTO_FORMAT): Delete.
    (SYM_STYLE): Add AC_DEFINE var, set based on $target.
    (config.h): Add AC_CONFIG_HEADERS directive.
    * Makefile.am (LIBELFLIBS): Delete.
    (LIBELFINC): Delete.
    (LTO_FORMAT): Delete.
    (DEFS): Import.
    (AM_CPPFLAGS): Use it.  Don't use LIBELFINC.
    (liblto_plugin_la_SOURCES): Don't use LTO_FORMAT, don't include
    any object-format-specific source file in the link.
    (liblto_plugin_la_LIBADD): Don't use LIBELFLIBS.
    * config.h.in: Generate.
    * configure: Regenerate.
    * Makefile.in: Likewise.
    * lto-plugin.c (O_BINARY): Definition moved here from lto-plugin.h.
    (LTO_SEGMENT_NAME): New definition.
    (LTO_SECTION_PREFIX): Definition moved here from lto-plugin.h.
    (LTO_SECTION_PREFIX_LEN): New definition.
    (struct sym_aux): Struct definition moved here from lto-plugin.h.
    (struct plugin_symtab): Likewise.
    (struct plugin_objfile): Likewise.
    (struct plugin_objfile): New struct def.
    (enum symbol_style): New enum type.
    (add_symbols): Make static.
    (claimed_files): Likewise.
    (num_claimed_files): Likewise.
    (sym_style): New global.
    (check): Make static.
    (parse_table_entry): Likewise.  Respect sym_style when extracting
    symbol from symtab entry.
    (translate): Make static.
    (resolve_conflicts): Likewise.
    (process_symtab): New function, per-section callback version of
    old object-format-specific handling from deleted lto-plugin-elf.c.
    (claim_file_handler): Convert ELF-specific version from deleted
    lto-plugin-elf.c to simple_object interface and move here.
    (process_options): Allow new '-sym-style=' option.
    (onload): Don't call deleted onload_format_checks hook.


Added:
    trunk/lto-plugin/config.h.in
Removed:
    trunk/lto-plugin/lto-plugin-coff.c
    trunk/lto-plugin/lto-plugin-elf.c
    trunk/lto-plugin/lto-plugin.h
Modified:
    trunk/ChangeLog
    trunk/configure
    trunk/configure.ac
    trunk/gcc/ChangeLog
    trunk/gcc/config.gcc
    trunk/gcc/doc/install.texi
    trunk/lto-plugin/ChangeLog
    trunk/lto-plugin/Makefile.am
    trunk/lto-plugin/Makefile.in
    trunk/lto-plugin/configure
    trunk/lto-plugin/configure.ac
    trunk/lto-plugin/lto-plugin.c

[Bug lto/46273] [4.6 Regression] Failed to bootstrap

[davek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46273

Dave Korn <davek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Dave Korn <davek at gcc dot gnu.org> 2010-11-03 09:18:28 UTC ---
Fix committed revision 166233, as mentioned above.