From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-340592-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 14528 invoked by alias); 14 Dec 2010 13:18:27 -0000
Received: (qmail 14511 invoked by uid 22791); 14 Dec 2010 13:18:26 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from ksp.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.206)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 13:18:19 +0000
Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018)	id 5C022F1B05; Tue, 14 Dec 2010 14:18:16 +0100 (CET)
Date: Tue, 14 Dec 2010 13:18:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
Cc: gcc-bugs@gcc.gnu.org
Subject: Re: [Bug middle-end/46916]	gcc.dg/torture/stackalign/non-local-goto-[1,2].c ICEs compiler due	to r167727
Message-ID: <20101214131816.GN5409@atrey.karlin.mff.cuni.cz>
References: <bug-46916-4@http.gcc.gnu.org/bugzilla/> <bug-46916-4-lI6NmscYJI@http.gcc.gnu.org/bugzilla/>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bug-46916-4-lI6NmscYJI@http.gcc.gnu.org/bugzilla/>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-IsSubscribed: yes
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-12/txt/msg01575.txt.bz2

Hi,
does the following patch fix the problem?
darwin_text_section no longer needs to care about hot/cold code since this is
already done in darwin_function_section.

In fact you might additionally consider putting 
  return (DECL_WEAK (decl)
	  ? darwin_sections[text_coal_section]
	  : text_section);
into places returning NULL in darwin_function_section, removing case SECCAT_TEXT
from machopic_select_section undefining USE_SELECT_SECTION_FOR_FUNCTIONS
as suggested by rth as cleanup.

Honza

Index: opts.c
===================================================================
--- opts.c	(revision 167794)
+++ opts.c	(working copy)
@@ -738,6 +738,9 @@ finish_options (struct gcc_options *opts
       opts->x_flag_reorder_blocks = 1;
     }
 
+  if (opts->x_flag_reorder_blocks_and_partition)
+    opts->x_flag_reorder_blocks = 1;
+
   /* If the target requested unwind info, then turn off the partitioning
      optimization with a different message.  Likewise, if the target does not
      support named sections.  */
Index: config/darwin.c
===================================================================
--- config/darwin.c	(revision 167794)
+++ config/darwin.c	(working copy)
@@ -1145,16 +1145,11 @@ darwin_mark_decl_preserved (const char *
 }
 
 static section *
-darwin_text_section (int reloc, int weak)
+darwin_text_section (int weak)
 {
-  if (reloc)
-    return (weak
-	    ? darwin_sections[text_unlikely_coal_section]
-	    : unlikely_text_section ());
-  else
-    return (weak
-	    ? darwin_sections[text_coal_section]
-	    : text_section);
+  return (weak
+	  ? darwin_sections[text_coal_section]
+	  : text_section);
 }
 
 static section *