public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: Drew Ross <drross@redhat.com> To: gcc-bugs@gcc.gnu.org Cc: Drew Ross <drross@redhat.com> Subject: [PATCH] match.pd: Implement missed optimization (x << c) >> c -> -(x & 1) [PR101955] Date: Thu, 20 Jul 2023 10:47:11 -0400 [thread overview] Message-ID: <20230720144711.60975-1-drross@redhat.com> (raw) PR middle-end/101955 gcc/ChangeLog: * match.pd (x << c) >> c -> -(x & 1): New simplification. gcc/testsuite/ChangeLog: * gcc.dg/pr101955.c: New test. --- gcc/match.pd | 9 +++++ gcc/testsuite/gcc.dg/pr101955.c | 62 +++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr101955.c diff --git a/gcc/match.pd b/gcc/match.pd index 8543f777a28..bf63652e80f 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -3766,6 +3766,15 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) && (wi::ltu_p (wi::to_wide (@1), element_precision (type)))) (bit_and @0 (rshift { build_minus_one_cst (type); } @1)))) +/* Optimize (X << C) >> C where C = precision(type) - 1 and X is signed + into -(X & 1). */ +(simplify + (rshift (lshift @0 INTEGER_CST@1) @@1) + (if (ANY_INTEGRAL_TYPE_P (type) + && !TYPE_UNSIGNED (type) + && wi::eq_p (wi::to_wide (@1), element_precision (type) - 1)) + (negate (bit_and @0 { build_one_cst (type); })))) + /* Optimize x >> x into 0 */ (simplify (rshift @0 @0) diff --git a/gcc/testsuite/gcc.dg/pr101955.c b/gcc/testsuite/gcc.dg/pr101955.c new file mode 100644 index 00000000000..0e233269e21 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr101955.c @@ -0,0 +1,62 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-dse1 -Wno-psabi" } */ + +typedef int v4si __attribute__((vector_size(16))); + +__attribute__((noipa)) int +t1 (int x) +{ + return (x << 31) >> 31; +} + +__attribute__((noipa)) int +t2 (int x) +{ + int y = x << 31; + int z = y >> 31; + return z; +} + +__attribute__((noipa)) int +t3 (int x) +{ + int w = 31; + int y = x << w; + int z = y >> w; + return z; +} + +__attribute__((noipa)) long long +t4 (long long x) +{ + return (x << 63) >> 63; +} + +__attribute__((noipa)) long long +t5 (long long x) +{ + long long y = x << 63; + long long z = y >> 63; + return z; +} + +__attribute__((noipa)) long long +t6 (long long x) +{ + int w = 63; + long long y = x << w; + long long z = y >> w; + return z; +} + +__attribute__((noipa)) v4si +t7 (v4si x) +{ + return (x << 31) >> 31; +} + +/* { dg-final { scan-tree-dump-not " >> " "dse1" } } */ +/* { dg-final { scan-tree-dump-not " << " "dse1" } } */ +/* { dg-final { scan-tree-dump-times " -" 7 "dse1" } } */ +/* { dg-final { scan-tree-dump-times " & " 7 "dse1" } } */ + -- 2.39.3
next reply other threads:[~2023-07-20 14:47 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-20 14:47 Drew Ross [this message] 2023-07-20 14:52 ` Drew Ross 2023-07-20 15:17 ` Andrew Pinski 2023-07-20 18:08 ` Andrew Pinski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230720144711.60975-1-drross@redhat.com \ --to=drross@redhat.com \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).