public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "Daniel Berlin" <dberlin@dberlin.org>
To: gcc-bugzilla@gcc.gnu.org
Cc: gcc-bugs@gcc.gnu.org
Subject: Re: [Bug c/32575] [4.2/4.3 regression] With -ftree-vrp miscompiles a single line of code in SQLite
Date: Wed, 05 Sep 2007 11:50:00 -0000	[thread overview]
Message-ID: <4aca3dc20709050450w30978ae8n200280b70529c138@mail.gmail.com> (raw)
In-Reply-To: <20070828155829.23399.qmail@sourceware.org>

On 28 Aug 2007 15:58:29 -0000, jakub at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #6 from jakub at gcc dot gnu dot org  2007-08-28 15:58 -------
> if (a == 0) a = bar (); isn't necessary either.
>
> salias has:
>
>   # BLOCK 2 freq:10000
>   # PRED: ENTRY [100.0%]  (fallthru,exec)
>   # VUSE <qD.2026_12(D), SMT.25D.2079_13(D)> { qD.2026 SMT.25D.2079 }
>   D.2027_3 = foo ();
>   pD.2025_4 = (struct S *) D.2027_3;
>   if (pD.2025_4 == 0B)
>     goto <bb 3>;
>   else
>     goto <bb 4>;
>   # SUCC: 3 [7.3%]  (true,exec) 4 [92.7%]  (false,exec)
>
>   # BLOCK 3 freq:735
>   # PRED: 2 [7.3%]  (true,exec)
>   # qD.2026_15 = VDEF <qD.2026_12(D)>
>   # SMT.25D.2079_16 = VDEF <SMT.25D.2079_13(D)>
>   # SMT.26D.2080_17 = VDEF <SMT.26D.2080_14(D)> { qD.2026 SMT.25D.2079
> SMT.26D.2080 }
>   __builtin_memset (&qD.2026, 0, 24);
>   # SUCC: 4 [100.0%]  (fallthru,exec)
>
>   # BLOCK 4 freq:10000
>   # PRED: 2 [92.7%]  (false,exec) 3 [100.0%]  (fallthru,exec)
>   # qD.2026_11 = PHI <qD.2026_12(D)(2), qD.2026_15(3)>
>   # pD.2025_1 = PHI <pD.2025_4(2), &qD.2026(3)>
>   # qD.2026_18 = VDEF <qD.2026_11> { qD.2026 }
>   pD.2025_1->s1D.2008 = aD.2021_6(D);
>   # qD.2026_19 = VDEF <qD.2026_18> { qD.2026 }
>   pD.2025_1->s2D.2009 = bD.2022_7(D);
>
> Shouldn't the VDEFs be a PHI of some SMT and qD?
For VDEF/VUSE, you will never have a PHI of anything other than
multiple versions of the same SMT/virtual variable.

The above looks right to me at a glance.
It is probably pruning the result using TBAA which is what p->s isn't
thought to access the SMT.


  reply	other threads:[~2007-09-05 11:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-01 22:07 [Bug c/32575] New: GCC 4.3.0 with " drh at sqlite dot org
2007-07-01 22:16 ` [Bug tree-optimization/32575] " pinskia at gcc dot gnu dot org
2007-07-01 22:52 ` [Bug c/32575] " drh at sqlite dot org
2007-07-01 23:01 ` [Bug c/32575] GCC 4.2.0 " pinskia at gcc dot gnu dot org
2007-07-22 11:43 ` drh at sqlite dot org
2007-08-28 14:55 ` [Bug c/32575] [4.2/4.3 regression] With " jakub at gcc dot gnu dot org
2007-08-28 15:16 ` jakub at gcc dot gnu dot org
2007-08-28 15:58 ` jakub at gcc dot gnu dot org
2007-09-05 11:50   ` Daniel Berlin [this message]
2007-08-30 21:19 ` [Bug middle-end/32575] " pinskia at gcc dot gnu dot org
2007-09-05  0:56 ` mmitchel at gcc dot gnu dot org
2007-09-05 11:51 ` dberlin at dberlin dot org
2007-09-07 14:14 ` rguenth at gcc dot gnu dot org
2007-09-10 18:39 ` [Bug tree-optimization/32575] " jakub at gcc dot gnu dot org
2007-10-09 19:30 ` mmitchel at gcc dot gnu dot org
2007-11-01 14:03 ` nickc at redhat dot com
2007-11-01 14:06 ` nickc at redhat dot com
2007-11-01 14:34 ` jakub at gcc dot gnu dot org
2007-11-01 14:57 ` nickc at redhat dot com
2007-11-01 15:05 ` rguenth at gcc dot gnu dot org
2007-11-08 12:54 ` jakub at gcc dot gnu dot org
2007-11-08 13:08 ` jakub at gcc dot gnu dot org
2007-11-08 13:12 ` [Bug tree-optimization/32575] [4.2 " jakub at gcc dot gnu dot org
2008-02-01 17:05 ` jsm28 at gcc dot gnu dot org
2008-05-19 20:30 ` jsm28 at gcc dot gnu dot org
2009-03-30 22:11 ` jsm28 at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aca3dc20709050450w30978ae8n200280b70529c138@mail.gmail.com \
    --to=dberlin@dberlin.org \
    --cc=gcc-bugs@gcc.gnu.org \
    --cc=gcc-bugzilla@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).