RE: bug in /usr/include/c++/3.4/bits/fstream.tcc

RE: bug in /usr/include/c++/3.4/bits/fstream.tcc

[Jacob Schmidt Madsen]

please ignore the previous message. i was my mistake, since i had
include some work from another guy, who had "using namespace std" and
also defined a "min" and "max" - it causes a conflict.

sorry about the trouble!

-----Oprindelig meddelelse-----
Fra: gdr@integrable-solutions.net [mailto:gdr@integrable-solutions.net] 
Sendt: 9. december 2004 22:21
Til: Jacob Schmidt Madsen
Cc: gcc-bugs@gcc.gnu.org
Emne: Re: bug in /usr/include/c++/3.4/bits/fstream.tcc


"Jacob Schmidt Madsen" <JSMA@tdc.dk> writes:

| error:
| /usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
| typename std::basic_filebuf<_CharT, _Traits>::int_type
| std::basic_filebuf<_CharT, _Traits>::underflow()':
| /usr/include/c++/3.4/bits/fstream.tcc:277: error: expected
| unqualified-id before '(' token
| /usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
| std::streamsize std::basic_filebuf<_CharT, _Traits>::xsputn(const
| _CharT*, std::streamsize)':
| /usr/include/c++/3.4/bits/fstream.tcc:518: error: expected
| unqualified-id before '(' token
| 
| solution found at:
| http://gcc.gnu.org/ml/gcc-bugs/2004-07/msg02128.html
| 
| fix:
| change line 277 in /usr/include/c++/3.4/bits/fstream.tcc
| from: __ilen = std::min(__avail, __buflen);
| to: __ilen = min(__avail, __buflen);

I cannot see any reason why that would be a fix.

-- Gaby

Re: bug in /usr/include/c++/3.4/bits/fstream.tcc

[Gabriel Dos Reis]

"Jacob Schmidt Madsen" <JSMA@tdc.dk> writes:

| error:
| /usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
| typename std::basic_filebuf<_CharT, _Traits>::int_type
| std::basic_filebuf<_CharT, _Traits>::underflow()':
| /usr/include/c++/3.4/bits/fstream.tcc:277: error: expected
| unqualified-id before '(' token
| /usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
| std::streamsize std::basic_filebuf<_CharT, _Traits>::xsputn(const
| _CharT*, std::streamsize)':
| /usr/include/c++/3.4/bits/fstream.tcc:518: error: expected
| unqualified-id before '(' token
| 
| solution found at:
| http://gcc.gnu.org/ml/gcc-bugs/2004-07/msg02128.html
| 
| fix:
| change line 277 in /usr/include/c++/3.4/bits/fstream.tcc
| from: __ilen = std::min(__avail, __buflen);
| to: __ilen = min(__avail, __buflen);

I cannot see any reason why that would be a fix.

-- Gaby

Re: bug in /usr/include/c++/3.4/bits/fstream.tcc

[Paolo Carlini]

> solution found at:
> http://gcc.gnu.org/ml/gcc-bugs/2004-07/msg02128.html

Solution?!?
That PR is closed as INVALID for a reason and in fact nobody actually
removed those qualifiers from the library. The user code must be fixed
instead.

Thanks,
Paolo.

bug in /usr/include/c++/3.4/bits/fstream.tcc

[Jacob Schmidt Madsen]

error:
/usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
typename std::basic_filebuf<_CharT, _Traits>::int_type
std::basic_filebuf<_CharT, _Traits>::underflow()':
/usr/include/c++/3.4/bits/fstream.tcc:277: error: expected
unqualified-id before '(' token
/usr/include/c++/3.4/bits/fstream.tcc: In member function `virtual
std::streamsize std::basic_filebuf<_CharT, _Traits>::xsputn(const
_CharT*, std::streamsize)':
/usr/include/c++/3.4/bits/fstream.tcc:518: error: expected
unqualified-id before '(' token

solution found at:
http://gcc.gnu.org/ml/gcc-bugs/2004-07/msg02128.html

fix:
change line 277 in /usr/include/c++/3.4/bits/fstream.tcc
from: __ilen = std::min(__avail, __buflen);
to: __ilen = min(__avail, __buflen);

and...

change line 518 in /usr/include/c++/3.4/bits/fstream.tcc
from: const streamsize __limit = std::min(__chunk, __bufavail);
to: const streamsize __limit = min(__chunk, __bufavail);

> gcc -v
Using built-in specs.
Configured with: FreeBSD/i386 system compiler
Thread model: posix
gcc version 3.4.2 [FreeBSD] 20040728

OS:
FreeBSD 5.3-RELEASE