From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com
 [IPv6:2607:f8b0:4864:20::732])
 by sourceware.org (Postfix) with ESMTPS id 1A2A63982437
 for <gcc-bugs@gcc.gnu.org>; Wed, 23 Jun 2021 09:19:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A2A63982437
Received: by mail-qk1-x732.google.com with SMTP id i68so3454136qke.3
 for <gcc-bugs@gcc.gnu.org>; Wed, 23 Jun 2021 02:19:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4haFOAd5PeVRuQ0ShNgnaGykfF6+u4tefHvjOIPnljc=;
 b=DYeZv44hnMnYosg/A1fZ+XqySPVwldZyBFy6+LkWhJVKwpdkxHvH9uHfeFf1wMWCLU
 529+C8dIX718lea9cXLrkhlTS57UHvLyjvZhmJ3+W+wveyG7yHF+rmyHiiyymhXhyNww
 ZonkiOBDxo/nOfsbs5YjGkwBbRGLOOvd14sTD60MHNJSgUp2cVEdjWCW1wlqKZqLZo3z
 I/euwsixhoqvPFY7W9+LQjG8MMaelO18kAD6rzpodq+a0RTyVZYLF0N++IAkMVpU6/pi
 UrH+yBNqdp9M9m12jnAUfsk3qgMCRpah/7Y+kx87dzYLXN2Wy6mLt7AMHNkq5v++Tzfp
 Li3w==
X-Gm-Message-State: AOAM532i7Qna0G50XbCNHDVVfUGgU0uPLWnzuNG3pcx6xVU9tFyes1Lp
 IFIJOxGg5EM11R9quTOaK4qDAp6en20HIx1iZJY=
X-Google-Smtp-Source: ABdhPJy8IwigLLmMzFP/tNHV5qEjSsXwFUnl9OQ8HXfxtjXQhAeOpd/y8olvJRfmTM+JHRZIUoKbrEyROH38NReII2A=
X-Received: by 2002:a25:888e:: with SMTP id d14mr10421331ybl.443.1624439952400; 
 Wed, 23 Jun 2021 02:19:12 -0700 (PDT)
MIME-Version: 1.0
References: <1da31b4b-a0c7-ecca-0910-b152b0ec79a9@iis.ee.ethz.ch>
In-Reply-To: <1da31b4b-a0c7-ecca-0910-b152b0ec79a9@iis.ee.ethz.ch>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Wed, 23 Jun 2021 17:19:01 +0800
Message-ID: <CA+yXCZDE0uOAtYjdB9C7sTCf31oD_AD3HZ0obTLxM5o6y-Qp2Q@mail.gmail.com>
Subject: Re: RISC-V: Parsing custom extension that is version 0
To: Robert Balas <balasr@iis.ee.ethz.ch>
Cc: gcc-bugs@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jun 2021 09:19:14 -0000

Hi Robert:

My assumption is the version should never be 0.0, at least 0.1, so it
is treated as 2p0,
but I didn't check if the input is really 0p0 or 0, that's kind of bug
we need to fix.

And I am not familiar with PULP stuff, does it mean PULP really uses
version 0.0,
and intend to implement multiple-version of that on GCC?

On Mon, Jun 21, 2021 at 10:07 AM Robert Balas via Gcc-bugs
<gcc-bugs@gcc.gnu.org> wrote:
>
> When giving gcc a -march string with a custom extension of
> version 0 (for example pulpv0) then gcc will think assign in the
> default version of 2p0.
>
> In gcc/common/config/riscv/riscv-common.c the function
> riscv_subset_list::parsing_subset_version falls back to the
> default version (2p0) when parsing if the major and minor version
> are both zero (which is the case for the string "pulpv0"). This
> means both "pulpv0" and "pulpv2" will get assigned the version
> 2p0. Looks wrong to me.
>
> Robert