public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "stammark at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100000] non-leaf epologue/prologue used if MVE v4sf is used for load/return
Date: Thu, 09 Mar 2023 15:27:55 +0000 [thread overview]
Message-ID: <bug-100000-4-C5rxwNFNse@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100000-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100000
Stam Markianos-Wright <stammark at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stammark at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #4 from Stam Markianos-Wright <stammark at gcc dot gnu.org> ---
I tried out Richard's suggestion in arm_vector_mode_supported_p (allowing V8HF,
V4SF and V2DF unconditionally) and it seems to have worked! After a testsuite
run I found a few ICEs due to a number of patterns that needed enabling:
@mve_vpselq_<supf><mode> which was only enabled for mve.fp
And then all the patterns that were conditional on:
- "((TARGET_HAVE_MVE && VALID_MVE_SI_MODE (<MODE>mode))
- || (TARGET_HAVE_MVE_FLOAT && VALID_MVE_SF_MODE (<MODE>mode)))
mve_vec_extract<mode><V_elem_l>
*mve_vec_extract_sext_internal<mode>
*mve_vec_extract_zext_internal<mode>
mve_vec_set<mode>_internal
*movmisalign<mode>_mve_store
*movmisalign<mode>_mve_load
These weren't causing any ICEs but also made sense to enable:
mve_vst2q<mode>
mve_vld2q<mode>
mve_vld4q<mode>
No regressions after that, but I think I will hold off until GCC14 Stage 1 to
post this patch, just to be safe.
prev parent reply other threads:[~2023-03-09 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 14:43 [Bug target/100000] New: arm: Missed optimisation storing V4DF vector acoplan at gcc dot gnu.org
2021-04-10 20:16 ` [Bug target/100000] non-leaf epologue/prologue used if MVE v4sf is used for load/return pinskia at gcc dot gnu.org
2021-12-09 1:32 ` pinskia at gcc dot gnu.org
2023-01-25 17:45 ` rearnsha at gcc dot gnu.org
2023-01-25 17:50 ` rearnsha at gcc dot gnu.org
2023-03-09 15:27 ` stammark at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-100000-4-C5rxwNFNse@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).