[Bug fortran/100110] New: Parameterized Derived Types, problems with global variable

[Bug fortran/100110] New: Parameterized Derived Types, problems with global variable

[xiao.liu@compiler-dev.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

            Bug ID: 100110
           Summary: Parameterized Derived Types, problems with global
                    variable
           Product: gcc
           Version: 10.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: xiao.liu@compiler-dev.com
  Target Milestone: ---

the test case is,

program p
  implicit none
  type t(n)
    integer, len :: n
    integer :: arr(n, n)
  end type

  type(t(2)) :: obj
  print *, obj%n
  print *, shape(obj%arr)
  call test()
contains
  subroutine test()
    print *, obj%n
    print *, shape(obj%arr)
  end subroutine
end program

expected result is
           2
           2           2
           2
           2           2
but is
           0
           0           0
           0
           0           0

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |pault at gcc dot gnu.org
   Last reconfirmed|                            |2021-04-19
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Paul Thomas <pault at gcc dot gnu.org> ---
Hi Xiao,

Thank you for this report. I admit that the implementation of PDTs in gfortran
is broken. I didn't realise quite how broken it is:-(

Making 'obj' allocatable and allocating it produces the expected result.

I had planned that once gcc-11 is released, I would turn my attention to PDTs.

This one, I suspect, is such a low hanging fruit, that I will give it attention
now.

Best regards

Paul

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

--- Comment #2 from Paul Thomas <pault at gcc dot gnu.org> ---
Created attachment 50628
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50628&action=edit
Fix for the PR

As I thought, the fix is trivial.

Paul

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:67378cd63d62bf0c69e966d1d202a1e586550a68

commit r11-8255-g67378cd63d62bf0c69e966d1d202a1e586550a68
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 20 07:30:07 2021 +0100

    Fortran: Fix host associated PDT entity initialization [PR99307].

    2021-04-20  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/100110
            * trans-decl.c (gfc_get_symbol_decl): Replace test for host
            association with a check that the current and symbol namespaces
            are the same.

    gcc/testsuite/
            PR fortran/100110
            * gfortran.dg/pdt_31.f03: New test.
            * gfortran.dg/pdt_26.f03: Reduce 'builtin_malloc' count from 9
            to 8.

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:714b85f6fce0448b9d4d5e5d21152a3478b27422

commit r10-10106-g714b85f6fce0448b9d4d5e5d21152a3478b27422
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 20 07:30:07 2021 +0100

    Fortran: Fix host associated PDT entity initialization

    2021-04-20  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/100110
            * trans-decl.c (gfc_get_symbol_decl): Replace test for host
            association with a check that the current and symbol namespaces
            are the same.

    gcc/testsuite/
            PR fortran/100110
            * gfortran.dg/pdt_31.f03: New test.
            * gfortran.dg/pdt_26.f03: Reduce 'builtin_malloc' count from 9
            to 8.

    (cherry picked from commit 67378cd63d62bf0c69e966d1d202a1e586550a68)

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:f692856517393d60f745f20306173919e18fc71a

commit r9-9718-gf692856517393d60f745f20306173919e18fc71a
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Tue Apr 20 07:30:07 2021 +0100

    Fortran: Fix host associated PDT entity initialization

    2021-04-20  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/100110
            * trans-decl.c (gfc_get_symbol_decl): Replace test for host
            association with a check that the current and symbol namespaces
            are the same.

    gcc/testsuite/
            PR fortran/100110
            * gfortran.dg/pdt_31.f03: New test.
            * gfortran.dg/pdt_26.f03: Reduce 'builtin_malloc' count from 9
            to 8.

    (cherry picked from commit 67378cd63d62bf0c69e966d1d202a1e586550a68)

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Backported Paul's fix to remaining open branches.  Closing.

Thanks to everybody!

[Bug fortran/100110] Parameterized Derived Types, problems with global variable

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100110

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.5