public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100152] [10/11/12 Regression] used caller-saved register not preserved across a call.
Date: Fri, 23 Apr 2021 08:58:25 +0000	[thread overview]
Message-ID: <bug-100152-4-7g5a7dCRpt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100152-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100152

--- Comment #34 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #33)
> (In reply to Iain Sandoe from comment #32)
> > (In reply to Iain Sandoe from comment #31)
> > > (In reply to Richard Biener from comment #30)
> > > > (In reply to Iain Sandoe from comment #29)
> > > > > what is also somewhat peculiar is that replacing the first function in the
> > > > > reduced test case with "extern void ___UTF_8_put(char *a, int b);" changes
> > > > > the code-gen for the second function.
> > > > 
> > > > That might hint at IPA RA which you can try disabling via -fno-ipa-ra which
> > > > in turn hints at a target issue.  
> > > 
> > > yeah, it does switch back to using rbx, at least on the reduced test case.
> > 
> > (also on the original).
> > 
> > I wonder if the problem is that IPA can't "see" the lazy symbol resolver, so
> > it just sees a call to ___UTF_8_put and doesn't know that this will be
> > resolved indirectly.
> > 
> > .. but something similar must apply to PLT and targets with linker veneers ?
> 
> I don't know how IPA RA works in detail but obviously the target has to
> expose this detail.  It looks like IPA RA causes us to add some notes to
> call insns which are supposed to describe those details and there's
> collect_fn_hard_reg_usage which looks at the target function (but likely
> does not include the ABI details of the call itself, in this case the
> resolver).

@deftypevr {Target Hook} bool TARGET_CALL_FUSAGE_CONTAINS_NON_CALLEE_CLOBBERS
Set to true if each call that binds to a local definition explicitly
clobbers or sets all non-fixed registers modified by performing the call.
That is, by the call pattern itself, or by code that might be inserted by the
linker (e.g.@: stubs, veneers, branch islands), but not including those
modifiable by the callee.  The affected registers may be mentioned explicitly
in the call pattern, or included as clobbers in CALL_INSN_FUNCTION_USAGE.
The default version of this hook is set to false.  The purpose of this hook
is to enable the fipa-ra optimization.
@end deftypevr

might be relevant - though when compiling for a shared library the call
to ___UTF_8_put does not bind locally (but then IPA RA shouldn't apply
either I guess).  So, does ___UTF_8_put bind locally?

  parent reply	other threads:[~2021-04-23  8:58 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 13:48 [Bug target/100152] New: Possible 10.3 bad code generation regression from 10.2/9.3 on Mac OS 10.15.7 (Catalina) lucier at math dot purdue.edu
2021-04-20 13:48 ` [Bug target/100152] " lucier at math dot purdue.edu
2021-04-20 13:50 ` lucier at math dot purdue.edu
2021-04-20 14:33 ` iains at gcc dot gnu.org
2021-04-20 14:36 ` iains at gcc dot gnu.org
2021-04-20 14:40 ` lucier at math dot purdue.edu
2021-04-20 14:43 ` iains at gcc dot gnu.org
2021-04-20 14:58 ` lucier at math dot purdue.edu
2021-04-20 15:02 ` iains at gcc dot gnu.org
2021-04-20 15:09 ` lucier at math dot purdue.edu
2021-04-20 15:13 ` lucier at math dot purdue.edu
2021-04-20 15:17 ` iains at gcc dot gnu.org
2021-04-20 15:24 ` lucier at math dot purdue.edu
2021-04-20 17:22 ` lucier at math dot purdue.edu
2021-04-21  4:27 ` gabravier at gmail dot com
2021-04-21  8:52 ` iains at gcc dot gnu.org
2021-04-21 13:17 ` lucier at math dot purdue.edu
2021-04-21 15:32 ` iains at gcc dot gnu.org
2021-04-21 18:12 ` lucier at math dot purdue.edu
2021-04-21 18:18 ` iains at gcc dot gnu.org
2021-04-21 18:29 ` iains at gcc dot gnu.org
2021-04-21 20:00 ` iains at gcc dot gnu.org
2021-04-21 20:38 ` iains at gcc dot gnu.org
2021-04-21 23:24 ` lucier at math dot purdue.edu
2021-04-22 10:28 ` [Bug target/100152] [10.3, 11, 12 Regression] [Darwin, X86] used caller-saved register not preserved across a call iains at gcc dot gnu.org
2021-04-22 12:54 ` lucier at math dot purdue.edu
2021-04-22 14:35 ` feeley at iro dot umontreal.ca
2021-04-22 23:13 ` [Bug target/100152] [10.3, 11, 12 Regression] " iains at gcc dot gnu.org
2021-04-23  0:32 ` iains at gcc dot gnu.org
2021-04-23  6:51 ` iains at gcc dot gnu.org
2021-04-23  8:13 ` [Bug target/100152] [10/11/12 " rguenth at gcc dot gnu.org
2021-04-23  8:32 ` iains at gcc dot gnu.org
2021-04-23  8:48 ` iains at gcc dot gnu.org
2021-04-23  8:54 ` rguenth at gcc dot gnu.org
2021-04-23  8:58 ` rguenth at gcc dot gnu.org [this message]
2021-04-23  9:05 ` rguenth at gcc dot gnu.org
2021-04-23  9:09 ` iains at gcc dot gnu.org
2021-04-23 11:02 ` rguenth at gcc dot gnu.org
2021-04-23 12:34 ` iains at gcc dot gnu.org
2021-04-23 12:57 ` rguenth at gcc dot gnu.org
2021-04-23 12:58 ` rguenth at gcc dot gnu.org
2021-04-23 13:13 ` iains at gcc dot gnu.org
2021-04-24 12:41 ` iains at gcc dot gnu.org
2021-04-24 12:45 ` cvs-commit at gcc dot gnu.org
2021-04-24 18:45 ` iains at gcc dot gnu.org
2021-05-02 15:36 ` iains at gcc dot gnu.org
2021-05-03  7:54 ` iains at gcc dot gnu.org
2021-05-09  1:57 ` lucier at math dot purdue.edu
2021-05-09  7:25 ` iains at gcc dot gnu.org
2021-05-09 15:43 ` lucier at math dot purdue.edu
2021-05-09 19:22 ` iains at gcc dot gnu.org
2021-05-09 20:00 ` lucier at math dot purdue.edu
2021-05-09 22:36 ` iains at gcc dot gnu.org
2021-05-11  7:48 ` iains at gcc dot gnu.org
2021-05-13  3:35 ` lucier at math dot purdue.edu
2021-05-14 14:04 ` jakub at gcc dot gnu.org
2021-07-09 16:42 ` cvs-commit at gcc dot gnu.org
2021-07-20  6:52 ` cvs-commit at gcc dot gnu.org
2021-07-20  7:00 ` [Bug target/100152] [10 " iains at gcc dot gnu.org
2021-07-22 15:21 ` lucier at math dot purdue.edu
2022-05-29 19:13 ` cvs-commit at gcc dot gnu.org
2022-05-29 19:25 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100152-4-7g5a7dCRpt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).