public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/100173] telecom/viterb00data_1 has 16.92% regression compared O2 -ftree-vectorize -fvect-cost-model=very-cheap to O2 on CLX/ICX, 9% regression on znver3 Date: Wed, 21 Apr 2021 06:46:31 +0000 [thread overview] Message-ID: <bug-100173-4-aLw77n4468@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100173-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100173 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |missed-optimization --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- Note that store commoning of code sinking will sink the last store anyway: @@ -546,7 +233,6 @@ _27 = _26 << 1; _28 = (short int) _27; _29 = _28 | 1; - MEM[(struct StatePathMetricData *)pOut_90 + 4B].m_esState = _29; goto <bb 9>; [100.00%] <bb 8> [local count: 505302904]: @@ -556,21 +242,19 @@ _32 = _31 << 1; _33 = (short int) _32; _34 = _33 | 1; - MEM[(struct StatePathMetricData *)pOut_90 + 4B].m_esState = _34; <bb 9> [local count: 1010605809]: + # _94 = PHI <_29(7), _34(8)> + MEM[(struct StatePathMetricData *)pOut_90 + 4B].m_esState = _94; but yes, cselim will also sink the first store, moving it across the scalar compute in the block. I might note that ideally we'd sink all the compute as well and end up with just a conditional load of either pIn1->m_esState or pIn2_89->m_esState. That might then allow scheduling to recover the original performance. You can try that as a source transform, like e_s16 tem1, tem2; if (esMetric1 >=esMetric2) { tem1 = esMetric1; tem2 = pIn1->m_esState; } else { tem1 = esMetric2; tem2 = pIn2->m_esState; } pOut->m_esPathMetric =tem1; pOut->m_esState = (tem2 << 1) | 1;
next prev parent reply other threads:[~2021-04-21 6:46 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-21 5:48 [Bug tree-optimization/100173] New: " crazylht at gmail dot com 2021-04-21 6:46 ` rguenth at gcc dot gnu.org [this message] 2021-04-29 3:02 ` [Bug tree-optimization/100173] " crazylht at gmail dot com 2021-04-29 6:57 ` rguenther at suse dot de 2021-04-29 11:02 ` crazylht at gmail dot com 2021-04-29 12:15 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100173-4-aLw77n4468@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).