public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100204] aarch64: UB evaluating J constraint
Date: Mon, 19 Jul 2021 07:43:43 +0000	[thread overview]
Message-ID: <bug-100204-4-w3bf2qxEkQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100204-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100204

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(define_constraint "J"
 "A constant that can be used with a SUB operation (once negated)."
 (and (match_code "const_int")
      (match_test "aarch64_uimm12_shift (-ival)")))



So this should be:
- (unsigned HOST_WIDE_INT) ival



There are other targets which have a similar issue:
config/alpha/constraints.md:       (match_test "IN_RANGE (-ival, 0, 255)")))
config/arc/constraints.md:       (match_test "UNSIGNED_INT6 (-ival)")))
config/arc/constraints.md:                      && ((ival >= 0 ? ival : -ival)
config/arc/constraints.md:                          <= 0x3f * (ival &
-ival)))")))
config/arc/constraints.md:       (match_test "!(ival & ~124) || !(-ival &
~124)")))
config/arc/constraints.md:                      && ((ival >= 0 ? ival : -ival)
config/arc/constraints.md:                          <= 0x7ff * (ival &
-ival)))")))
config/arc/constraints.md:       (match_test "IS_POWEROF2_P (-ival)")
config/arc/constraints.md:       (match_test "IS_POWEROF2_OR_0_P (ival + (ival
& -ival))")))
config/arc/constraints.md:                  || ((ival & 0xffffffffUL) >>
exact_log2 (ival & -ival)
config/arm/constraints.md:         (match_test "((-ival) & 0xfffff000) ==
0"))))
config/arm/constraints.md:      (match_test "TARGET_32BIT ? const_ok_for_arm
(-ival)
config/csky/constraints.md:       (match_test "CSKY_CONST_OK_FOR_Uj (-ival +
4)")))
config/epiphany/constraints.md:       (match_test "SIMM11 (-ival)")))
config/pru/constraints.md:       (match_test "UBYTE_INT (-ival)")))

  reply	other threads:[~2021-07-19  7:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 10:54 [Bug target/100204] New: " acoplan at gcc dot gnu.org
2021-07-19  7:43 ` pinskia at gcc dot gnu.org [this message]
2021-07-19  7:43 ` [Bug target/100204] " pinskia at gcc dot gnu.org
2024-01-24 22:37 ` pinskia at gcc dot gnu.org
2024-01-25 19:58 ` cvs-commit at gcc dot gnu.org
2024-01-25 19:58 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100204-4-w3bf2qxEkQ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).